diff options
| author | Radomir Dopieralski <openstack@sheep.art.pl> | 2014-01-03 17:31:49 +0100 |
|---|---|---|
| committer | Radomir Dopieralski <openstack@sheep.art.pl> | 2014-01-07 12:26:35 +0100 |
| commit | 028332da4acb1ef6b9b9a1026affcf97e5501a84 (patch) | |
| tree | cfbcc14926c8f25faf2331bb9e8f8f5cd12df753 /horizon/browsers | |
| parent | 6fd1a1522ae88d3b2576473b76164250ee6f2532 (diff) | |
| download | horizon-028332da4acb1ef6b9b9a1026affcf97e5501a84.tar.gz | |
Remove #noqa from most common imports and add them to import_exceptions
We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.
I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.
I also removed a few unused imports that were revealed in the process.
Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
Diffstat (limited to 'horizon/browsers')
| -rw-r--r-- | horizon/browsers/base.py | 2 | ||||
| -rw-r--r-- | horizon/browsers/views.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/horizon/browsers/base.py b/horizon/browsers/base.py index 362f162b1..37dcf79a7 100644 --- a/horizon/browsers/base.py +++ b/horizon/browsers/base.py @@ -15,7 +15,7 @@ # under the License. from django import template -from django.utils.translation import ugettext_lazy as _ # noqa +from django.utils.translation import ugettext_lazy as _ from horizon.browsers.breadcrumb import Breadcrumb # noqa from horizon.tables import DataTable # noqa diff --git a/horizon/browsers/views.py b/horizon/browsers/views.py index 84daa5695..e10a51fab 100644 --- a/horizon/browsers/views.py +++ b/horizon/browsers/views.py @@ -14,7 +14,7 @@ # License for the specific language governing permissions and limitations # under the License. -from django.utils.translation import ugettext_lazy as _ # noqa +from django.utils.translation import ugettext_lazy as _ from horizon.tables import MultiTableView # noqa from horizon.utils import memoized |