Move volume snapshots table to volumes panel

Now that instance snapshots are just images, the images & snapshots
page only has images and volume snapshots. This is an odd combination.
I think we should now move volume snapshots to the volumes panel,
since a volume snapshot is tied to a volume.

Closes-Bug: #1190843
Change-Id: I3e12cec8b859a30db9f131e9889a92277e064086

1 files changed, 299 insertions, 0 deletions

diff --git a/openstack_dashboard/dashboards/project/images/tests.py b/openstack_dashboard/dashboards/project/images/tests.py
new file mode 100644
index 000000000..d95369243
--- /dev/null
+++ b/openstack_dashboard/dashboards/project/images/tests.py
@@ -0,0 +1,299 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright 2012 United States Government as represented by the
+# Administrator of the National Aeronautics and Space Administration.
+# All Rights Reserved.
+#
+# Copyright 2012 Nebula, Inc.
+# Copyright 2012 OpenStack Foundation
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+from django.core.urlresolvers import reverse
+from django import http
+
+from mox import IsA  # noqa
+
+from horizon import exceptions
+
+from openstack_dashboard import api
+from openstack_dashboard.dashboards.project.images import utils
+from openstack_dashboard.test import helpers as test
+
+
+INDEX_URL = reverse('horizon:project:images:index')
+
+
+class ImagesAndSnapshotsTests(test.TestCase):
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_index(self):
+        images = self.images.list()
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       marker=None).AndReturn([images, False])
+        self.mox.ReplayAll()
+
+        res = self.client.get(INDEX_URL)
+        self.assertTemplateUsed(res, 'project/images/index.html')
+        self.assertIn('images_table', res.context)
+        images_table = res.context['images_table']
+        images = images_table.data
+
+        self.assertTrue(len(images), 3)
+        row_actions = images_table.get_row_actions(images[0])
+        self.assertTrue(len(row_actions), 3)
+        row_actions = images_table.get_row_actions(images[1])
+        self.assertTrue(len(row_actions), 2)
+        self.assertTrue('delete_image' not in
+                [a.name for a in row_actions])
+        row_actions = images_table.get_row_actions(images[2])
+        self.assertTrue(len(row_actions), 3)
+
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_index_no_images(self):
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       marker=None).AndReturn([(), False])
+        self.mox.ReplayAll()
+
+        res = self.client.get(INDEX_URL)
+        self.assertTemplateUsed(res, 'project/images/index.html')
+
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_index_error(self):
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       marker=None) \
+            .AndRaise(self.exceptions.glance)
+        self.mox.ReplayAll()
+
+        res = self.client.get(INDEX_URL)
+        self.assertTemplateUsed(res, 'project/images/index.html')
+
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_snapshot_actions(self):
+        snapshots = self.snapshots.list()
+        api.glance.image_list_detailed(IsA(http.HttpRequest), marker=None) \
+            .AndReturn([snapshots, False])
+        self.mox.ReplayAll()
+
+        res = self.client.get(INDEX_URL)
+        self.assertTemplateUsed(res, 'project/images/index.html')
+        self.assertIn('images_table', res.context)
+        snaps = res.context['images_table']
+        self.assertEqual(len(snaps.get_rows()), 3)
+
+        row_actions = snaps.get_row_actions(snaps.data[0])
+
+        # first instance - status active, owned
+        self.assertEqual(len(row_actions), 4)
+        self.assertEqual(row_actions[0].verbose_name, u"Launch")
+        self.assertEqual(row_actions[1].verbose_name, u"Create Volume")
+        self.assertEqual(row_actions[2].verbose_name, u"Edit")
+        self.assertEqual(row_actions[3].verbose_name, u"Delete Image")
+
+        row_actions = snaps.get_row_actions(snaps.data[1])
+
+        # second instance - status active, not owned
+        self.assertEqual(len(row_actions), 2)
+        self.assertEqual(row_actions[0].verbose_name, u"Launch")
+        self.assertEqual(row_actions[1].verbose_name, u"Create Volume")
+
+        row_actions = snaps.get_row_actions(snaps.data[2])
+        # third instance - status queued, only delete is available
+        self.assertEqual(len(row_actions), 1)
+        self.assertEqual(unicode(row_actions[0].verbose_name),
+                         u"Delete Image")
+        self.assertEqual(str(row_actions[0]), "<DeleteImage: delete>")
+
+
+class ImagesAndSnapshotsUtilsTests(test.TestCase):
+
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_list_image(self):
+        public_images = [image for image in self.images.list()
+                         if image.status == 'active' and image.is_public]
+        private_images = [image for image in self.images.list()
+                          if (image.status == 'active' and
+                              not image.is_public)]
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       filters={'is_public': True,
+                                                'status': 'active'}) \
+                  .AndReturn([public_images, False])
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': self.tenant.id,
+                                     'status': 'active'}) \
+                  .AndReturn([private_images, False])
+
+        self.mox.ReplayAll()
+
+        ret = utils.get_available_images(self.request, self.tenant.id)
+
+        expected_images = [image for image in self.images.list()
+                           if (image.status == 'active' and
+                               image.container_format not in ('ami', 'aki'))]
+        self.assertEqual(len(expected_images), len(ret))
+
+    @test.create_stubs({api.glance: ('image_list_detailed',)})
+    def test_list_image_using_cache(self):
+        public_images = [image for image in self.images.list()
+                         if image.status == 'active' and image.is_public]
+        private_images = [image for image in self.images.list()
+                          if (image.status == 'active' and
+                              not image.is_public)]
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       filters={'is_public': True,
+                                                'status': 'active'}) \
+                  .AndReturn([public_images, False])
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': self.tenant.id,
+                                     'status': 'active'}) \
+                  .AndReturn([private_images, False])
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': 'other-tenant',
+                                     'status': 'active'}) \
+                  .AndReturn([private_images, False])
+
+        self.mox.ReplayAll()
+
+        expected_images = [image for image in self.images.list()
+                           if (image.status == 'active' and
+                               image.container_format not in ('ari', 'aki'))]
+
+        images_cache = {}
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertEqual(
+            len(public_images),
+            len(images_cache['public_images']))
+        self.assertEqual(1, len(images_cache['images_by_project']))
+        self.assertEqual(
+            len(private_images),
+            len(images_cache['images_by_project'][self.tenant.id]))
+
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+        self.assertEqual(len(expected_images), len(ret))
+
+        # image list for other-tenant
+        ret = utils.get_available_images(self.request, 'other-tenant',
+                                         images_cache)
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertEqual(
+            len(public_images),
+            len(images_cache['public_images']))
+        self.assertEqual(2, len(images_cache['images_by_project']))
+        self.assertEqual(
+            len(private_images),
+            len(images_cache['images_by_project']['other-tenant']))
+
+    @test.create_stubs({api.glance: ('image_list_detailed',),
+                        exceptions: ('handle',)})
+    def test_list_image_error_public_image_list(self):
+        public_images = [image for image in self.images.list()
+                         if image.status == 'active' and image.is_public]
+        private_images = [image for image in self.images.list()
+                          if (image.status == 'active' and
+                              not image.is_public)]
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       filters={'is_public': True,
+                                                'status': 'active'}) \
+                  .AndRaise(self.exceptions.glance)
+        exceptions.handle(IsA(http.HttpRequest),
+                          "Unable to retrieve public images.")
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': self.tenant.id,
+                                     'status': 'active'}) \
+                  .AndReturn([private_images, False])
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       filters={'is_public': True,
+                                                'status': 'active'}) \
+                  .AndReturn([public_images, False])
+
+        self.mox.ReplayAll()
+
+        images_cache = {}
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+
+        expected_images = [image for image in private_images
+                           if image.container_format not in ('ami', 'aki')]
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertNotIn('public_images', images_cache)
+        self.assertEqual(1, len(images_cache['images_by_project']))
+        self.assertEqual(
+            len(private_images),
+            len(images_cache['images_by_project'][self.tenant.id]))
+
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+
+        expected_images = [image for image in self.images.list()
+                           if image.container_format not in ('ami', 'aki')]
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertEqual(
+            len(public_images),
+            len(images_cache['public_images']))
+        self.assertEqual(1, len(images_cache['images_by_project']))
+        self.assertEqual(
+            len(private_images),
+            len(images_cache['images_by_project'][self.tenant.id]))
+
+    @test.create_stubs({api.glance: ('image_list_detailed',),
+                        exceptions: ('handle',)})
+    def test_list_image_error_private_image_list(self):
+        public_images = [image for image in self.images.list()
+                         if image.status == 'active' and image.is_public]
+        private_images = [image for image in self.images.list()
+                          if (image.status == 'active' and
+                              not image.is_public)]
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                                       filters={'is_public': True,
+                                                'status': 'active'}) \
+                  .AndReturn([public_images, False])
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': self.tenant.id,
+                                     'status': 'active'}) \
+                  .AndRaise(self.exceptions.glance)
+        exceptions.handle(IsA(http.HttpRequest),
+                          "Unable to retrieve images for the current project.")
+        api.glance.image_list_detailed(IsA(http.HttpRequest),
+                            filters={'property-owner_id': self.tenant.id,
+                                     'status': 'active'}) \
+                  .AndReturn([private_images, False])
+
+        self.mox.ReplayAll()
+
+        images_cache = {}
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+
+        expected_images = [image for image in public_images
+                           if image.container_format not in ('ami', 'aki')]
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertEqual(
+            len(public_images),
+            len(images_cache['public_images']))
+        self.assertFalse(len(images_cache['images_by_project']))
+
+        ret = utils.get_available_images(self.request, self.tenant.id,
+                                         images_cache)
+
+        expected_images = [image for image in self.images.list()
+                           if image.container_format not in ('ami', 'aki')]
+        self.assertEqual(len(expected_images), len(ret))
+        self.assertEqual(
+            len(public_images),
+            len(images_cache['public_images']))
+        self.assertEqual(1, len(images_cache['images_by_project']))
+        self.assertEqual(
+            len(private_images),
+            len(images_cache['images_by_project'][self.tenant.id]))