diff options
| author | Dmitry Tantsur <dtantsur@protonmail.com> | 2023-05-04 09:26:10 +0200 |
|---|---|---|
| committer | Dmitry Tantsur <dtantsur@protonmail.com> | 2023-05-04 09:26:10 +0200 |
| commit | c1c5537ba23b791e5041230db289bd5cd226ac7c (patch) | |
| tree | ec88f6c16eb2be02e2ca015fb917a33859eccb4e /ironic_python_agent/tests/unit/extensions/test_standby.py | |
| parent | c05fdf790c3cab6a18ca5b264e258c5c0016918d (diff) | |
| download | ironic-python-agent-c1c5537ba23b791e5041230db289bd5cd226ac7c.tar.gz | |
Revert disabling MD5 checksums
This was a significant breaking change that was landed despite explicit
disagreement by some community members (myself included). It has already
resulted in an accidental Ironic CI breakage, has broken Bifrost and has
a potential of breaking Metal3. In case of Metal3, MD5 support is a part
of its public API.
While MD5 is a potential security hazard, I don't see the need to hurry
this change without giving the community time to prepare. This change
reverts the new option md5_enabled to True.
Change-Id: I32b291ea162e8eb22429712c15cb5b225a6daafd
Diffstat (limited to 'ironic_python_agent/tests/unit/extensions/test_standby.py')
| -rw-r--r-- | ironic_python_agent/tests/unit/extensions/test_standby.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ironic_python_agent/tests/unit/extensions/test_standby.py b/ironic_python_agent/tests/unit/extensions/test_standby.py index 9f5a354b..195336df 100644 --- a/ironic_python_agent/tests/unit/extensions/test_standby.py +++ b/ironic_python_agent/tests/unit/extensions/test_standby.py @@ -123,6 +123,7 @@ class TestStandbyExtension(base.IronicAgentTest): standby._validate_image_info(None, image_info) def test_validate_image_info_legacy_md5_checksum(self): + CONF.set_override('md5_enabled', False) image_info = _build_fake_image_info() del image_info['os_hash_algo'] del image_info['os_hash_value'] |