diff options
| author | Riccardo Pittau <elfosardo@gmail.com> | 2019-09-25 14:38:30 +0200 |
|---|---|---|
| committer | Riccardo Pittau <elfosardo@gmail.com> | 2019-10-04 12:51:40 +0000 |
| commit | 05bf8f69d6eacd562cf3bba82bc7d692c00e8a3e (patch) | |
| tree | e30c73b0020b5a545710954c3280c9133b7328a8 | |
| parent | 5a0706ddbdc12acebc7480cf8a6db79d8d0bdf22 (diff) | |
| download | ironic-10.1.10.tar.gz | |
While the status node change message is purely informational, it
can contain also failed states transitions.
Moving the level from INFO to ERROR if the provision_state is
'failed' can help in detecting the transition message when
troubleshooting issues.
Change-Id: I79ff7cb8b9d33bc2837d41126fba269a5d4b1cda
(cherry picked from commit b8fa188a29481b11b2f3117cdeecfd920a8f5a0e)
| -rw-r--r-- | ironic/conductor/task_manager.py | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/ironic/conductor/task_manager.py b/ironic/conductor/task_manager.py index 1a3e6cff3..050cfbccd 100644 --- a/ironic/conductor/task_manager.py +++ b/ironic/conductor/task_manager.py @@ -485,12 +485,20 @@ class TaskManager(object): # publish the state transition by saving the Node self.node.save() - LOG.info('Node %(node)s moved to provision state "%(state)s" from ' - 'state "%(previous)s"; target provision state is ' - '"%(target)s"', - {'node': self.node.uuid, 'state': self.node.provision_state, - 'target': self.node.target_provision_state, - 'previous': self._prev_provision_state}) + + log_message = ('Node %(node)s moved to provision state "%(state)s" ' + 'from state "%(previous)s"; target provision state is ' + '"%(target)s"' % + {'node': self.node.uuid, + 'state': self.node.provision_state, + 'target': self.node.target_provision_state, + 'previous': self._prev_provision_state}) + + if (self.node.provision_state.endswith('failed') or + self.node.provision_state == 'error'): + LOG.error(log_message) + else: + LOG.info(log_message) if callback is None: self._notify_provision_state_change() |