diff options
author | Richard Pioso <richard.pioso@dell.com> | 2020-09-24 19:49:19 -0400 |
---|---|---|
committer | Richard Pioso <richard.pioso@dell.com> | 2020-09-24 20:50:29 -0400 |
commit | 5ff3defb5c2fdeb2fac0a94240208a591162bd2a (patch) | |
tree | 2154f5ace5c43a844e300450aac02799703839f6 | |
parent | 64085a29a2747f89cb35d360d2fb144ae66ee288 (diff) | |
download | ironic-5ff3defb5c2fdeb2fac0a94240208a591162bd2a.tar.gz |
Fix deprecated 'idrac' interface '__init__'s
This change fixes the deprecated 'idrac' hardware interface
implementation '__init__' methods to call their base class '__init__'
methods before emitting a log message warning about their deprecation.
Story: 2008197
Task: 40977
Change-Id: Ic6e2b6744850d429fae2d353a91649ea68371a59
-rw-r--r-- | ironic/drivers/modules/drac/inspect.py | 1 | ||||
-rw-r--r-- | ironic/drivers/modules/drac/management.py | 3 | ||||
-rw-r--r-- | ironic/drivers/modules/drac/power.py | 1 | ||||
-rw-r--r-- | ironic/drivers/modules/drac/raid.py | 1 | ||||
-rw-r--r-- | ironic/drivers/modules/drac/vendor_passthru.py | 1 | ||||
-rw-r--r-- | releasenotes/notes/idrac-fix-deprecated-idrac-interface-__init__-362696b389c86d5d.yaml | 8 |
6 files changed, 14 insertions, 1 deletions
diff --git a/ironic/drivers/modules/drac/inspect.py b/ironic/drivers/modules/drac/inspect.py index b944d3a2e..620a32273 100644 --- a/ironic/drivers/modules/drac/inspect.py +++ b/ironic/drivers/modules/drac/inspect.py @@ -248,5 +248,6 @@ class DracInspect(DracWSManInspect): """ def __init__(self): + super(DracInspect, self).__init__() LOG.warning("Inspect interface 'idrac' is deprecated and may be " "removed in a future release. Use 'idrac-wsman' instead.") diff --git a/ironic/drivers/modules/drac/management.py b/ironic/drivers/modules/drac/management.py index 68b09ecab..f595bea3b 100644 --- a/ironic/drivers/modules/drac/management.py +++ b/ironic/drivers/modules/drac/management.py @@ -2,7 +2,7 @@ # # Copyright 2014 Red Hat, Inc. # All Rights Reserved. -# Copyright (c) 2017-2019 Dell Inc. or its subsidiaries. +# Copyright (c) 2017-2020 Dell Inc. or its subsidiaries. # # Licensed under the Apache License, Version 2.0 (the "License"); you may # not use this file except in compliance with the License. You may obtain @@ -478,5 +478,6 @@ class DracManagement(DracWSManManagement): """ def __init__(self): + super(DracManagement, self).__init__() LOG.warning("Management interface 'idrac' is deprecated and may be " "removed in a future release. Use 'idrac-wsman' instead.") diff --git a/ironic/drivers/modules/drac/power.py b/ironic/drivers/modules/drac/power.py index a42b4d5d9..96f6f9932 100644 --- a/ironic/drivers/modules/drac/power.py +++ b/ironic/drivers/modules/drac/power.py @@ -263,5 +263,6 @@ class DracPower(DracWSManPower): """ def __init__(self): + super(DracPower, self).__init__() LOG.warning("Power interface 'idrac' is deprecated and may be removed " "in a future release. Use 'idrac-wsman' instead.") diff --git a/ironic/drivers/modules/drac/raid.py b/ironic/drivers/modules/drac/raid.py index 5d2d02341..8acf9188d 100644 --- a/ironic/drivers/modules/drac/raid.py +++ b/ironic/drivers/modules/drac/raid.py @@ -1549,5 +1549,6 @@ class DracRAID(DracWSManRAID): """ def __init__(self): + super(DracRAID, self).__init__() LOG.warning("RAID interface 'idrac' is deprecated and may be removed " "in a future release. Use 'idrac-wsman' instead.") diff --git a/ironic/drivers/modules/drac/vendor_passthru.py b/ironic/drivers/modules/drac/vendor_passthru.py index 620ea93e1..ff43cc95c 100644 --- a/ironic/drivers/modules/drac/vendor_passthru.py +++ b/ironic/drivers/modules/drac/vendor_passthru.py @@ -186,6 +186,7 @@ class DracVendorPassthru(DracWSManVendorPassthru): """ def __init__(self): + super(DracVendorPassthru, self).__init__() LOG.warning("Vendor passthru interface 'idrac' is deprecated and may " "be removed in a future release. Use 'idrac-wsman' " "instead.") diff --git a/releasenotes/notes/idrac-fix-deprecated-idrac-interface-__init__-362696b389c86d5d.yaml b/releasenotes/notes/idrac-fix-deprecated-idrac-interface-__init__-362696b389c86d5d.yaml new file mode 100644 index 000000000..dc331f2c6 --- /dev/null +++ b/releasenotes/notes/idrac-fix-deprecated-idrac-interface-__init__-362696b389c86d5d.yaml @@ -0,0 +1,8 @@ +--- +fixes: + - | + Fixes the deprecated ``idrac`` hardware interface implementation + ``__init__`` methods to call their base class ``__init__`` methods before + emitting a log message warning about their deprecation. For more + information, see `story 2008197 + <https://storyboard.openstack.org/#!/story/2008197>`_. |