summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulia Kreger <juliaashleykreger@gmail.com>2022-10-27 10:08:19 -0700
committerJulia Kreger <juliaashleykreger@gmail.com>2023-05-01 22:36:09 +0000
commitc03a5b44ef76018a384e7f2c3f4f247e1dc49e0a (patch)
tree1975e32e8408e13399bc8857aabf96b1337f17cf
parent75b881bd31952b8f858b4708fb83f7d2ca7c42cc (diff)
downloadironic-c03a5b44ef76018a384e7f2c3f4f247e1dc49e0a.tar.gz
Remove autocommit, again.
Patch Ic8b1d964f7be5784e01c89bfb6c0277ea82eec2d was developed without the autocommit change in place, which should allow Ironic to operate properly with sqlite, in a single process standalone mode. As such, we shouldn't need to keep autocommit turned on, but we may need to put it back if we identify yet another issue, which is entirely possible with major database refactors. Change-Id: Icde231e9db3b7a9f59205505cd51a4064e41d746
-rw-r--r--ironic/db/sqlalchemy/__init__.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/ironic/db/sqlalchemy/__init__.py b/ironic/db/sqlalchemy/__init__.py
index c656ed227..f92a0b600 100644
--- a/ironic/db/sqlalchemy/__init__.py
+++ b/ironic/db/sqlalchemy/__init__.py
@@ -17,10 +17,8 @@ from sqlalchemy import event
CONF = cfg.CONF
-# FIXME(stephenfin): we need to remove reliance on autocommit semantics ASAP
-# since it's not compatible with SQLAlchemy 2.0
# NOTE(dtantsur): we want sqlite as close to a real database as possible.
-enginefacade.configure(sqlite_fk=True, __autocommit=True)
+enginefacade.configure(sqlite_fk=True)
# NOTE(TheJulia): Setup a listener to trigger the sqlite write-ahead