summaryrefslogtreecommitdiff
path: root/devstack/lib/ironic
diff options
context:
space:
mode:
authorJulia Kreger <juliaashleykreger@gmail.com>2023-04-26 07:34:29 -0700
committerJulia Kreger <juliaashleykreger@gmail.com>2023-04-26 07:34:29 -0700
commitf2605e928136f88032ef9b4977a076d5c535987b (patch)
tree36024a640a37fd97ea7c1ab87d7a9035d0d602ef /devstack/lib/ironic
parent7083545731a8d5009f113f87b07710be833b627a (diff)
downloadironic-f2605e928136f88032ef9b4977a076d5c535987b.tar.gz
Remove use of nomodeset by default
The troubleshooting kernel command line option nomodeset unfortunately changes the way framebuffer interactions work with graphics devices which in some cases can result in kernel memory to be used for graphics updates. When this happens on some specific hardware common in rack mount servers with baseboard management controllers, this can cause the memory bus to become locked for a brief time while the graphics update is occuring. This locked memory bus means disk IO can become blocked, and network cards can overflow their buffers resulting in packet loss on top of the latency incurred by the graphics update executing. As such, we've removed the nomodeset option from default usage and added a note describing its removal to the documentation along with a release note. Change-Id: I9084d88c3ec6f13bd64b8707892758fa87dd7f86
Diffstat (limited to 'devstack/lib/ironic')
-rw-r--r--devstack/lib/ironic4
1 files changed, 2 insertions, 2 deletions
diff --git a/devstack/lib/ironic b/devstack/lib/ironic
index 17ba547f1..b81b9f38b 100644
--- a/devstack/lib/ironic
+++ b/devstack/lib/ironic
@@ -1793,7 +1793,7 @@ function configure_ironic_conductor {
-subj '/O=OpenStack/OU=DevStack Servers'
fi
- local pxe_params="nofb nomodeset console=${IRONIC_TTY_DEV}"
+ local pxe_params="nofb console=${IRONIC_TTY_DEV}"
pxe_params+=" systemd.journald.forward_to_console=yes"
if is_service_enabled tls-proxy; then
pxe_params+=" ipa-insecure=1"
@@ -1805,7 +1805,7 @@ function configure_ironic_conductor {
iniset $IRONIC_CONF_FILE pxe kernel_append_params "$pxe_params"
fi
- local kernel_append_params="nofb nomodeset console=${IRONIC_TTY_DEV}"
+ local kernel_append_params="nofb console=${IRONIC_TTY_DEV}"
kernel_append_params+=" systemd.journald.forward_to_console=yes"
# NOTE(dtantsur): avoid setting ipa-insecure for redfish, we have a way to