diff options
| author | Dmitry Tantsur <dtantsur@protonmail.com> | 2021-11-04 18:12:34 +0100 |
|---|---|---|
| committer | Dmitry Tantsur <dtantsur@protonmail.com> | 2021-11-09 18:00:35 +0100 |
| commit | 815705bc7deb877c2efaee750bbfaabcd3e635ff (patch) | |
| tree | c3796e00b1b0def971a2ca10a65a9632846e044c /ironic/tests/unit/drivers/modules/drac/test_inspect.py | |
| parent | 4bb7e537386811189b9f519b2f51588d5caef94c (diff) | |
| download | ironic-815705bc7deb877c2efaee750bbfaabcd3e635ff.tar.gz | |
Fix RedfishManagement.get_mac_addresses and related functions
RedfishManagement.get_mac_addresses has two problems:
* It returns a dict while the base class documents returning a list
* The dict's values are Redfish-specific values
This change fixes this function to return a list and significantly
simplifies the related create_ports_if_not_exists.
Change-Id: I329cabe04662d0d668d4c3e04ecede5b4fdec6c6
Diffstat (limited to 'ironic/tests/unit/drivers/modules/drac/test_inspect.py')
| -rw-r--r-- | ironic/tests/unit/drivers/modules/drac/test_inspect.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ironic/tests/unit/drivers/modules/drac/test_inspect.py b/ironic/tests/unit/drivers/modules/drac/test_inspect.py index 97dcf30f9..d12adba34 100644 --- a/ironic/tests/unit/drivers/modules/drac/test_inspect.py +++ b/ironic/tests/unit/drivers/modules/drac/test_inspect.py @@ -652,7 +652,7 @@ class DracRedfishInspectionTestCase(test_utils.BaseDracTest): return_value = task.driver.inspect.inspect_hardware(task) self.assertEqual(states.MANAGEABLE, return_value) mock_create_ports_if_not_exist.assert_called_once_with( - task, ethernet_interfaces_mac) + task, ['24:6E:96:70:49:00']) @mock.patch.object(redfish_utils, 'get_system', autospec=True) def test__get_mac_address_with_ethernet_interfaces(self, mock_get_system): |