diff options
| author | Dmitry Tantsur <dtantsur@protonmail.com> | 2019-06-14 13:56:42 +0200 |
|---|---|---|
| committer | Dmitry Tantsur <dtantsur@protonmail.com> | 2019-06-19 16:23:07 +0200 |
| commit | b2ee05a0b1af0cc6c4b52ab3f74d006012aee046 (patch) | |
| tree | 8dbbbffccbcf35adef8f87e38e967ed4e7a6ed49 /releasenotes/notes/api-none-cdb95e58b69a5c50.yaml | |
| parent | f52b386b4c4bec24c269ecd441c53668404085f6 (diff) | |
| download | ironic-b2ee05a0b1af0cc6c4b52ab3f74d006012aee046.tar.gz | |
Add check on get_endpoint returning None
Currently we expect keystoneauth to raise on missing endpoint, but in
many cases it returns None from get_endpoint instead. This causes two
kinds of problems:
* Raising Python exceptions in the code that is not ready to handle None
(e.g. get_ironic_api_url in deploy_utils).
* Passing endpoint_override=None to client constructors, thus effectively
ignoring provided adapter configuration options.
This change turns None into a proper error.
Change-Id: I8dad2e8ef5ff39167995dfe8266a48e80a29788b
Diffstat (limited to 'releasenotes/notes/api-none-cdb95e58b69a5c50.yaml')
| -rw-r--r-- | releasenotes/notes/api-none-cdb95e58b69a5c50.yaml | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/releasenotes/notes/api-none-cdb95e58b69a5c50.yaml b/releasenotes/notes/api-none-cdb95e58b69a5c50.yaml new file mode 100644 index 000000000..494429385 --- /dev/null +++ b/releasenotes/notes/api-none-cdb95e58b69a5c50.yaml @@ -0,0 +1,8 @@ +--- +fixes: + - | + Fixes a confusing ``AttributeError`` if an adapter returns ``None`` for + the bare metal API. + - | + Prevents the adapter configuration options from getting ignored if + a matching endpoint cannot be found. An error is now raised. |