1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import time
import mock
from oslo_config import cfg
from oslo_utils import timeutils
from oslo_utils import uuidutils
from ironic.common import boot_devices
from ironic.common import boot_modes
from ironic.common import exception
from ironic.common import network
from ironic.common import neutron
from ironic.common import nova
from ironic.common import states
from ironic.conductor import rpcapi
from ironic.conductor import task_manager
from ironic.conductor import utils as conductor_utils
from ironic.drivers import base as drivers_base
from ironic.drivers.modules import fake
from ironic import objects
from ironic.objects import fields as obj_fields
from ironic.tests import base as tests_base
from ironic.tests.unit.db import base as db_base
from ironic.tests.unit.db import utils as db_utils
from ironic.tests.unit.objects import utils as obj_utils
CONF = cfg.CONF
class TestPowerNoTimeout(drivers_base.PowerInterface):
"""Missing 'timeout' parameter for get_power_state & reboot"""
def get_properties(self):
return {}
def validate(self, task):
pass
def get_power_state(self, task):
return task.node.power_state
def set_power_state(self, task, power_state, timeout=None):
task.node.power_state = power_state
def reboot(self, task):
pass
class NodeSetBootDeviceTestCase(db_base.DbTestCase):
def setUp(self):
super(NodeSetBootDeviceTestCase, self).setUp()
self.node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid())
self.task = task_manager.TaskManager(self.context, self.node.uuid)
def test_node_set_boot_device_non_existent_device(self):
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_set_boot_device,
self.task,
device='fake')
@mock.patch.object(fake.FakeManagement, 'set_boot_device', autospec=True)
def test_node_set_boot_device_valid(self, mock_sbd):
conductor_utils.node_set_boot_device(self.task, device='pxe')
mock_sbd.assert_called_once_with(mock.ANY, self.task,
device='pxe', persistent=False)
@mock.patch.object(fake.FakeManagement, 'set_boot_device', autospec=True)
def test_node_set_boot_device_adopting(self, mock_sbd):
self.task.node.provision_state = states.ADOPTING
conductor_utils.node_set_boot_device(self.task, device='pxe')
self.assertFalse(mock_sbd.called)
class NodeGetBootModeTestCase(db_base.DbTestCase):
def setUp(self):
super(NodeGetBootModeTestCase, self).setUp()
self.node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid())
self.task = task_manager.TaskManager(self.context, self.node.uuid)
@mock.patch.object(fake.FakeManagement, 'get_boot_mode', autospec=True)
def test_node_get_boot_mode_valid(self, mock_gbm):
mock_gbm.return_value = 'bios'
boot_mode = conductor_utils.node_get_boot_mode(self.task)
self.assertEqual(boot_mode, 'bios')
mock_gbm.assert_called_once_with(mock.ANY, self.task)
@mock.patch.object(fake.FakeManagement, 'get_boot_mode', autospec=True)
def test_node_get_boot_mode_unsupported(self, mock_gbm):
mock_gbm.side_effect = exception.UnsupportedDriverExtension(
driver=self.task.node.driver, extension='get_boot_mode')
self.assertRaises(exception.UnsupportedDriverExtension,
conductor_utils.node_get_boot_mode, self.task)
class NodeSetBootModeTestCase(db_base.DbTestCase):
def setUp(self):
super(NodeSetBootModeTestCase, self).setUp()
self.node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid())
self.task = task_manager.TaskManager(self.context, self.node.uuid)
@mock.patch.object(fake.FakeManagement, 'get_supported_boot_modes',
autospec=True)
def test_node_set_boot_mode_non_existent_mode(self, mock_gsbm):
mock_gsbm.return_value = [boot_modes.LEGACY_BIOS]
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_set_boot_mode,
self.task,
mode='non-existing')
@mock.patch.object(fake.FakeManagement, 'set_boot_mode', autospec=True)
@mock.patch.object(fake.FakeManagement, 'get_supported_boot_modes',
autospec=True)
def test_node_set_boot_mode_valid(self, mock_gsbm, mock_sbm):
mock_gsbm.return_value = [boot_modes.LEGACY_BIOS]
conductor_utils.node_set_boot_mode(self.task,
mode=boot_modes.LEGACY_BIOS)
mock_sbm.assert_called_once_with(mock.ANY, self.task,
mode=boot_modes.LEGACY_BIOS)
@mock.patch.object(fake.FakeManagement, 'set_boot_mode', autospec=True)
@mock.patch.object(fake.FakeManagement, 'get_supported_boot_modes',
autospec=True)
def test_node_set_boot_mode_adopting(self, mock_gsbm, mock_sbm):
mock_gsbm.return_value = [boot_modes.LEGACY_BIOS]
old_provision_state = self.task.node.provision_state
self.task.node.provision_state = states.ADOPTING
try:
conductor_utils.node_set_boot_mode(self.task,
mode=boot_modes.LEGACY_BIOS)
finally:
self.task.node.provision_state = old_provision_state
self.assertFalse(mock_sbm.called)
class NodePowerActionTestCase(db_base.DbTestCase):
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_power_on(self, get_power_mock):
"""Test node_power_action to turn node power on."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_OFF)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
conductor_utils.node_power_action(task, states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch('ironic.objects.node.NodeSetPowerStateNotification')
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
@mock.patch.object(nova, 'power_update', autospec=True)
def test_node_power_action_power_on_notify(self, mock_power_update,
get_power_mock,
mock_notif):
"""Test node_power_action to power on node and send notification."""
self.config(notification_level='info')
self.config(host='my-host')
# Required for exception handling
mock_notif.__name__ = 'NodeSetPowerStateNotification'
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
instance_uuid=uuidutils.uuid,
power_state=states.POWER_OFF)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
conductor_utils.node_power_action(task, states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node.power_state)
self.assertIsNone(node.target_power_state)
self.assertIsNone(node.last_error)
# 2 notifications should be sent: 1 .start and 1 .end
self.assertEqual(2, mock_notif.call_count)
self.assertEqual(2, mock_notif.return_value.emit.call_count)
first_notif_args = mock_notif.call_args_list[0][1]
second_notif_args = mock_notif.call_args_list[1][1]
self.assertNotificationEqual(first_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.start',
obj_fields.NotificationLevel.INFO)
self.assertNotificationEqual(second_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.end',
obj_fields.NotificationLevel.INFO)
mock_power_update.assert_called_once_with(
task.context, node.instance_uuid, states.POWER_ON)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_power_off(self, get_power_mock):
"""Test node_power_action to turn node power off."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.POWER_OFF)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'reboot', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_power_reboot(self, get_power_mock, reboot_mock):
"""Test for reboot a node."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.REBOOT)
self.assertFalse(get_power_mock.called)
node.refresh()
reboot_mock.assert_called_once_with(mock.ANY, mock.ANY, timeout=None)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_invalid_state(self, get_power_mock):
"""Test for exception when changing to an invalid power state."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_power_action,
task,
"INVALID_POWER_STATE")
node.refresh()
self.assertFalse(get_power_mock.called)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNotNone(node['last_error'])
# last_error is cleared when a new transaction happens
conductor_utils.node_power_action(task, states.POWER_OFF)
node.refresh()
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch('ironic.objects.node.NodeSetPowerStateNotification')
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_invalid_state_notify(self, get_power_mock,
mock_notif):
"""Test for notification when changing to an invalid power state."""
self.config(notification_level='info')
self.config(host='my-host')
# Required for exception handling
mock_notif.__name__ = 'NodeSetPowerStateNotification'
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_power_action,
task,
"INVALID_POWER_STATE")
node.refresh()
self.assertFalse(get_power_mock.called)
self.assertEqual(states.POWER_ON, node.power_state)
self.assertIsNone(node.target_power_state)
self.assertIsNotNone(node.last_error)
# 2 notifications should be sent: 1 .start and 1 .error
self.assertEqual(2, mock_notif.call_count)
self.assertEqual(2, mock_notif.return_value.emit.call_count)
first_notif_args = mock_notif.call_args_list[0][1]
second_notif_args = mock_notif.call_args_list[1][1]
self.assertNotificationEqual(first_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.start',
obj_fields.NotificationLevel.INFO)
self.assertNotificationEqual(second_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.error',
obj_fields.NotificationLevel.ERROR)
def test_node_power_action_already_being_processed(self):
"""Test node power action after aborted power action.
The target_power_state is expected to be None so it isn't
checked in the code. This is what happens if it is not None.
(Eg, if a conductor had died during a previous power-off
attempt and left the target_power_state set to states.POWER_OFF,
and the user is attempting to power-off again.)
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON,
target_power_state=states.POWER_OFF)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.POWER_OFF)
node.refresh()
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertEqual(states.NOSTATE, node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(conductor_utils, 'LOG', autospec=True)
@mock.patch.object(fake.FakePower, 'set_power_state', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_in_same_state(self, get_power_mock,
set_power_mock, log_mock):
"""Test setting node state to its present state.
Test that we don't try to set the power state if the requested
state is the same as the current state.
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
last_error='anything but None',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertFalse(set_power_mock.called,
"set_power_state unexpectedly called")
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
log_mock.warning.assert_called_once_with(
u"Not going to change node %(node)s power state because "
u"current state = requested state = '%(state)s'.",
{'state': states.POWER_ON, 'node': node.uuid})
@mock.patch.object(fake.FakePower, 'set_power_state', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_in_same_state_db_not_in_sync(self,
get_power_mock,
set_power_mock):
"""Test setting node state to its present state if DB is out of sync.
Under rare conditions (see bug #1403106) database might contain stale
information, make sure we fix it.
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
last_error='anything but None',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
conductor_utils.node_power_action(task, states.POWER_OFF)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertFalse(set_power_mock.called,
"set_power_state unexpectedly called")
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_failed_getting_state(self, get_power_mock):
"""Test for exception when we can't get the current power state."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.side_effect = (
exception.InvalidParameterValue('failed getting power state'))
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_power_action,
task,
states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNotNone(node['last_error'])
@mock.patch('ironic.objects.node.NodeSetPowerStateNotification')
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_failed_getting_state_notify(self,
get_power_mock,
mock_notif):
"""Test for notification when we can't get the current power state."""
self.config(notification_level='info')
self.config(host='my-host')
# Required for exception handling
mock_notif.__name__ = 'NodeSetPowerStateNotification'
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.side_effect = (
exception.InvalidParameterValue('failed getting power state'))
self.assertRaises(exception.InvalidParameterValue,
conductor_utils.node_power_action,
task,
states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node.power_state)
self.assertIsNone(node.target_power_state)
self.assertIsNotNone(node.last_error)
# 2 notifications should be sent: 1 .start and 1 .error
self.assertEqual(2, mock_notif.call_count)
self.assertEqual(2, mock_notif.return_value.emit.call_count)
first_notif_args = mock_notif.call_args_list[0][1]
second_notif_args = mock_notif.call_args_list[1][1]
self.assertNotificationEqual(first_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.start',
obj_fields.NotificationLevel.INFO)
self.assertNotificationEqual(second_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.error',
obj_fields.NotificationLevel.ERROR)
@mock.patch.object(fake.FakePower, 'set_power_state', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_set_power_failure(self, get_power_mock,
set_power_mock):
"""Test if an exception is thrown when the set_power call fails."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_OFF)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
set_power_mock.side_effect = exception.IronicException()
self.assertRaises(
exception.IronicException,
conductor_utils.node_power_action,
task,
states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
set_power_mock.assert_called_once_with(
mock.ANY, mock.ANY, states.POWER_ON, timeout=None)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNotNone(node['last_error'])
@mock.patch('ironic.objects.node.NodeSetPowerStateNotification')
@mock.patch.object(fake.FakePower, 'set_power_state', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_set_power_failure_notify(self, get_power_mock,
set_power_mock,
mock_notif):
"""Test if a notification is sent when the set_power call fails."""
self.config(notification_level='info')
self.config(host='my-host')
# Required for exception handling
mock_notif.__name__ = 'NodeSetPowerStateNotification'
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_OFF)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
set_power_mock.side_effect = exception.IronicException()
self.assertRaises(
exception.IronicException,
conductor_utils.node_power_action,
task,
states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
set_power_mock.assert_called_once_with(
mock.ANY, mock.ANY, states.POWER_ON, timeout=None)
self.assertEqual(states.POWER_OFF, node.power_state)
self.assertIsNone(node.target_power_state)
self.assertIsNotNone(node.last_error)
# 2 notifications should be sent: 1 .start and 1 .error
self.assertEqual(2, mock_notif.call_count)
self.assertEqual(2, mock_notif.return_value.emit.call_count)
first_notif_args = mock_notif.call_args_list[0][1]
second_notif_args = mock_notif.call_args_list[1][1]
self.assertNotificationEqual(first_notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.start',
obj_fields.NotificationLevel.INFO)
self.assertNotificationEqual(
second_notif_args, 'ironic-conductor', CONF.host,
'baremetal.node.power_set.error',
obj_fields.NotificationLevel.ERROR)
@mock.patch.object(fake.FakeStorage, 'attach_volumes', autospec=True)
def test_node_power_action_power_on_storage_attach(self, attach_mock):
"""Test node_power_action to turn node power on and attach storage."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_OFF,
storage_interface="fake",
provision_state=states.ACTIVE)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.POWER_ON)
node.refresh()
attach_mock.assert_called_once_with(mock.ANY, task)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakeStorage, 'attach_volumes', autospec=True)
def test_node_power_action_reboot_storage_attach(self, attach_mock):
"""Test node_power_action to reboot the node and attach storage."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON,
storage_interface="fake",
provision_state=states.ACTIVE)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.REBOOT)
node.refresh()
attach_mock.assert_called_once_with(mock.ANY, task)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakeStorage, 'detach_volumes', autospec=True)
def test_node_power_action_power_off_storage_detach(self, detach_mock):
"""Test node_power_action to turn node power off and detach storage."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON,
storage_interface="fake",
provision_state=states.ACTIVE)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.POWER_OFF)
node.refresh()
detach_mock.assert_called_once_with(mock.ANY, task)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
def test__calculate_target_state(self):
for new_state in (states.POWER_ON, states.REBOOT, states.SOFT_REBOOT):
self.assertEqual(
states.POWER_ON,
conductor_utils._calculate_target_state(new_state))
for new_state in (states.POWER_OFF, states.SOFT_POWER_OFF):
self.assertEqual(
states.POWER_OFF,
conductor_utils._calculate_target_state(new_state))
self.assertIsNone(conductor_utils._calculate_target_state('bad_state'))
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test__can_skip_state_change_different_state(self, get_power_mock):
"""Test setting node state to different state.
Test that we should change state if requested state is different from
current state.
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
last_error='anything but None',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
result = conductor_utils._can_skip_state_change(
task, states.POWER_OFF)
self.assertFalse(result)
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
@mock.patch.object(conductor_utils, 'LOG', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test__can_skip_state_change_same_state(self, get_power_mock, mock_log):
"""Test setting node state to its present state.
Test that we don't try to set the power state if the requested
state is the same as the current state.
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
last_error='anything but None',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
result = conductor_utils._can_skip_state_change(
task, states.POWER_ON)
self.assertTrue(result)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertEqual(states.NOSTATE, node['target_power_state'])
self.assertIsNone(node['last_error'])
mock_log.warning.assert_called_once_with(
u"Not going to change node %(node)s power state because "
u"current state = requested state = '%(state)s'.",
{'state': states.POWER_ON, 'node': node.uuid})
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test__can_skip_state_change_db_not_in_sync(self, get_power_mock):
"""Test setting node state to its present state if DB is out of sync.
Under rare conditions (see bug #1403106) database might contain stale
information, make sure we fix it.
"""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
last_error='anything but None',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_OFF
result = conductor_utils._can_skip_state_change(task, states.POWER_OFF)
self.assertTrue(result)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertEqual(states.NOSTATE, node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch('ironic.objects.node.NodeSetPowerStateNotification')
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test__can_skip_state_change_failed_getting_state_notify(
self, get_power_mock, mock_notif):
"""Test for notification & exception when can't get power state.
Test to make sure we generate a notification and also that an exception
is raised when we can't get the current power state.
"""
self.config(notification_level='info')
self.config(host='my-host')
# Required for exception handling
mock_notif.__name__ = 'NodeSetPowerStateNotification'
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.side_effect = (
exception.InvalidParameterValue('failed getting power state'))
self.assertRaises(exception.InvalidParameterValue,
conductor_utils._can_skip_state_change,
task,
states.POWER_ON)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_ON, node.power_state)
self.assertEqual(states.NOSTATE, node['target_power_state'])
self.assertIsNotNone(node.last_error)
# 1 notification should be sent for the error
self.assertEqual(1, mock_notif.call_count)
self.assertEqual(1, mock_notif.return_value.emit.call_count)
notif_args = mock_notif.call_args_list[0][1]
self.assertNotificationEqual(notif_args,
'ironic-conductor', CONF.host,
'baremetal.node.power_set.error',
obj_fields.NotificationLevel.ERROR)
def test_node_power_action_reboot_no_timeout(self):
"""Test node reboot using Power Interface with no timeout arg."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
console_interface='no-console',
inspect_interface='no-inspect',
raid_interface='no-raid',
rescue_interface='no-rescue',
vendor_interface='no-vendor',
bios_interface='no-bios',
power_state=states.POWER_ON)
self.config(enabled_boot_interfaces=['fake'])
self.config(enabled_deploy_interfaces=['fake'])
self.config(enabled_management_interfaces=['fake'])
self.config(enabled_power_interfaces=['fake'])
task = task_manager.TaskManager(self.context, node.uuid)
task.driver.power = TestPowerNoTimeout()
self.assertRaisesRegex(TypeError,
'unexpected keyword argument',
conductor_utils.node_power_action,
task, states.REBOOT)
node.refresh()
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertTrue('unexpected keyword argument' in node['last_error'])
class NodeSoftPowerActionTestCase(db_base.DbTestCase):
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_power_soft_reboot(self, get_power_mock):
"""Test for soft reboot a node."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.SOFT_REBOOT)
node.refresh()
self.assertFalse(get_power_mock.called)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_power_soft_reboot_timeout(self, get_power_mock):
"""Test for soft reboot a node."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.SOFT_REBOOT,
timeout=2)
node.refresh()
self.assertFalse(get_power_mock.called)
self.assertEqual(states.POWER_ON, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_soft_power_off(self, get_power_mock):
"""Test node_power_action to turn node soft power off."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.SOFT_POWER_OFF)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
def test_node_power_action_soft_power_off_timeout(self, get_power_mock):
"""Test node_power_action to turn node soft power off."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON)
task = task_manager.TaskManager(self.context, node.uuid)
get_power_mock.return_value = states.POWER_ON
conductor_utils.node_power_action(task, states.SOFT_POWER_OFF,
timeout=2)
node.refresh()
get_power_mock.assert_called_once_with(mock.ANY, mock.ANY)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
@mock.patch.object(fake.FakeStorage, 'detach_volumes', autospec=True)
def test_node_power_action_soft_power_off_storage_detach(self,
detach_mock):
"""Test node_power_action to soft power off node and detach storage."""
node = obj_utils.create_test_node(self.context,
uuid=uuidutils.generate_uuid(),
driver='fake-hardware',
power_state=states.POWER_ON,
storage_interface="fake",
provision_state=states.ACTIVE)
task = task_manager.TaskManager(self.context, node.uuid)
conductor_utils.node_power_action(task, states.SOFT_POWER_OFF)
node.refresh()
detach_mock.assert_called_once_with(mock.ANY, task)
self.assertEqual(states.POWER_OFF, node['power_state'])
self.assertIsNone(node['target_power_state'])
self.assertIsNone(node['last_error'])
class DeployingErrorHandlerTestCase(tests_base.TestCase):
def setUp(self):
super(DeployingErrorHandlerTestCase, self).setUp()
self.task = mock.Mock(spec=task_manager.TaskManager)
self.task.context = self.context
self.task.driver = mock.Mock(spec_set=['deploy'])
self.task.shared = False
self.task.node = mock.Mock(spec_set=objects.Node)
self.node = self.task.node
self.node.provision_state = states.DEPLOYING
self.node.last_error = None
self.node.deploy_step = None
self.node.driver_internal_info = {}
self.logmsg = "log message"
self.errmsg = "err message"
@mock.patch.object(conductor_utils, 'deploying_error_handler',
autospec=True)
def test_cleanup_after_timeout(self, mock_handler):
conductor_utils.cleanup_after_timeout(self.task)
mock_handler.assert_called_once_with(self.task, mock.ANY, mock.ANY)
def test_cleanup_after_timeout_shared_lock(self):
self.task.shared = True
self.assertRaises(exception.ExclusiveLockRequired,
conductor_utils.cleanup_after_timeout,
self.task)
def test_deploying_error_handler(self):
info = self.node.driver_internal_info
info['deploy_step_index'] = 2
info['deployment_reboot'] = True
info['deployment_polling'] = True
info['skip_current_deploy_step'] = True
info['agent_url'] = 'url'
conductor_utils.deploying_error_handler(self.task, self.logmsg,
self.errmsg)
self.assertEqual([mock.call()] * 2, self.node.save.call_args_list)
self.task.driver.deploy.clean_up.assert_called_once_with(self.task)
self.assertEqual(self.errmsg, self.node.last_error)
self.assertEqual({}, self.node.deploy_step)
self.assertNotIn('deploy_step_index', self.node.driver_internal_info)
self.assertNotIn('deployment_reboot', self.node.driver_internal_info)
self.assertNotIn('deployment_polling', self.node.driver_internal_info)
self.assertNotIn('skip_current_deploy_step',
self.node.driver_internal_info)
self.assertNotIn('agent_url', self.node.driver_internal_info)
self.task.process_event.assert_called_once_with('fail')
def _test_deploying_error_handler_cleanup(self, exc, expected_str):
clean_up_mock = self.task.driver.deploy.clean_up
clean_up_mock.side_effect = exc
conductor_utils.deploying_error_handler(self.task, self.logmsg,
self.errmsg)
self.task.driver.deploy.clean_up.assert_called_once_with(self.task)
self.assertEqual([mock.call()] * 2, self.node.save.call_args_list)
self.assertIn(expected_str, self.node.last_error)
self.assertEqual({}, self.node.deploy_step)
self.assertNotIn('deploy_step_index', self.node.driver_internal_info)
self.task.process_event.assert_called_once_with('fail')
def test_deploying_error_handler_cleanup_ironic_exception(self):
self._test_deploying_error_handler_cleanup(
exception.IronicException('moocow'), 'moocow')
def test_deploying_error_handler_cleanup_random_exception(self):
self._test_deploying_error_handler_cleanup(
Exception('moocow'), 'unhandled exception')
def test_deploying_error_handler_no_cleanup(self):
conductor_utils.deploying_error_handler(
self.task, self.logmsg, self.errmsg, clean_up=False)
self.assertFalse(self.task.driver.deploy.clean_up.called)
self.assertEqual([mock.call()] * 2, self.node.save.call_args_list)
self.assertEqual(self.errmsg, self.node.last_error)
self.assertEqual({}, self.node.deploy_step)
self.assertNotIn('deploy_step_index', self.node.driver_internal_info)
self.task.process_event.assert_called_once_with('fail')
def test_deploying_error_handler_not_deploy(self):
# Not in a deploy state
self.node.provision_state = states.AVAILABLE
self.node.driver_internal_info['deploy_step_index'] = 2
conductor_utils.deploying_error_handler(
self.task, self.logmsg, self.errmsg, clean_up=False)
self.assertEqual([mock.call()] * 2, self.node.save.call_args_list)
self.assertEqual(self.errmsg, self.node.last_error)
self.assertIsNone(self.node.deploy_step)
self.assertIn('deploy_step_index', self.node.driver_internal_info)
self.task.process_event.assert_called_once_with('fail')
class ErrorHandlersTestCase(tests_base.TestCase):
def setUp(self):
super(ErrorHandlersTestCase, self).setUp()
self.task = mock.Mock(spec=task_manager.TaskManager)
self.task.driver = mock.Mock(spec_set=['deploy', 'network', 'rescue'])
self.task.node = mock.Mock(spec_set=objects.Node)
self.task.shared = False
self.node = self.task.node
# NOTE(mariojv) Some of the test cases that use the task below require
# strict typing of the node power state fields and would fail if passed
# a Mock object in constructors. A task context is also required for
# notifications.
self.node.configure_mock(power_state=states.POWER_OFF,
target_power_state=states.POWER_ON,
maintenance=False, maintenance_reason=None)
self.task.context = self.context
@mock.patch.object(conductor_utils, 'LOG')
def test_provision_error_handler_no_worker(self, log_mock):
exc = exception.NoFreeConductorWorker()
conductor_utils.provisioning_error_handler(exc, self.node, 'state-one',
'state-two')
self.node.save.assert_called_once_with()
self.assertEqual('state-one', self.node.provision_state)
self.assertEqual('state-two', self.node.target_provision_state)
self.assertIn('No free conductor workers', self.node.last_error)
self.assertTrue(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG')
def test_provision_error_handler_other_error(self, log_mock):
exc = Exception('foo')
conductor_utils.provisioning_error_handler(exc, self.node, 'state-one',
'state-two')
self.assertFalse(self.node.save.called)
self.assertFalse(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'cleaning_error_handler')
def test_cleanup_cleanwait_timeout_handler_call(self, mock_error_handler):
self.node.clean_step = {}
conductor_utils.cleanup_cleanwait_timeout(self.task)
mock_error_handler.assert_called_once_with(
self.task,
msg="Timeout reached while cleaning the node. Please "
"check if the ramdisk responsible for the cleaning is "
"running on the node. Failed on step {}.",
set_fail_state=False)
def test_cleanup_cleanwait_timeout(self):
self.node.provision_state = states.CLEANFAIL
target = 'baz'
self.node.target_provision_state = target
self.node.driver_internal_info = {}
self.node.clean_step = {'key': 'val'}
clean_error = ("Timeout reached while cleaning the node. Please "
"check if the ramdisk responsible for the cleaning is "
"running on the node. Failed on step {'key': 'val'}.")
self.node.driver_internal_info = {
'cleaning_reboot': True,
'clean_step_index': 0}
conductor_utils.cleanup_cleanwait_timeout(self.task)
self.assertEqual({}, self.node.clean_step)
self.assertNotIn('clean_step_index', self.node.driver_internal_info)
self.assertFalse(self.task.process_event.called)
self.assertTrue(self.node.maintenance)
self.assertEqual(clean_error, self.node.maintenance_reason)
self.assertEqual('clean failure', self.node.fault)
def _test_cleaning_error_handler(self, prov_state=states.CLEANING):
self.node.provision_state = prov_state
target = 'baz'
self.node.target_provision_state = target
self.node.clean_step = {'key': 'val'}
self.node.driver_internal_info = {
'cleaning_reboot': True,
'cleaning_polling': True,
'skip_current_clean_step': True,
'clean_step_index': 0,
'agent_url': 'url'}
msg = 'error bar'
conductor_utils.cleaning_error_handler(self.task, msg)
self.node.save.assert_called_once_with()
self.assertEqual({}, self.node.clean_step)
self.assertNotIn('clean_step_index', self.node.driver_internal_info)
self.assertNotIn('cleaning_reboot', self.node.driver_internal_info)
self.assertNotIn('cleaning_polling', self.node.driver_internal_info)
self.assertNotIn('skip_current_clean_step',
self.node.driver_internal_info)
self.assertEqual(msg, self.node.last_error)
self.assertTrue(self.node.maintenance)
self.assertEqual(msg, self.node.maintenance_reason)
self.assertEqual('clean failure', self.node.fault)
driver = self.task.driver.deploy
driver.tear_down_cleaning.assert_called_once_with(self.task)
if prov_state == states.CLEANFAIL:
self.assertFalse(self.task.process_event.called)
else:
self.task.process_event.assert_called_once_with('fail',
target_state=None)
self.assertNotIn('agent_url', self.node.driver_internal_info)
def test_cleaning_error_handler(self):
self._test_cleaning_error_handler()
def test_cleaning_error_handler_cleanwait(self):
self._test_cleaning_error_handler(prov_state=states.CLEANWAIT)
def test_cleaning_error_handler_cleanfail(self):
self._test_cleaning_error_handler(prov_state=states.CLEANFAIL)
def test_cleaning_error_handler_manual(self):
target = states.MANAGEABLE
self.node.target_provision_state = target
conductor_utils.cleaning_error_handler(self.task, 'foo')
self.task.process_event.assert_called_once_with('fail',
target_state=target)
def test_cleaning_error_handler_no_teardown(self):
target = states.MANAGEABLE
self.node.target_provision_state = target
conductor_utils.cleaning_error_handler(self.task, 'foo',
tear_down_cleaning=False)
self.assertFalse(self.task.driver.deploy.tear_down_cleaning.called)
self.task.process_event.assert_called_once_with('fail',
target_state=target)
def test_cleaning_error_handler_no_fail(self):
conductor_utils.cleaning_error_handler(self.task, 'foo',
set_fail_state=False)
driver = self.task.driver.deploy
driver.tear_down_cleaning.assert_called_once_with(self.task)
self.assertFalse(self.task.process_event.called)
@mock.patch.object(conductor_utils, 'LOG')
def test_cleaning_error_handler_tear_down_error(self, log_mock):
def _side_effect(task):
# simulate overwriting last error by another operation (e.g. power)
task.node.last_error = None
raise Exception('bar')
driver = self.task.driver.deploy
msg = 'foo'
driver.tear_down_cleaning.side_effect = _side_effect
conductor_utils.cleaning_error_handler(self.task, msg)
self.assertTrue(log_mock.exception.called)
self.assertIn(msg, self.node.last_error)
self.assertIn(msg, self.node.maintenance_reason)
self.assertEqual('clean failure', self.node.fault)
def test_abort_on_conductor_take_over_cleaning(self):
self.node.provision_state = states.CLEANFAIL
conductor_utils.abort_on_conductor_take_over(self.task)
self.assertTrue(self.node.maintenance)
self.assertIn('take over', self.node.maintenance_reason)
self.assertIn('take over', self.node.last_error)
self.assertEqual('clean failure', self.node.fault)
self.task.driver.deploy.tear_down_cleaning.assert_called_once_with(
self.task)
self.node.save.assert_called_once_with()
def test_abort_on_conductor_take_over_deploying(self):
self.node.provision_state = states.DEPLOYFAIL
conductor_utils.abort_on_conductor_take_over(self.task)
self.assertFalse(self.node.maintenance)
self.assertIn('take over', self.node.last_error)
self.node.save.assert_called_once_with()
@mock.patch.object(conductor_utils, 'LOG')
def test_spawn_cleaning_error_handler_no_worker(self, log_mock):
exc = exception.NoFreeConductorWorker()
conductor_utils.spawn_cleaning_error_handler(exc, self.node)
self.node.save.assert_called_once_with()
self.assertIn('No free conductor workers', self.node.last_error)
self.assertTrue(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG')
def test_spawn_cleaning_error_handler_other_error(self, log_mock):
exc = Exception('foo')
conductor_utils.spawn_cleaning_error_handler(exc, self.node)
self.assertFalse(self.node.save.called)
self.assertFalse(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG', autospec=True)
def test_spawn_deploying_error_handler_no_worker(self, log_mock):
exc = exception.NoFreeConductorWorker()
conductor_utils.spawn_deploying_error_handler(exc, self.node)
self.node.save.assert_called_once_with()
self.assertIn('No free conductor workers', self.node.last_error)
self.assertTrue(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG', autospec=True)
def test_spawn_deploying_error_handler_other_error(self, log_mock):
exc = Exception('foo')
conductor_utils.spawn_deploying_error_handler(exc, self.node)
self.assertFalse(self.node.save.called)
self.assertFalse(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG')
def test_spawn_rescue_error_handler_no_worker(self, log_mock):
exc = exception.NoFreeConductorWorker()
self.node.instance_info = {'rescue_password': 'pass',
'hashed_rescue_password': '12'}
conductor_utils.spawn_rescue_error_handler(exc, self.node)
self.node.save.assert_called_once_with()
self.assertIn('No free conductor workers', self.node.last_error)
self.assertTrue(log_mock.warning.called)
self.assertNotIn('rescue_password', self.node.instance_info)
self.assertNotIn('hashed_rescue_password', self.node.instance_info)
@mock.patch.object(conductor_utils, 'LOG')
def test_spawn_rescue_error_handler_other_error(self, log_mock):
exc = Exception('foo')
self.node.instance_info = {'rescue_password': 'pass',
'hashed_rescue_password': '12'}
conductor_utils.spawn_rescue_error_handler(exc, self.node)
self.assertFalse(self.node.save.called)
self.assertFalse(log_mock.warning.called)
self.assertIn('rescue_password', self.node.instance_info)
@mock.patch.object(conductor_utils, 'LOG')
def test_power_state_error_handler_no_worker(self, log_mock):
exc = exception.NoFreeConductorWorker()
conductor_utils.power_state_error_handler(exc, self.node, 'newstate')
self.node.save.assert_called_once_with()
self.assertEqual('newstate', self.node.power_state)
self.assertEqual(states.NOSTATE, self.node.target_power_state)
self.assertIn('No free conductor workers', self.node.last_error)
self.assertTrue(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG')
def test_power_state_error_handler_other_error(self, log_mock):
exc = Exception('foo')
conductor_utils.power_state_error_handler(exc, self.node, 'foo')
self.assertFalse(self.node.save.called)
self.assertFalse(log_mock.warning.called)
@mock.patch.object(conductor_utils, 'LOG')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_cleanup_rescuewait_timeout(self, node_power_mock, log_mock):
conductor_utils.cleanup_rescuewait_timeout(self.task)
self.assertTrue(log_mock.error.called)
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
self.assertIn('Timeout reached', self.node.last_error)
self.node.save.assert_called_once_with()
@mock.patch.object(conductor_utils, 'LOG')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_cleanup_rescuewait_timeout_known_exc(
self, node_power_mock, log_mock):
clean_up_mock = self.task.driver.rescue.clean_up
clean_up_mock.side_effect = exception.IronicException('moocow')
conductor_utils.cleanup_rescuewait_timeout(self.task)
self.assertEqual(2, log_mock.error.call_count)
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
self.assertIn('moocow', self.node.last_error)
self.node.save.assert_called_once_with()
@mock.patch.object(conductor_utils, 'LOG')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_cleanup_rescuewait_timeout_unknown_exc(
self, node_power_mock, log_mock):
clean_up_mock = self.task.driver.rescue.clean_up
clean_up_mock.side_effect = Exception('moocow')
conductor_utils.cleanup_rescuewait_timeout(self.task)
self.assertTrue(log_mock.error.called)
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
self.assertIn('Rescue failed', self.node.last_error)
self.node.save.assert_called_once_with()
self.assertTrue(log_mock.exception.called)
@mock.patch.object(conductor_utils, 'node_power_action')
def _test_rescuing_error_handler(self, node_power_mock,
set_state=True):
self.node.provision_state = states.RESCUEWAIT
self.node.driver_internal_info.update({'agent_url': 'url'})
conductor_utils.rescuing_error_handler(self.task,
'some exception for node',
set_fail_state=set_state)
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
self.node.save.assert_called_once_with()
self.assertNotIn('agent_url', self.node.driver_internal_info)
if set_state:
self.assertTrue(self.task.process_event.called)
else:
self.assertFalse(self.task.process_event.called)
def test_rescuing_error_handler(self):
self._test_rescuing_error_handler()
def test_rescuing_error_handler_set_failed_state_false(self):
self._test_rescuing_error_handler(set_state=False)
@mock.patch.object(conductor_utils.LOG, 'error')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_rescuing_error_handler_ironic_exc(self, node_power_mock,
log_mock):
self.node.provision_state = states.RESCUEWAIT
expected_exc = exception.IronicException('moocow')
clean_up_mock = self.task.driver.rescue.clean_up
clean_up_mock.side_effect = expected_exc
conductor_utils.rescuing_error_handler(self.task,
'some exception for node')
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
log_mock.assert_called_once_with('Rescue operation was unsuccessful, '
'clean up failed for node %(node)s: '
'%(error)s',
{'node': self.node.uuid,
'error': expected_exc})
self.node.save.assert_called_once_with()
@mock.patch.object(conductor_utils.LOG, 'exception')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_rescuing_error_handler_other_exc(self, node_power_mock,
log_mock):
self.node.provision_state = states.RESCUEWAIT
expected_exc = RuntimeError()
clean_up_mock = self.task.driver.rescue.clean_up
clean_up_mock.side_effect = expected_exc
conductor_utils.rescuing_error_handler(self.task,
'some exception for node')
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
log_mock.assert_called_once_with('Rescue failed for node '
'%(node)s, an exception was '
'encountered while aborting.',
{'node': self.node.uuid})
self.node.save.assert_called_once_with()
@mock.patch.object(conductor_utils.LOG, 'error')
@mock.patch.object(conductor_utils, 'node_power_action')
def test_rescuing_error_handler_bad_state(self, node_power_mock,
log_mock):
self.node.provision_state = states.RESCUE
self.task.process_event.side_effect = exception.InvalidState
expected_exc = exception.IronicException('moocow')
clean_up_mock = self.task.driver.rescue.clean_up
clean_up_mock.side_effect = expected_exc
conductor_utils.rescuing_error_handler(self.task,
'some exception for node')
node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)
self.task.driver.rescue.clean_up.assert_called_once_with(self.task)
self.task.process_event.assert_called_once_with('fail')
log_calls = [mock.call('Rescue operation was unsuccessful, clean up '
'failed for node %(node)s: %(error)s',
{'node': self.node.uuid,
'error': expected_exc}),
mock.call('Internal error. Node %(node)s in provision '
'state "%(state)s" could not transition to a '
'failed state.',
{'node': self.node.uuid,
'state': self.node.provision_state})]
log_mock.assert_has_calls(log_calls)
self.node.save.assert_called_once_with()
class ValidatePortPhysnetTestCase(db_base.DbTestCase):
def setUp(self):
super(ValidatePortPhysnetTestCase, self).setUp()
self.node = obj_utils.create_test_node(self.context,
driver='fake-hardware')
@mock.patch.object(objects.Port, 'obj_what_changed')
def test_validate_port_physnet_no_portgroup_create(self, mock_owc):
port = obj_utils.get_test_port(self.context, node_id=self.node.id)
# NOTE(mgoddard): The port object passed to the conductor will not have
# a portgroup_id attribute in this case.
del port.portgroup_id
with task_manager.acquire(self.context, self.node.uuid) as task:
conductor_utils.validate_port_physnet(task, port)
# Verify the early return in the non-portgroup case.
self.assertFalse(mock_owc.called)
@mock.patch.object(network, 'get_ports_by_portgroup_id')
def test_validate_port_physnet_no_portgroup_update(self, mock_gpbpi):
port = obj_utils.create_test_port(self.context, node_id=self.node.id)
port.extra = {'foo': 'bar'}
with task_manager.acquire(self.context, self.node.uuid) as task:
conductor_utils.validate_port_physnet(task, port)
# Verify the early return in the no portgroup update case.
self.assertFalse(mock_gpbpi.called)
def test_validate_port_physnet_inconsistent_physnets(self):
# NOTE(mgoddard): This *shouldn't* happen, but let's make sure we can
# handle it.
portgroup = obj_utils.create_test_portgroup(self.context,
node_id=self.node.id)
obj_utils.create_test_port(self.context, node_id=self.node.id,
portgroup_id=portgroup.id,
address='00:11:22:33:44:55',
physical_network='physnet1',
uuid=uuidutils.generate_uuid())
obj_utils.create_test_port(self.context, node_id=self.node.id,
portgroup_id=portgroup.id,
address='00:11:22:33:44:56',
physical_network='physnet2',
uuid=uuidutils.generate_uuid())
port = obj_utils.get_test_port(self.context, node_id=self.node.id,
portgroup_id=portgroup.id,
address='00:11:22:33:44:57',
physical_network='physnet2',
uuid=uuidutils.generate_uuid())
with task_manager.acquire(self.context, self.node.uuid) as task:
self.assertRaises(exception.PortgroupPhysnetInconsistent,
conductor_utils.validate_port_physnet,
task, port)
def test_validate_port_physnet_inconsistent_physnets_fix(self):
# NOTE(mgoddard): This *shouldn't* happen, but let's make sure that if
# we do get into this state that it is possible to resolve by setting
# the physical_network correctly.
portgroup = obj_utils.create_test_portgroup(self.context,
node_id=self.node.id)
obj_utils.create_test_port(self.context, node_id=self.node.id,
portgroup_id=portgroup.id,
address='00:11:22:33:44:55',
physical_network='physnet1',
uuid=uuidutils.generate_uuid())
port = obj_utils.create_test_port(self.context, node_id=self.node.id,
portgroup_id=portgroup.id,
address='00:11:22:33:44:56',
physical_network='physnet2',
uuid=uuidutils.generate_uuid())
port.physical_network = 'physnet1'
with task_manager.acquire(self.context, self.node.uuid) as task:
conductor_utils.validate_port_physnet(task, port)
def _test_validate_port_physnet(self,
num_current_ports,
current_physnet,
new_physnet,
operation,
valid=True):
"""Helper method for testing validate_port_physnet.
:param num_current_ports: Number of existing ports in the portgroup.
:param current_physnet: Physical network of existing ports in the
portgroup.
:param new_physnet: Physical network to set on the port that is being
created or updated.
:param operation: The operation to perform. One of 'create', 'update',
or 'update_add'. 'create' creates a new port and adds
it to the portgroup. 'update' updates one of the
existing ports. 'update_add' updates a port and adds
it to the portgroup.
:param valid: Whether the operation is expected to succeed.
"""
# Prepare existing resources - a node, and a portgroup with optional
# existing ports.
port = None
portgroup = obj_utils.create_test_portgroup(self.context,
node_id=self.node.id)
macs = ("00:11:22:33:44:%02x" % index
for index in range(num_current_ports + 1))
for _ in range(num_current_ports):
# NOTE: When operation == 'update' we update the last port in the
# portgroup.
port = obj_utils.create_test_port(
self.context, node_id=self.node.id, portgroup_id=portgroup.id,
address=next(macs), physical_network=current_physnet,
uuid=uuidutils.generate_uuid())
# Prepare the port on which we are performing the operation.
if operation == 'create':
# NOTE(mgoddard): We use db_utils here rather than obj_utils as it
# allows us to create a Port without a physical_network field, more
# closely matching what happens during creation of a port when a
# physical_network is not specified.
port = db_utils.get_test_port(
node_id=self.node.id, portgroup_id=portgroup.id,
address=next(macs), uuid=uuidutils.generate_uuid(),
physical_network=new_physnet)
if new_physnet is None:
del port["physical_network"]
port = objects.Port(self.context, **port)
elif operation == 'update_add':
port = obj_utils.create_test_port(
self.context, node_id=self.node.id, portgroup_id=None,
address=next(macs), physical_network=current_physnet,
uuid=uuidutils.generate_uuid())
port.portgroup_id = portgroup.id
if operation != 'create' and new_physnet != current_physnet:
port.physical_network = new_physnet
# Perform the validation.
with task_manager.acquire(self.context, self.node.uuid) as task:
if valid:
conductor_utils.validate_port_physnet(task, port)
else:
self.assertRaises(exception.Conflict,
conductor_utils.validate_port_physnet,
task, port)
def _test_validate_port_physnet_create(self, **kwargs):
self._test_validate_port_physnet(operation='create', **kwargs)
def _test_validate_port_physnet_update(self, **kwargs):
self._test_validate_port_physnet(operation='update', **kwargs)
def _test_validate_port_physnet_update_add(self, **kwargs):
self._test_validate_port_physnet(operation='update_add', **kwargs)
# Empty portgroup
def test_validate_port_physnet_empty_portgroup_create_1(self):
self._test_validate_port_physnet_create(
num_current_ports=0,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_empty_portgroup_create_2(self):
self._test_validate_port_physnet_create(
num_current_ports=0,
current_physnet=None,
new_physnet='physnet1')
def test_validate_port_physnet_empty_portgroup_update_1(self):
self._test_validate_port_physnet_update_add(
num_current_ports=0,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_empty_portgroup_update_2(self):
self._test_validate_port_physnet_update_add(
num_current_ports=0,
current_physnet=None,
new_physnet='physnet1')
# 1-port portgroup, no physnet.
def test_validate_port_physnet_1_port_portgroup_no_physnet_create_1(self):
self._test_validate_port_physnet_create(
num_current_ports=1,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_1_port_portgroup_no_physnet_create_2(self):
self._test_validate_port_physnet_create(
num_current_ports=1,
current_physnet=None,
new_physnet='physnet1',
valid=False)
def test_validate_port_physnet_1_port_portgroup_no_physnet_update_1(self):
self._test_validate_port_physnet_update(
num_current_ports=1,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_1_port_portgroup_no_physnet_update_2(self):
self._test_validate_port_physnet_update(
num_current_ports=1,
current_physnet=None,
new_physnet='physnet1')
def test_validate_port_physnet_1_port_portgroup_no_physnet_update_add_1(
self):
self._test_validate_port_physnet_update_add(
num_current_ports=1,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_1_port_portgroup_no_physnet_update_add_2(
self):
self._test_validate_port_physnet_update_add(
num_current_ports=1,
current_physnet=None,
new_physnet='physnet1',
valid=False)
# 1-port portgroup, with physnet 'physnet1'.
def test_validate_port_physnet_1_port_portgroup_w_physnet_create_1(self):
self._test_validate_port_physnet_create(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet1')
def test_validate_port_physnet_1_port_portgroup_w_physnet_create_2(self):
self._test_validate_port_physnet_create(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet2',
valid=False)
def test_validate_port_physnet_1_port_portgroup_w_physnet_create_3(self):
self._test_validate_port_physnet_create(
num_current_ports=1,
current_physnet='physnet1',
new_physnet=None,
valid=False)
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_1(self):
self._test_validate_port_physnet_update(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet1')
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_2(self):
self._test_validate_port_physnet_update(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet2')
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_3(self):
self._test_validate_port_physnet_update(
num_current_ports=1,
current_physnet='physnet1',
new_physnet=None)
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_add_1(
self):
self._test_validate_port_physnet_update_add(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet1')
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_add_2(
self):
self._test_validate_port_physnet_update_add(
num_current_ports=1,
current_physnet='physnet1',
new_physnet='physnet2',
valid=False)
def test_validate_port_physnet_1_port_portgroup_w_physnet_update_add_3(
self):
self._test_validate_port_physnet_update_add(
num_current_ports=1,
current_physnet='physnet1',
new_physnet=None,
valid=False)
# 2-port portgroup, no physnet
def test_validate_port_physnet_2_port_portgroup_no_physnet_update_1(self):
self._test_validate_port_physnet_update(
num_current_ports=2,
current_physnet=None,
new_physnet=None)
def test_validate_port_physnet_2_port_portgroup_no_physnet_update_2(self):
self._test_validate_port_physnet_update(
num_current_ports=2,
current_physnet=None,
new_physnet='physnet1',
valid=False)
# 2-port portgroup, with physnet 'physnet1'
def test_validate_port_physnet_2_port_portgroup_w_physnet_update_1(self):
self._test_validate_port_physnet_update(
num_current_ports=2,
current_physnet='physnet1',
new_physnet='physnet1')
def test_validate_port_physnet_2_port_portgroup_w_physnet_update_2(self):
self._test_validate_port_physnet_update(
num_current_ports=2,
current_physnet='physnet1',
new_physnet='physnet2',
valid=False)
def test_validate_port_physnet_2_port_portgroup_w_physnet_update_3(self):
self._test_validate_port_physnet_update(
num_current_ports=2,
current_physnet='physnet1',
new_physnet=None,
valid=False)
class MiscTestCase(db_base.DbTestCase):
def setUp(self):
super(MiscTestCase, self).setUp()
self.node = obj_utils.create_test_node(
self.context,
driver='fake-hardware',
instance_info={'rescue_password': 'pass'})
def _test_remove_node_rescue_password(self, save=True):
conductor_utils.remove_node_rescue_password(self.node, save=save)
self.assertNotIn('rescue_password', self.node.instance_info)
self.node.refresh()
if save:
self.assertNotIn('rescue_password', self.node.instance_info)
else:
self.assertIn('rescue_password', self.node.instance_info)
def test_remove_node_rescue_password_save_true(self):
self._test_remove_node_rescue_password(save=True)
def test_remove_node_rescue_password_save_false(self):
self._test_remove_node_rescue_password(save=False)
@mock.patch.object(rpcapi.ConductorAPI, 'continue_node_deploy',
autospec=True)
@mock.patch.object(rpcapi.ConductorAPI, 'get_topic_for', autospec=True)
def test__notify_conductor_resume_operation(self, mock_topic,
mock_rpc_call):
mock_topic.return_value = 'topic'
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
conductor_utils._notify_conductor_resume_operation(
task, 'deploying', 'continue_node_deploy')
mock_rpc_call.assert_called_once_with(
mock.ANY, task.context, self.node.uuid, topic='topic')
@mock.patch.object(conductor_utils, '_notify_conductor_resume_operation',
autospec=True)
def test_notify_conductor_resume_clean(self, mock_resume):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
conductor_utils.notify_conductor_resume_clean(task)
mock_resume.assert_called_once_with(
task, 'cleaning', 'continue_node_clean')
@mock.patch.object(conductor_utils, '_notify_conductor_resume_operation',
autospec=True)
def test_notify_conductor_resume_deploy(self, mock_resume):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
conductor_utils.notify_conductor_resume_deploy(task)
mock_resume.assert_called_once_with(
task, 'deploying', 'continue_node_deploy')
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
@mock.patch.object(drivers_base.NetworkInterface, 'need_power_on')
@mock.patch.object(conductor_utils, 'node_set_boot_device',
autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_power_on_node_if_needed_true(
self, power_action_mock, boot_device_mock,
need_power_on_mock, get_power_state_mock, time_mock):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
need_power_on_mock.return_value = True
get_power_state_mock.return_value = states.POWER_OFF
power_state = conductor_utils.power_on_node_if_needed(task)
self.assertEqual(power_state, states.POWER_OFF)
boot_device_mock.assert_called_once_with(
task, boot_devices.BIOS, persistent=False)
power_action_mock.assert_called_once_with(task, states.POWER_ON)
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
@mock.patch.object(drivers_base.NetworkInterface, 'need_power_on')
@mock.patch.object(conductor_utils, 'node_set_boot_device',
autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_power_on_node_if_needed_false_power_on(
self, power_action_mock, boot_device_mock,
need_power_on_mock, get_power_state_mock, time_mock):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
need_power_on_mock.return_value = True
get_power_state_mock.return_value = states.POWER_ON
power_state = conductor_utils.power_on_node_if_needed(task)
self.assertIsNone(power_state)
self.assertEqual(0, boot_device_mock.call_count)
self.assertEqual(0, power_action_mock.call_count)
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
@mock.patch.object(drivers_base.NetworkInterface, 'need_power_on')
@mock.patch.object(conductor_utils, 'node_set_boot_device',
autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_power_on_node_if_needed_false_no_need(
self, power_action_mock, boot_device_mock,
need_power_on_mock, get_power_state_mock, time_mock):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
need_power_on_mock.return_value = False
get_power_state_mock.return_value = states.POWER_OFF
power_state = conductor_utils.power_on_node_if_needed(task)
self.assertIsNone(power_state)
self.assertEqual(0, boot_device_mock.call_count)
self.assertEqual(0, power_action_mock.call_count)
@mock.patch.object(neutron, 'get_client', autospec=True)
@mock.patch.object(neutron, 'wait_for_host_agent', autospec=True)
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
@mock.patch.object(drivers_base.NetworkInterface, 'need_power_on')
@mock.patch.object(conductor_utils, 'node_set_boot_device',
autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_power_on_node_if_needed_with_smart_nic_port(
self, power_action_mock, boot_device_mock,
need_power_on_mock, get_power_state_mock, time_mock,
wait_agent_mock, get_client_mock):
llc = {'port_id': 'rep0-0', 'hostname': 'host1'}
port = obj_utils.get_test_port(self.context, node_id=self.node.id,
is_smartnic=True,
local_link_connection=llc)
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
task.ports = [port]
need_power_on_mock.return_value = True
get_power_state_mock.return_value = states.POWER_OFF
power_state = conductor_utils.power_on_node_if_needed(task)
self.assertEqual(power_state, states.POWER_OFF)
boot_device_mock.assert_called_once_with(
task, boot_devices.BIOS, persistent=False)
power_action_mock.assert_called_once_with(task, states.POWER_ON)
get_client_mock.assert_called_once_with(context=self.context)
wait_agent_mock.assert_called_once_with(mock.ANY, 'host1',
target_state='down')
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_restore_power_state_if_needed_true(
self, power_action_mock, time_mock):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
power_state = states.POWER_OFF
conductor_utils.restore_power_state_if_needed(task, power_state)
power_action_mock.assert_called_once_with(task, power_state)
@mock.patch.object(time, 'sleep', autospec=True)
@mock.patch.object(conductor_utils, 'node_power_action',
autospec=True)
def test_restore_power_state_if_needed_false(
self, power_action_mock, time_mock):
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
power_state = None
conductor_utils.restore_power_state_if_needed(task, power_state)
self.assertEqual(0, power_action_mock.call_count)
class ValidateInstanceInfoTraitsTestCase(tests_base.TestCase):
def setUp(self):
super(ValidateInstanceInfoTraitsTestCase, self).setUp()
self.node = obj_utils.get_test_node(self.context,
driver='fake-hardware',
traits=['trait1', 'trait2'])
def test_validate_instance_info_traits_no_instance_traits(self):
conductor_utils.validate_instance_info_traits(self.node)
def test_validate_instance_info_traits_empty_instance_traits(self):
self.node.instance_info['traits'] = []
conductor_utils.validate_instance_info_traits(self.node)
def test_validate_instance_info_traits_invalid_type(self):
self.node.instance_info['traits'] = 'not-a-list'
self.assertRaisesRegex(exception.InvalidParameterValue,
'Error parsing traits from Node',
conductor_utils.validate_instance_info_traits,
self.node)
def test_validate_instance_info_traits_invalid_trait_type(self):
self.node.instance_info['traits'] = ['trait1', {}]
self.assertRaisesRegex(exception.InvalidParameterValue,
'Error parsing traits from Node',
conductor_utils.validate_instance_info_traits,
self.node)
def test_validate_instance_info_traits(self):
self.node.instance_info['traits'] = ['trait1', 'trait2']
conductor_utils.validate_instance_info_traits(self.node)
def test_validate_instance_info_traits_missing(self):
self.node.instance_info['traits'] = ['trait1', 'trait3']
self.assertRaisesRegex(exception.InvalidParameterValue,
'Cannot specify instance traits that are not',
conductor_utils.validate_instance_info_traits,
self.node)
@mock.patch.object(fake.FakePower, 'get_power_state', autospec=True)
class FastTrackTestCase(db_base.DbTestCase):
def setUp(self):
super(FastTrackTestCase, self).setUp()
self.node = obj_utils.create_test_node(
self.context, driver='fake-hardware',
uuid=uuidutils.generate_uuid(),
driver_internal_info={
'agent_last_heartbeat': str(timeutils.utcnow().isoformat())})
self.config(fast_track=True, group='deploy')
def test_is_fast_track(self, mock_get_power):
mock_get_power.return_value = states.POWER_ON
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
self.assertTrue(conductor_utils.is_fast_track(task))
def test_is_fast_track_config_false(self, mock_get_power):
self.config(fast_track=False, group='deploy')
mock_get_power.return_value = states.POWER_ON
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
self.assertFalse(conductor_utils.is_fast_track(task))
def test_is_fast_track_power_off_false(self, mock_get_power):
mock_get_power.return_value = states.POWER_OFF
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
self.assertFalse(conductor_utils.is_fast_track(task))
def test_is_fast_track_no_heartbeat(self, mock_get_power):
mock_get_power.return_value = states.POWER_ON
i_info = self.node.driver_internal_info
i_info.pop('agent_last_heartbeat')
self.node.driver_internal_info = i_info
self.node.save()
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
self.assertFalse(conductor_utils.is_fast_track(task))
def test_is_fast_track_error_blocks(self, mock_get_power):
mock_get_power.return_value = states.POWER_ON
self.node.last_error = "bad things happened"
self.node.save()
with task_manager.acquire(
self.context, self.node.uuid, shared=False) as task:
self.assertFalse(conductor_utils.is_fast_track(task))
class GetNodeNextStepsTestCase(db_base.DbTestCase):
def setUp(self):
super(GetNodeNextStepsTestCase, self).setUp()
self.power_update = {
'step': 'update_firmware', 'priority': 10, 'interface': 'power'}
self.deploy_update = {
'step': 'update_firmware', 'priority': 10, 'interface': 'deploy'}
self.deploy_erase = {
'step': 'erase_disks', 'priority': 20, 'interface': 'deploy'}
# Automated cleaning should be executed in this order
self.clean_steps = [self.deploy_erase, self.power_update,
self.deploy_update]
self.deploy_start = {
'step': 'deploy_start', 'priority': 50, 'interface': 'deploy'}
self.deploy_end = {
'step': 'deploy_end', 'priority': 20, 'interface': 'deploy'}
self.deploy_steps = [self.deploy_start, self.deploy_end]
def _test_get_node_next_deploy_steps(self, skip=True):
driver_internal_info = {'deploy_steps': self.deploy_steps,
'deploy_step_index': 0}
node = obj_utils.create_test_node(
self.context, driver='fake-hardware',
provision_state=states.DEPLOYWAIT,
target_provision_state=states.ACTIVE,
driver_internal_info=driver_internal_info,
last_error=None,
deploy_step=self.deploy_steps[0])
with task_manager.acquire(self.context, node.uuid) as task:
step_index = conductor_utils.get_node_next_deploy_steps(
task, skip_current_step=skip)
expected_index = 1 if skip else 0
self.assertEqual(expected_index, step_index)
def test_get_node_next_deploy_steps(self):
self._test_get_node_next_deploy_steps()
def test_get_node_next_deploy_steps_no_skip(self):
self._test_get_node_next_deploy_steps(skip=False)
def test_get_node_next_deploy_steps_unset_deploy_step(self):
driver_internal_info = {'deploy_steps': self.deploy_steps,
'deploy_step_index': None}
node = obj_utils.create_test_node(
self.context, driver='fake-hardware',
provision_state=states.DEPLOYWAIT,
target_provision_state=states.ACTIVE,
driver_internal_info=driver_internal_info,
last_error=None,
deploy_step=None)
with task_manager.acquire(self.context, node.uuid) as task:
step_index = conductor_utils.get_node_next_deploy_steps(task)
self.assertEqual(0, step_index)
def test_get_node_next_steps_exception(self):
node = obj_utils.create_test_node(self.context)
with task_manager.acquire(self.context, node.uuid) as task:
self.assertRaises(exception.Invalid,
conductor_utils._get_node_next_steps,
task, 'foo')
def _test_get_node_next_clean_steps(self, skip=True):
driver_internal_info = {'clean_steps': self.clean_steps,
'clean_step_index': 0}
node = obj_utils.create_test_node(
self.context, driver='fake-hardware',
provision_state=states.CLEANWAIT,
target_provision_state=states.AVAILABLE,
driver_internal_info=driver_internal_info,
last_error=None,
clean_step=self.clean_steps[0])
with task_manager.acquire(self.context, node.uuid) as task:
step_index = conductor_utils.get_node_next_clean_steps(
task, skip_current_step=skip)
expected_index = 1 if skip else 0
self.assertEqual(expected_index, step_index)
def test_get_node_next_clean_steps(self):
self._test_get_node_next_clean_steps()
def test_get_node_next_clean_steps_no_skip(self):
self._test_get_node_next_clean_steps(skip=False)
def test_get_node_next_clean_steps_unset_clean_step(self):
driver_internal_info = {'clean_steps': self.clean_steps,
'clean_step_index': None}
node = obj_utils.create_test_node(
self.context, driver='fake-hardware',
provision_state=states.CLEANWAIT,
target_provision_state=states.AVAILABLE,
driver_internal_info=driver_internal_info,
last_error=None,
clean_step=None)
with task_manager.acquire(self.context, node.uuid) as task:
step_index = conductor_utils.get_node_next_clean_steps(task)
self.assertEqual(0, step_index)
class AgentTokenUtilsTestCase(tests_base.TestCase):
def setUp(self):
super(AgentTokenUtilsTestCase, self).setUp()
self.node = obj_utils.get_test_node(self.context,
driver='fake-hardware')
def test_add_secret_token(self):
self.assertNotIn('agent_secret_token', self.node.driver_internal_info)
conductor_utils.add_secret_token(self.node)
self.assertIn('agent_secret_token', self.node.driver_internal_info)
def test_del_secret_token(self):
conductor_utils.add_secret_token(self.node)
self.assertIn('agent_secret_token', self.node.driver_internal_info)
conductor_utils.del_secret_token(self.node)
self.assertNotIn('agent_secret_token', self.node.driver_internal_info)
def test_is_agent_token_present(self):
# This should always be False as the token has not been added yet.
self.assertFalse(conductor_utils.is_agent_token_present(self.node))
conductor_utils.add_secret_token(self.node)
self.assertTrue(conductor_utils.is_agent_token_present(self.node))
def test_is_agent_token_supported(self):
self.assertTrue(
conductor_utils.is_agent_token_supported('6.1.1.dev39'))
self.assertTrue(
conductor_utils.is_agent_token_supported('6.2.1'))
self.assertFalse(
conductor_utils.is_agent_token_supported('6.0.0'))
|