summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2018-10-19 08:34:47 +0000
committerGerrit Code Review <review@openstack.org>2018-10-19 08:34:47 +0000
commitec87e19f40ea561e325b8e26debf303ad775643d (patch)
tree97544ac41f8e812ef512d62a1fdf818b09577cb3
parent55fda22d5b9f6c99ce093aefe13b3cb728e47748 (diff)
parenta09ba6906573432ec0b7bd4ec0522caf06dc3b8c (diff)
downloadkeystone-12.0.2.tar.gz
Merge "Mapped Groups don't exist breaks WebSSO" into stable/pike12.0.2
-rw-r--r--keystone/federation/utils.py4
-rw-r--r--keystone/tests/unit/test_v3_federation.py9
2 files changed, 8 insertions, 5 deletions
diff --git a/keystone/federation/utils.py b/keystone/federation/utils.py
index 1eeecf39c..449abbf12 100644
--- a/keystone/federation/utils.py
+++ b/keystone/federation/utils.py
@@ -409,8 +409,8 @@ def transform_to_group_ids(group_names, mapping_id,
group['name'], resolve_domain(group['domain']))
yield group_dict['id']
except exception.GroupNotFound:
- raise exception.MappedGroupNotFound(group_id=group['name'],
- mapping_id=mapping_id)
+ LOG.debug('Group %s has no entry in the backend',
+ group['name'])
def get_assertion_params_from_env(request):
diff --git a/keystone/tests/unit/test_v3_federation.py b/keystone/tests/unit/test_v3_federation.py
index 23934ab18..d5f9bd15b 100644
--- a/keystone/tests/unit/test_v3_federation.py
+++ b/keystone/tests/unit/test_v3_federation.py
@@ -1890,9 +1890,8 @@ class FederatedTokenTests(test_v3.RestfulTestCase, FederatedSetupMixin):
self.assertEqual(ref_groups, token_groups)
def test_issue_unscoped_tokens_nonexisting_group(self):
- self.assertRaises(exception.MappedGroupNotFound,
- self._issue_unscoped_token,
- assertion='ANOTHER_TESTER_ASSERTION')
+ r = self._issue_unscoped_token(assertion='ANOTHER_TESTER_ASSERTION')
+ self.assertIsNotNone(r.headers.get('X-Subject-Token'))
def test_issue_unscoped_token_with_remote_no_attribute(self):
r = self._issue_unscoped_token(idp=self.IDP_WITH_REMOTE,
@@ -2417,6 +2416,10 @@ class FederatedTokenTests(test_v3.RestfulTestCase, FederatedSetupMixin):
]
}
self.federation_api.update_mapping(self.mapping['id'], rules)
+ r = self._issue_unscoped_token(assertion='UNMATCHED_GROUP_ASSERTION')
+ assigned_group_ids = r.json['token']['user']['OS-FEDERATION']['groups']
+ self.assertEqual(1, len(assigned_group_ids))
+ self.assertEqual(group['id'], assigned_group_ids[0]['id'])
def test_empty_blacklist_passess_all_values(self):
"""Test a mapping with empty blacklist specified.