diff options
| author | Colleen Murphy <colleen.murphy@suse.de> | 2019-10-18 09:08:07 -0700 |
|---|---|---|
| committer | Colleen Murphy <colleen.murphy@suse.de> | 2019-10-21 08:48:47 -0700 |
| commit | e2d83ae95df2a9c5bb0ad72f2aef957e7eb36a2d (patch) | |
| tree | f1e4615cad6f0de45efbad57ec5d87cf4cfc7b4a /keystone/tests/unit/test_cli.py | |
| parent | 19d4831daa3991bed48fb364fa05927740c96445 (diff) | |
| download | keystone-e2d83ae95df2a9c5bb0ad72f2aef957e7eb36a2d.tar.gz | |
Re-enable line-length linter
In 09088690 we mistakenly added E501 to the flake8 ignore list. Since
then, many new violations have been introduced. This patch re-enables
the check and corrects all violations, except in some cases like unit
test names where the subunit output would suffer if we attempted to
shorten the function name.
This may appear to be a pointless no-op that messes with
git-blameability, and it is, but the reason to do this is that if PEP8
violations are introduced in master and then backported to a stable
branch, most stable branches will fail the pep8 job since the flake8
ignore list is correct for those branches. Rather than loosening the
check in older branches or requiring those backports to fix the linter
errors independently of what's been merged in master, we should fix it
now so that we don't introduce more errors in the future and patches can
more easily be backported.
Change-Id: I9f71926105eb448bb0200201d1838b67d4963cd6
Diffstat (limited to 'keystone/tests/unit/test_cli.py')
| -rw-r--r-- | keystone/tests/unit/test_cli.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/keystone/tests/unit/test_cli.py b/keystone/tests/unit/test_cli.py index cdc0e1327..990b90d9d 100644 --- a/keystone/tests/unit/test_cli.py +++ b/keystone/tests/unit/test_cli.py @@ -220,8 +220,10 @@ class CliBootStrapTestCase(unit.SQLDriverOverrides, unit.TestCase): headers={'X-Auth-Token': r.headers['X-Subject-Token'], 'X-Subject-Token': token}) admin_role = PROVIDERS.role_api.get_role(self.bootstrap.role_id) - reader_role = PROVIDERS.role_api.get_role(self.bootstrap.reader_role_id) - member_role = PROVIDERS.role_api.get_role(self.bootstrap.member_role_id) + reader_role = PROVIDERS.role_api.get_role( + self.bootstrap.reader_role_id) + member_role = PROVIDERS.role_api.get_role( + self.bootstrap.member_role_id) self.assertEqual(admin_role['options'], {}) self.assertEqual(member_role['options'], {}) self.assertEqual(reader_role['options'], {}) @@ -305,8 +307,10 @@ class CliBootStrapTestCase(unit.SQLDriverOverrides, unit.TestCase): project='keystone') self._do_test_bootstrap(self.bootstrap) admin_role = PROVIDERS.role_api.get_role(self.bootstrap.role_id) - reader_role = PROVIDERS.role_api.get_role(self.bootstrap.reader_role_id) - member_role = PROVIDERS.role_api.get_role(self.bootstrap.member_role_id) + reader_role = PROVIDERS.role_api.get_role( + self.bootstrap.reader_role_id) + member_role = PROVIDERS.role_api.get_role( + self.bootstrap.member_role_id) self.assertTrue(admin_role['options']['immutable']) self.assertTrue(member_role['options']['immutable']) self.assertTrue(reader_role['options']['immutable']) |