diff options
| author | Hervé Beraud <hberaud@redhat.com> | 2020-06-09 10:43:32 +0200 |
|---|---|---|
| committer | Sean McGinnis <sean.mcginnis@gmail.com> | 2020-06-17 14:42:03 +0000 |
| commit | 3df1679658dc56409b1e47a99468a65767bfaf62 (patch) | |
| tree | f2076cff4627eb3f515ac8a1e79a8fddf0913c95 /HACKING.rst | |
| parent | 8913461aa9896e00a011693d20a42188766a8348 (diff) | |
| download | neutron-3df1679658dc56409b1e47a99468a65767bfaf62.tar.gz | |
Use unittest.mock instead of mock
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.
Also enabled the hacking check that should have caught this, it
was missing from tox.ini along with most of the other in-tree
hacking checks we have added over the years.
Change-Id: Id91175d0db8b8edc72f0dd98925ddbf7415bb881
Diffstat (limited to 'HACKING.rst')
| -rw-r--r-- | HACKING.rst | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst index 19b0098170..da137db0ee 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -26,6 +26,8 @@ Below you can find a list of checks specific to this repository. - [N343] Production code must not import from neutron.tests.* - [N344] Python 3: Do not use filter(lambda obj: test(obj), data). Replace it with [obj for obj in data if test(obj)]. +- [N346] Use neutron_lib.db.api.sqla_listen rather than sqlalchemy +- [N347] Test code must not import mock library .. note:: When adding a new hacking check to this repository or ``neutron-lib``, make |