diff options
author | Zuul <zuul@review.opendev.org> | 2023-02-07 13:42:18 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2023-02-07 13:42:18 +0000 |
commit | 7ea9aac71cb809efc4c9990dd0569e271cee8aba (patch) | |
tree | 1efa04278db7186dd5fc1ffe7512ebafb5b7275f | |
parent | 8cbb241e01e0492b6d4aceda5e86901f13662470 (diff) | |
parent | 5934f85fb9e7d18a05ef7e8a6217697bed753d4f (diff) | |
download | nova-7ea9aac71cb809efc4c9990dd0569e271cee8aba.tar.gz |
Merge "Move comment about _destroy_evacuated_instances()"
-rw-r--r-- | nova/compute/manager.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/nova/compute/manager.py b/nova/compute/manager.py index 2aad5c77fb..c4537cd9a2 100644 --- a/nova/compute/manager.py +++ b/nova/compute/manager.py @@ -1610,12 +1610,6 @@ class ComputeManager(manager.Manager): # NOTE(gibi): At this point the compute_nodes of the resource tracker # has not been populated yet so we cannot rely on the resource tracker # here. - # NOTE(gibi): If ironic and vcenter virt driver slow start time - # becomes problematic here then we should consider adding a config - # option or a driver flag to tell us if we should thread - # _destroy_evacuated_instances and - # _error_out_instances_whose_build_was_interrupted out in the - # background on startup context = nova.context.get_admin_context() nodes_by_uuid = self._get_nodes(context) @@ -1633,6 +1627,12 @@ class ComputeManager(manager.Manager): self._validate_pinning_configuration(instances) self._validate_vtpm_configuration(instances) + # NOTE(gibi): If ironic and vcenter virt driver slow start time + # becomes problematic here then we should consider adding a config + # option or a driver flag to tell us if we should thread + # _destroy_evacuated_instances and + # _error_out_instances_whose_build_was_interrupted out in the + # background on startup try: # checking that instance was not already evacuated to other host evacuated_instances = self._destroy_evacuated_instances( |