diff options
author | Gábor Antal <antal@inf.u-szeged.hu> | 2016-09-15 07:53:52 +0200 |
---|---|---|
committer | Gábor Antal <antal@inf.u-szeged.hu> | 2017-02-09 14:03:53 +0100 |
commit | 6eaf6dcb1e6382380d1c96d5b6fd3b3dc11fed2b (patch) | |
tree | 56db9370fc1ad740839f32ebc4e06d378aa2d2fd /HACKING.rst | |
parent | 224ae10ec70fd58767632f009cf721ccf8253265 (diff) | |
download | nova-6eaf6dcb1e6382380d1c96d5b6fd3b3dc11fed2b.tar.gz |
Removed unnecessary parantheses and fixed formation
Some place in Nova, return value has unnecessary parentheses,
or return keyword is not followed by a space when returning a value,
which is a bad format and might be ambigous. For example:
return(1)
return{
'a': 1
}
As noone would write returns like:
return1
return'(empty)'
In this patchset we get rid of this bad formation.
Also, I've added a hacking rule which helps to prevent this in future.
TrivialFix
Change-Id: I4ff85d0240bf8719188ebd06fc0e98a81c1d1203
Diffstat (limited to 'HACKING.rst')
-rw-r--r-- | HACKING.rst | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst index 45ed114b60..1161a350cb 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -69,6 +69,7 @@ Nova Specific Commandments - [N356] Enforce use of assertIs/assertIsNot - [N357] Use oslo_utils.uuidutils or uuidsentinel(in case of test cases) to generate UUID instead of uuid4(). +- [N358] Return must always be followed by a space when returning a value. Creating Unit Tests ------------------- |