diff options
| author | Takashi Natsume <takanattie@gmail.com> | 2020-09-28 22:35:00 +0900 |
|---|---|---|
| committer | Takashi Natsume <takanattie@gmail.com> | 2020-09-28 23:08:15 +0900 |
| commit | 8d3c2ce92bcaf8cf777bf29fd46275572da61547 (patch) | |
| tree | b13754b5b56b7607af61705da5d5212ffa6bdfb9 /HACKING.rst | |
| parent | 4acc112a308d0cedd5bfc00eb0621aba99e0d910 (diff) | |
| download | nova-8d3c2ce92bcaf8cf777bf29fd46275572da61547.tar.gz | |
Add a hacking rule for assert_has_calls
Add the following hacking rule.
* N366: The assert_has_calls is a method rather than a variable.
Not correct: mock_method.assert_has_calls = [mock.call(0)]
Correct: mock_method.assert_has_calls([mock.call(0)])
This patch is a follow-up patch for
Id094dd90efde09b9a835d4492f4a92b8f8ad296e.
Change-Id: I892f8c23ee44f2b3518776a9705e3543f3115cae
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Diffstat (limited to 'HACKING.rst')
| -rw-r--r-- | HACKING.rst | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst index 6678328fd2..76ff4b6c22 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -67,6 +67,7 @@ Nova Specific Commandments - [N363] Disallow ``(not_a_tuple)`` because you meant ``(a_tuple_of_one,)``. - [N364] Check non-existent mock assertion methods and attributes. - [N365] Check misuse of assertTrue/assertIsNone. +- [N366] The assert_has_calls is a method rather than a variable. Creating Unit Tests ------------------- |