diff options
| author | Takashi Natsume <takanattie@gmail.com> | 2020-06-07 11:59:30 +0000 |
|---|---|---|
| committer | Takashi Natsume <takanattie@gmail.com> | 2020-06-17 08:19:13 +0000 |
| commit | 9dca0d186f834c38d0d06e226b18ab3ae717c140 (patch) | |
| tree | 5f3f3eae3b52a3f2c521139e2d22d7a1e83c9769 /HACKING.rst | |
| parent | 1490a54fa92ece6d9fd676d8e4a7498460714f92 (diff) | |
| download | nova-9dca0d186f834c38d0d06e226b18ab3ae717c140.tar.gz | |
Remove hacking rules for python 2/3 compatibility
The Python 2.7 Support has been dropped since Ussuri.
So remove hacking rules for compatibility between python 2 and 3.
- [N325] str() and unicode() cannot be used on an exception.
Remove or use six.text_type()
- [N327] Do not use xrange(). xrange() is not compatible with Python 3.
Use range() or six.moves.range() instead.
- [N344] Python 3: do not use dict.iteritems.
- [N345] Python 3: do not use dict.iterkeys.
- [N346] Python 3: do not use dict.itervalues.
See also line 414 in https://etherpad.opendev.org/p/nova-victoria-ptg
Change-Id: If4335b2e8ef5bbabba37598110c1aa8269635c2f
Implements: blueprint six-removal
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
Diffstat (limited to 'HACKING.rst')
| -rw-r--r-- | HACKING.rst | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/HACKING.rst b/HACKING.rst index 46c17d41a8..6678328fd2 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -31,9 +31,7 @@ Nova Specific Commandments - [N322] Method's default argument shouldn't be mutable - [N323] Ensure that the _() function is explicitly imported to ensure proper translations. - [N324] Ensure that jsonutils.%(fun)s must be used instead of json.%(fun)s -- [N325] str() and unicode() cannot be used on an exception. Remove use or use six.text_type() - [N326] Translated messages cannot be concatenated. String should be included in translated message. -- [N327] Do not use xrange(). xrange() is not compatible with Python 3. Use range() or six.moves.range() instead. - [N332] Check that the api_version decorator is the first decorator on a method - [N334] Change assertTrue/False(A in/not in B, message) to the more specific assertIn/NotIn(A, B, message) @@ -48,9 +46,6 @@ Nova Specific Commandments - [N341] contextlib.nested is deprecated - [N342] Config options should be in the central location ``nova/conf/`` - [N343] Check for common double word typos -- [N344] Python 3: do not use dict.iteritems. -- [N345] Python 3: do not use dict.iterkeys. -- [N346] Python 3: do not use dict.itervalues. - [N348] Deprecated library function os.popen() - [N349] Check for closures in tests which are not used - [N350] Policy registration should be in the central location ``nova/policies/`` |