summaryrefslogtreecommitdiff
path: root/HACKING.rst
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2015-02-05 17:13:04 +0000
committerGerrit Code Review <review@openstack.org>2015-02-05 17:13:04 +0000
commit9e304ebe26b3ecd2f8738fa7c10104e8680dfec0 (patch)
tree477896b066e72dc7c06297534052671a9b11c12a /HACKING.rst
parent84ab1720aa908bce1936df629a6479b8dd52ceca (diff)
parent16774b6d33bda4fe356d14619c843e1d55722e40 (diff)
downloadnova-9e304ebe26b3ecd2f8738fa7c10104e8680dfec0.tar.gz
Merge "Added hacking rule for assertEqual(a in b, True/False)."2015.1.0b2
Diffstat (limited to 'HACKING.rst')
-rw-r--r--HACKING.rst3
1 files changed, 3 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst
index f96b9dfb9f..3e58dc52ad 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -47,6 +47,9 @@ Nova Specific Commandments
- [N335] Check for usage of deprecated assertRaisesRegexp
- [N336] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs.
- [N337] Don't import translation in tests
+- [N338] Change assertEqual(A in B, True), assertEqual(True, A in B),
+ assertEqual(A in B, False) or assertEqual(False, A in B) to the more specific
+ assertIn/NotIn(A, B)
Creating Unit Tests
-------------------