diff options
| author | Sean Dague <sean@dague.net> | 2017-03-16 07:00:06 -0400 |
|---|---|---|
| committer | Sean Dague <sean@dague.net> | 2017-03-16 09:56:21 -0400 |
| commit | 4032d6950f3b2e0e78d6749ad44a45d95caf9ad4 (patch) | |
| tree | a963ace132e50d79a916b669fbb0a473b2e644ad /nova/hacking | |
| parent | d83386524b07cf9da038dae4d487f6a234918e6c (diff) | |
| download | nova-4032d6950f3b2e0e78d6749ad44a45d95caf9ad4.tar.gz | |
remove hacking rule that enforces log translation
All of the po files for log translation have been deleted from the
Nova tree as of I3206d8bcbffe7ef1d84acf0fac6b423a26fccf94 which has
made all of this infrastructure unused. The mailing list discussions
are pretty much all coming back to the fact that no one ever really
wanted this feature, and it was pushed in purely as a product
requirement checklist.
This removes hacking enforcement of this now unused feature, and will
allow people to start deleting the i18n markup without coming afoul of
hacking.
Change-Id: I9c334162fe1799e7b24563fdc11256b91bbafc9f
Diffstat (limited to 'nova/hacking')
| -rw-r--r-- | nova/hacking/checks.py | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/nova/hacking/checks.py b/nova/hacking/checks.py index b4a477adca..886547c511 100644 --- a/nova/hacking/checks.py +++ b/nova/hacking/checks.py @@ -311,28 +311,6 @@ def no_setting_conf_directly_in_tests(logical_line, filename): "forbidden. Use self.flags(option=value) instead") -def validate_log_translations(logical_line, physical_line, filename): - # Translations are not required in the test directory - # and the Xen utilities - if ("nova/tests" in filename or - "plugins/xenserver/xenapi/etc/xapi.d" in filename): - return - if pep8.noqa(physical_line): - return - msg = "N328: LOG.info messages require translations `_LI()`!" - if log_translation_info.match(logical_line): - yield (0, msg) - msg = "N329: LOG.exception messages require translations `_LE()`!" - if log_translation_exception.match(logical_line): - yield (0, msg) - msg = "N330: LOG.warning, LOG.warn messages require translations `_LW()`!" - if log_translation_LW.match(logical_line): - yield (0, msg) - msg = "N321: Log messages require translations!" - if log_translation.match(logical_line): - yield (0, msg) - - def no_mutable_default_args(logical_line): msg = "N322: Method's default argument shouldn't be mutable!" if mutable_default_args.match(logical_line): @@ -846,7 +824,6 @@ def factory(register): register(assert_raises_regexp) register(no_translate_debug_logs) register(no_setting_conf_directly_in_tests) - register(validate_log_translations) register(no_mutable_default_args) register(check_explicit_underscore_import) register(use_jsonutils) |