diff options
author | Lee Yarwood <lyarwood@redhat.com> | 2022-01-19 13:46:56 +0000 |
---|---|---|
committer | melanie witt <melwittt@gmail.com> | 2022-08-02 21:25:47 +0000 |
commit | 184f0074cc5f4609642b52c98a7ccbfc5f892a33 (patch) | |
tree | 5324df8de634ae936a9221ed3a65ee8420d4b350 /nova/tests/unit/objects | |
parent | 535212eaadadf4a8d4b4ebb3200d547d353b4deb (diff) | |
download | nova-184f0074cc5f4609642b52c98a7ccbfc5f892a33.tar.gz |
imagebackend: default by_name image_type to config correctly
Callers of by_name shouldn't need to pass in the default from CONF.
This has implications for the libvirt_imagebackend fixture. The
_mock_backend() method in the libvirt_imagebackend fixture is what
mocks out Backend.backend(). Before this patch, the defaulting of
image_type to CONF.libvirt.images_type was done *inside*
Backend.backend() whenever image_type=None was passed in. As of this
patch, this is no longer case, and the default value from CONF gets
passed in instead.
Unit tests were testing the previous behaviour and essentially just
asserting that None was passed in. This was never really correct to
begin with, so a couple of assertIsNone() assertions need to be
updated.
Change-Id: Ib95aa440ffff0989c90f09f5b5d4e26b30db9683
Diffstat (limited to 'nova/tests/unit/objects')
0 files changed, 0 insertions, 0 deletions