diff options
author | melanie witt <melwittt@gmail.com> | 2023-05-11 19:23:52 +0000 |
---|---|---|
committer | melanie witt <melwittt@gmail.com> | 2023-05-17 00:57:37 +0000 |
commit | c095cfe04e2c71efcfbfdd95948af080a98065e6 (patch) | |
tree | 2d0d9e73f6c7b08747b43e59b0898c6205eaffd7 /nova/virt/vmwareapi | |
parent | e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4 (diff) | |
download | nova-c095cfe04e2c71efcfbfdd95948af080a98065e6.tar.gz |
tests: Use GreenThreadPoolExecutor.shutdown(wait=True)
We are still having some issues in the gate where greenlets from
previous tests continue to run while the next test starts, causing
false negative failures in unit or functional test jobs.
This adds a new fixture that will ensure
GreenThreadPoolExecutor.shutdown() is called with wait=True, to wait
for greenlets in the pool to finish running before moving on.
In local testing, doing this does not appear to adversely affect test
run times, which was my primary concern.
As a baseline, I ran a subset of functional tests in a loop
until failure without the patch and after 11 hours, I got a failure
reproducing the bug. With the patch, running the same subset of
functional tests in a loop has been running for 24 hours and has not
failed yet.
Based on this, I think it may be worth trying this out to see if it
will help stability of our unit and functional test jobs. And if it
ends up impacting test run times or causes other issues, we can
revert it.
Partial-Bug: #1946339
Change-Id: Ia916310522b007061660172fa4d63d0fde9a55ac
Diffstat (limited to 'nova/virt/vmwareapi')
0 files changed, 0 insertions, 0 deletions