summaryrefslogtreecommitdiff
path: root/nova
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2019-04-02 23:42:02 +0000
committerGerrit Code Review <review@openstack.org>2019-04-02 23:42:02 +0000
commit396f499706aa48db5feca2efc122c7d1b7857010 (patch)
treeda1f303ec8bbb9151f8348d1a89954f5f4ca8f82 /nova
parent41c387360e4cfe0f7724528c0c637a402ef6f0aa (diff)
parent425f17e2af864c8c3068044be70f05180ec79b1b (diff)
downloadnova-396f499706aa48db5feca2efc122c7d1b7857010.tar.gz
Merge "libvirt: smbfs: Use 'writeback' QEMU cache mode"
Diffstat (limited to 'nova')
-rw-r--r--nova/tests/unit/virt/libvirt/volume/test_smbfs.py1
-rw-r--r--nova/virt/libvirt/volume/smbfs.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/nova/tests/unit/virt/libvirt/volume/test_smbfs.py b/nova/tests/unit/virt/libvirt/volume/test_smbfs.py
index b39a4ebad8..2c3ea574a9 100644
--- a/nova/tests/unit/virt/libvirt/volume/test_smbfs.py
+++ b/nova/tests/unit/virt/libvirt/volume/test_smbfs.py
@@ -83,6 +83,7 @@ class LibvirtSMBFSVolumeDriverTestCase(test_volume.LibvirtVolumeBaseTestCase):
conf = libvirt_driver.get_config(connection_info, self.disk_info)
tree = conf.format_dom()
self._assertFileTypeEquals(tree, file_path)
+ self.assertEqual('writeback', conf.driver_cache)
@mock.patch.object(libvirt_utils, 'is_mounted')
@mock.patch('oslo_utils.fileutils.ensure_tree')
diff --git a/nova/virt/libvirt/volume/smbfs.py b/nova/virt/libvirt/volume/smbfs.py
index 02534be0d0..d112af750c 100644
--- a/nova/virt/libvirt/volume/smbfs.py
+++ b/nova/virt/libvirt/volume/smbfs.py
@@ -34,7 +34,7 @@ class LibvirtSMBFSVolumeDriver(fs.LibvirtBaseFileSystemVolumeDriver):
self).get_config(connection_info, disk_info)
conf.source_type = 'file'
- conf.driver_cache = 'writethrough'
+ conf.driver_cache = 'writeback'
conf.source_path = connection_info['data']['device_path']
conf.driver_format = connection_info['data'].get('format', 'raw')
return conf