diff options
author | Stephen Finucane <sfinucan@redhat.com> | 2019-06-15 16:50:35 +0100 |
---|---|---|
committer | Stephen Finucane <sfinucan@redhat.com> | 2019-11-28 12:46:55 +0000 |
commit | 5f8dd65f6cfcb7f33e72b9371f325801835c9c83 (patch) | |
tree | d2eed315b12c94d0cfaeda41787eaea0f55393dc /tools | |
parent | 23995b4f9945aa242f6a9e7bd5bc700c27f31eb2 (diff) | |
download | nova-5f8dd65f6cfcb7f33e72b9371f325801835c9c83.tar.gz |
Integrate 'pre-commit'
This nifty tool provides a extensible way to configure pre-commit hooks
to do everything from running linters to spellchecking [1] and has
already been adopted by a few OpenStack projects [2]. Let's start using
it as a faster, more automatic alternative to the 'fast8' tox target and
iterate on it as we find more things to use it for. The 'fast8' target
is not deprecated though a note is included for end-users to alert them
to this great new tool.
Note that the 'check-executables-have-shebangs' actually failed and
highlighted that the 'contributor/development-environment.rst' document
was marked as executable when it shouldn't have been. This is corrected.
[1] https://pre-commit.com/
[2] https://review.opendev.org/#/q/file:.pre-commit-config.yaml
Change-Id: I256e75eceeb3495dce04885ca42d16adb4160cf3
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Diffstat (limited to 'tools')
-rwxr-xr-x | tools/flake8wrap.sh | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tools/flake8wrap.sh b/tools/flake8wrap.sh index ab3269df7f..c7478ac484 100755 --- a/tools/flake8wrap.sh +++ b/tools/flake8wrap.sh @@ -13,8 +13,15 @@ if test "x$1" = "x-HEAD" ; then shift files=$(git diff --name-only HEAD~1 | tr '\n' ' ') echo "Running flake8 on ${files}" + echo "" + echo "Consider using the 'pre-commit' tool instead." + echo "" + echo " pip install --user pre-commit" + echo " pre-commit install --allow-missing-config" + echo "" diff -u --from-file /dev/null ${files} | flake8 --diff "$@" else echo "Running flake8 on all files" + echo "" exec flake8 "$@" fi |