1 files changed, 144 insertions, 0 deletions
diff --git a/nova/tests/unit/compute/monitors/test_monitors.py b/nova/tests/unit/compute/monitors/test_monitors.py
new file mode 100644
index 0000000000..e846479483
--- /dev/null
+++ b/nova/tests/unit/compute/monitors/test_monitors.py
@@ -0,0 +1,144 @@
+# Copyright 2013 Intel Corporation
+# All Rights Reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+"""Tests for resource monitors."""
+
+from nova.compute import monitors
+from nova import test
+
+
+class FakeResourceMonitor(monitors.ResourceMonitorBase):
+    def _update_data(self):
+        self._data['foo.metric1'] = '1000'
+        self._data['foo.metric2'] = '99.999'
+        self._data['timestamp'] = '123'
+
+    @monitors.ResourceMonitorBase.add_timestamp
+    def _get_foo_metric1(self, **kwargs):
+        return self._data.get("foo.metric1")
+
+    @monitors.ResourceMonitorBase.add_timestamp
+    def _get_foo_metric2(self, **kwargs):
+        return self._data.get("foo.metric2")
+
+
+class FakeMonitorClass1(monitors.ResourceMonitorBase):
+    def get_metrics(self, **kwargs):
+        data = [{'timestamp': 1232,
+                 'name': 'key1',
+                 'value': 2600,
+                 'source': 'libvirt'}]
+        return data
+
+    def get_metric_names(self):
+        return ['key1']
+
+
+class FakeMonitorClass2(monitors.ResourceMonitorBase):
+    def get_metrics(self, **kwargs):
+        data = [{'timestamp': 123,
+                 'name': 'key2',
+                 'value': 1600,
+                 'source': 'libvirt'}]
+        return data
+
+    def get_metric_names(self):
+        return ['key2']
+
+
+class FakeMonitorClass3(monitors.ResourceMonitorBase):
+    def get_metrics(self, **kwargs):
+        data = [{'timestamp': 1234,
+                 'name': 'key1',
+                 'value': 1200,
+                 'source': 'libvirt'}]
+        return data
+
+    def get_metric_names(self):
+        return ['key1']
+
+
+class FakeMonitorClass4(monitors.ResourceMonitorBase):
+    def get_metrics(self, **kwargs):
+        raise test.TestingException()
+
+    def get_metric_names(self):
+        raise test.TestingException()
+
+
+class ResourceMonitorBaseTestCase(test.TestCase):
+    def setUp(self):
+        super(ResourceMonitorBaseTestCase, self).setUp()
+        self.monitor = FakeResourceMonitor(None)
+
+    def test_get_metric_names(self):
+        names = self.monitor.get_metric_names()
+        self.assertEqual(2, len(names))
+        self.assertIn("foo.metric1", names)
+        self.assertIn("foo.metric2", names)
+
+    def test_get_metrics(self):
+        metrics_raw = self.monitor.get_metrics()
+        names = self.monitor.get_metric_names()
+        metrics = {}
+        for metric in metrics_raw:
+            self.assertIn(metric['name'], names)
+            self.assertEqual(metric["timestamp"], '123')
+            metrics[metric['name']] = metric['value']
+
+        self.assertEqual(metrics["foo.metric1"], '1000')
+        self.assertEqual(metrics["foo.metric2"], '99.999')
+
+
+class ResourceMonitorsTestCase(test.TestCase):
+    """Test case for monitors."""
+
+    def setUp(self):
+        super(ResourceMonitorsTestCase, self).setUp()
+        self.monitor_handler = monitors.ResourceMonitorHandler()
+        fake_monitors = [
+            'nova.tests.unit.compute.monitors.test_monitors.FakeMonitorClass1',
+            'nova.tests.unit.compute.monitors.test_monitors.FakeMonitorClass2']
+        self.flags(compute_available_monitors=fake_monitors)
+
+        classes = self.monitor_handler.get_matching_classes(
+            ['nova.compute.monitors.all_monitors'])
+        self.class_map = {}
+        for cls in classes:
+            self.class_map[cls.__name__] = cls
+
+    def test_choose_monitors_not_found(self):
+        self.flags(compute_monitors=['FakeMonitorClass5', 'FakeMonitorClass4'])
+        monitor_classes = self.monitor_handler.choose_monitors(self)
+        self.assertEqual(len(monitor_classes), 0)
+
+    def test_choose_monitors_bad(self):
+        self.flags(compute_monitors=['FakeMonitorClass1', 'FakePluginClass3'])
+        monitor_classes = self.monitor_handler.choose_monitors(self)
+        self.assertEqual(len(monitor_classes), 1)
+
+    def test_choose_monitors(self):
+        self.flags(compute_monitors=['FakeMonitorClass1', 'FakeMonitorClass2'])
+        monitor_classes = self.monitor_handler.choose_monitors(self)
+        self.assertEqual(len(monitor_classes), 2)
+
+    def test_choose_monitors_none(self):
+        self.flags(compute_monitors=[])
+        monitor_classes = self.monitor_handler.choose_monitors(self)
+        self.assertEqual(len(monitor_classes), 0)
+
+    def test_all_monitors(self):
+        # Double check at least a couple of known monitors exist
+        self.assertIn('ComputeDriverCPUMonitor', self.class_map)