1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
|
# Copyright 2019 OpenStack Foundation
# Copyright 2019 Aptira Pty Ltd
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import binascii
from unittest import mock
import ddt
import os
import nova.privsep.libvirt
from nova import test
from nova.tests import fixtures
from oslo_utils import units
class LibvirtTestCase(test.NoDBTestCase):
"""Test libvirt related utility methods."""
def setUp(self):
super(LibvirtTestCase, self).setUp()
self.useFixture(fixtures.PrivsepFixture())
@mock.patch('oslo_concurrency.processutils.execute')
def test_dmcrypt_create_volume(self, mock_execute):
nova.privsep.libvirt.dmcrypt_create_volume(
'/fake/path', '/dev/nosuch', 'LUKS1', 1024, b'I am a fish')
mock_execute.assert_called_with(
'cryptsetup', 'create', '/fake/path', '/dev/nosuch',
'--cipher=LUKS1', '--key-size=1024', '--key-file=-',
process_input=binascii.hexlify(b'I am a fish').decode('utf-8'))
@mock.patch('oslo_concurrency.processutils.execute')
def test_dmcrypt_delete_volume(self, mock_execute):
nova.privsep.libvirt.dmcrypt_delete_volume('/fake/path')
mock_execute.assert_called_with('cryptsetup', 'remove', '/fake/path')
@mock.patch('oslo_concurrency.processutils.execute')
@mock.patch('os.stat')
@mock.patch('os.chmod')
def test_ploop_init(self, mock_chmod, mock_stat, mock_execute):
nova.privsep.libvirt.ploop_init(1024, 'raw', 'ext4', '/fake/path')
mock_execute.assert_called_with(
'ploop', 'init', '-s', 1024, '-f', 'raw', '-t',
'ext4', '/fake/path', check_exit_code=True)
mock_stat.assert_called_with('/fake/path')
mock_chmod.assert_called_with('/fake/path', mock.ANY)
@mock.patch('oslo_concurrency.processutils.execute')
def test_ploop_resize(self, mock_execute):
nova.privsep.libvirt.ploop_resize(
'/fake/path', 2048 * units.Mi)
mock_execute.assert_called_with('prl_disk_tool', 'resize',
'--size', '2048M',
'--resize_partition',
'--hdd', '/fake/path',
check_exit_code=True)
@mock.patch('oslo_concurrency.processutils.execute')
def test_ploop_restore_descriptor(self, mock_execute):
nova.privsep.libvirt.ploop_restore_descriptor(
'/img/dir', 'imagefile', 'raw')
mock_execute.assert_called_with(
'ploop', 'restore-descriptor', '-f', 'raw',
'/img/dir', 'imagefile', check_exit_code=True)
@mock.patch('oslo_concurrency.processutils.execute')
def test_plug_infiniband_vif(self, mock_execute):
nova.privsep.libvirt.plug_infiniband_vif('fakemac', 'devid', 'fabric',
'netmodel', 'pcislot')
mock_execute.assert_called_with(
'ebrctl', 'add-port', 'fakemac', 'devid', 'fabric', 'netmodel',
'pcislot')
@mock.patch('oslo_concurrency.processutils.execute')
def test_unplug_infiniband_vif(self, mock_execute):
nova.privsep.libvirt.unplug_infiniband_vif('fabric', 'fakemac')
mock_execute.assert_called_with(
'ebrctl', 'del-port', 'fabric', 'fakemac')
@mock.patch('oslo_concurrency.processutils.execute')
def test_plug_midonet_vif(self, mock_execute):
nova.privsep.libvirt.plug_midonet_vif('portid', 'dev')
mock_execute.assert_called_with(
'mm-ctl', '--bind-port', 'portid', 'dev')
@mock.patch('oslo_concurrency.processutils.execute')
def test_unplug_midonet_vif(self, mock_execute):
nova.privsep.libvirt.unplug_midonet_vif('portid')
mock_execute.assert_called_with(
'mm-ctl', '--unbind-port', 'portid')
@mock.patch('oslo_concurrency.processutils.execute')
def test_plug_plumgrid_vif(self, mock_execute):
nova.privsep.libvirt.plug_plumgrid_vif(
'dev', 'iface', 'addr', 'netid', 'tenantid')
mock_execute.assert_has_calls(
[
mock.call('ifc_ctl', 'gateway', 'add_port', 'dev'),
mock.call('ifc_ctl', 'gateway', 'ifup', 'dev',
'access_vm', 'iface', 'addr',
'pgtag2=netid', 'pgtag1=tenantid')
])
@mock.patch('oslo_concurrency.processutils.execute')
def test_unplug_plumgrid_vif(self, mock_execute):
nova.privsep.libvirt.unplug_plumgrid_vif('dev')
mock_execute.assert_has_calls(
[
mock.call('ifc_ctl', 'gateway', 'ifdown', 'dev'),
mock.call('ifc_ctl', 'gateway', 'del_port', 'dev')
])
def test_readpty(self):
# Conditionally mock `import`
orig_import = __import__
mock_fcntl = mock.Mock(fcntl=mock.Mock(return_value=32769))
def fake_import(module, *args):
if module == 'fcntl':
return mock_fcntl
return orig_import(module, *args)
with test.nested(
mock.patch('builtins.open', new=mock.mock_open()),
mock.patch('builtins.__import__', side_effect=fake_import),
) as (mock_open, mock_import):
nova.privsep.libvirt.readpty('/fake/path')
mock_fileno = mock_open.return_value.fileno.return_value
# NOTE(efried): The fact that we see fcntl's mocked return value in
# here proves that `import fcntl` was called within the method.
mock_fcntl.fcntl.assert_has_calls(
[mock.call(mock_fileno, mock_fcntl.F_GETFL),
mock.call(mock_fileno,
mock_fcntl.F_SETFL, 32769 | os.O_NONBLOCK)])
self.assertIn(mock.call('/fake/path', 'r'), mock_open.mock_calls)
def test_create_nmdev(self):
mock_open = mock.mock_open()
with mock.patch('builtins.open', new=mock_open) as mock_open:
nova.privsep.libvirt.create_mdev('phys', 'mdevtype',
uuid='fakeuuid')
handle = mock_open()
self.assertTrue(mock.call('/sys/class/mdev_bus/phys/'
'mdev_supported_types/mdevtype/create',
'w') in mock_open.mock_calls)
handle.write.assert_called_with('fakeuuid')
@mock.patch('oslo_concurrency.processutils.execute')
def test_umount(self, mock_execute):
nova.privsep.libvirt.umount('/fake/path')
mock_execute.assert_called_with('umount', '/fake/path')
@mock.patch('oslo_concurrency.processutils.execute')
def test_unprivileged_umount(self, mock_execute):
nova.privsep.libvirt.unprivileged_umount('/fake/path')
mock_execute.assert_called_with('umount', '/fake/path')
@ddt.ddt
class PrivsepLibvirtMountTestCase(test.NoDBTestCase):
QB_BINARY = "mount.quobyte"
QB_FIXED_OPT_1 = "--disable-xattrs"
FAKE_VOLUME = "fake_volume"
FAKE_MOUNT_BASE = "/fake/mount/base"
def setUp(self):
super(PrivsepLibvirtMountTestCase, self).setUp()
self.useFixture(test.nova_fixtures.PrivsepFixture())
@ddt.data(None, "/FAKE/CFG/PATH.cfg")
@mock.patch('oslo_concurrency.processutils.execute')
def test_systemd_run_qb_mount(self, cfg_file, mock_execute):
sysd_bin = "systemd-run"
sysd_opt_1 = "--scope"
nova.privsep.libvirt.systemd_run_qb_mount(
self.FAKE_VOLUME, self.FAKE_MOUNT_BASE, cfg_file=cfg_file)
if cfg_file:
mock_execute.assert_called_once_with(sysd_bin, sysd_opt_1,
self.QB_BINARY,
self.QB_FIXED_OPT_1,
self.FAKE_VOLUME,
self.FAKE_MOUNT_BASE,
"-c",
cfg_file)
else:
mock_execute.assert_called_once_with(sysd_bin, sysd_opt_1,
self.QB_BINARY,
self.QB_FIXED_OPT_1,
self.FAKE_VOLUME,
self.FAKE_MOUNT_BASE)
@ddt.data(None, "/FAKE/CFG/PATH.cfg")
@mock.patch('oslo_concurrency.processutils.execute')
def test_unprivileged_qb_mount(self, cfg_file, mock_execute):
nova.privsep.libvirt.unprivileged_qb_mount(self.FAKE_VOLUME,
self.FAKE_MOUNT_BASE,
cfg_file=cfg_file)
if cfg_file:
mock_execute.assert_called_once_with(self.QB_BINARY,
self.QB_FIXED_OPT_1,
self.FAKE_VOLUME,
self.FAKE_MOUNT_BASE,
"-c",
cfg_file)
else:
mock_execute.assert_called_once_with(self.QB_BINARY,
self.QB_FIXED_OPT_1,
self.FAKE_VOLUME,
self.FAKE_MOUNT_BASE)
|
