diff options
| author | blue55 <yllan@fiberhome.com> | 2017-06-06 09:50:44 +0800 |
|---|---|---|
| committer | blue55 <yllan@fiberhome.com> | 2017-06-06 15:18:24 +0800 |
| commit | 5da6884dbc169ad8daff64b4ab7abab27de4a195 (patch) | |
| tree | ffb13ffcfeb9886ea40db091bf6fd5be985c6f67 | |
| parent | 516bb61947720ad7f9bcdea931a295b205bdeffb (diff) | |
| download | oslo-db-5da6884dbc169ad8daff64b4ab7abab27de4a195.tar.gz | |
Using assertIsNone(xxx) instead of assertEqual(None, xxx)
Following OpenStack Style Guidelines:
[1] https://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific
assertions. As a result, assertIsNone(xxx) is preferred over
assertEqual(None, xxx) and assertIs(xxx, None)
Change-Id: Id0e54ddeb461e56fbc8ec3a4bbc8a581f11430df
| -rw-r--r-- | oslo_db/tests/sqlalchemy/test_models.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/oslo_db/tests/sqlalchemy/test_models.py b/oslo_db/tests/sqlalchemy/test_models.py index 893d96f..0b0f6d8 100644 --- a/oslo_db/tests/sqlalchemy/test_models.py +++ b/oslo_db/tests/sqlalchemy/test_models.py @@ -211,7 +211,7 @@ class SoftDeleteMixinTest(test_base.DbTestCase): self.session.add(m) self.session.commit() self.assertEqual(0, m.deleted) - self.assertIs(None, m.deleted_at) + self.assertIsNone(m.deleted_at) m.soft_delete(self.session) self.assertEqual(123456, m.deleted) |