diff options
author | Mehdi Abaakouk <sileht@sileht.net> | 2017-09-12 11:52:35 +0200 |
---|---|---|
committer | Mehdi Abaakouk <sileht@sileht.net> | 2017-09-12 14:42:53 +0200 |
commit | 3a40168056b85de0e53b69dc6ff52bddb4cdd7a7 (patch) | |
tree | 52c5c177d2c6fbc302a9ab2a31bc5461aeb4fb11 /oslo_db/sqlalchemy/utils.py | |
parent | 46fb5ac034ccdd9d34e31fc13e6e18ac95094d4b (diff) | |
download | oslo-db-3a40168056b85de0e53b69dc6ff52bddb4cdd7a7.tar.gz |
Fix pagination when marker value is None
The change b3869d04cff7071c1226758eb8b58fde9eba5b8d was fixing #1615938
only for some cases, where the unicity of the row was done by one
column.
This change fixes it for other cases.
Change-Id: I4acb382c770b168f29fa35f02707fb22d402b13b
Closes-bug: #1615938
Diffstat (limited to 'oslo_db/sqlalchemy/utils.py')
-rw-r--r-- | oslo_db/sqlalchemy/utils.py | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/oslo_db/sqlalchemy/utils.py b/oslo_db/sqlalchemy/utils.py index 4961a70..4bd8a0e 100644 --- a/oslo_db/sqlalchemy/utils.py +++ b/oslo_db/sqlalchemy/utils.py @@ -238,7 +238,8 @@ def paginate_query(query, model, limit, sort_keys, marker=None, if marker_values[i] is not None: for j in range(i): model_attr = getattr(model, sort_keys[j]) - crit_attrs.append((model_attr == marker_values[j])) + if marker_values[j] is not None: + crit_attrs.append((model_attr == marker_values[j])) model_attr = getattr(model, sort_keys[i]) val = marker_values[i] @@ -247,9 +248,16 @@ def paginate_query(query, model, limit, sort_keys, marker=None, val = int(val) model_attr = cast(model_attr, Integer) if sort_dirs[i].startswith('desc'): - crit_attrs.append((model_attr < val)) + crit_attr = (model_attr < val) + if sort_dirs[i].endswith('nullsfirst'): + crit_attr = sqlalchemy.sql.or_(crit_attr, + model_attr.is_(None)) else: - crit_attrs.append((model_attr > val)) + crit_attr = (model_attr > val) + if sort_dirs[i].endswith('nullslast'): + crit_attr = sqlalchemy.sql.or_(crit_attr, + model_attr.is_(None)) + crit_attrs.append(crit_attr) criteria = sqlalchemy.sql.and_(*crit_attrs) criteria_list.append(criteria) |