diff options
author | Ayumu Ueha <ueha.ayumu@fujitsu.com> | 2023-01-17 08:57:20 +0000 |
---|---|---|
committer | Ayumu Ueha <ueha.ayumu@fujitsu.com> | 2023-01-18 00:31:22 +0000 |
commit | b689b6320cdb7dbbb366bf35f23083814f5e79ec (patch) | |
tree | 557b4b59821e3135290d1173b6872b945b49686b /oslo_db/tests/sqlalchemy | |
parent | 32b042e7069f90c61548d73e3460ab8e0f6990c7 (diff) | |
download | oslo-db-b689b6320cdb7dbbb366bf35f23083814f5e79ec.tar.gz |
Fix default value for wsrep_sync_wait option12.3.1
The default value for wsrep_sync_wait option should be `None`.
However, since 0 is set incorrectly, an unintended process is executed.
This patch fixes default value for wsrep_sync_wait option to `None`
instead of `0`.
Change-Id: Ifb1dc7ddcb127a69ea01234922caa7ca5ab111ce
Diffstat (limited to 'oslo_db/tests/sqlalchemy')
-rw-r--r-- | oslo_db/tests/sqlalchemy/test_enginefacade.py | 13 | ||||
-rw-r--r-- | oslo_db/tests/sqlalchemy/test_options.py | 1 |
2 files changed, 14 insertions, 0 deletions
diff --git a/oslo_db/tests/sqlalchemy/test_enginefacade.py b/oslo_db/tests/sqlalchemy/test_enginefacade.py index bdf5104..4175880 100644 --- a/oslo_db/tests/sqlalchemy/test_enginefacade.py +++ b/oslo_db/tests/sqlalchemy/test_enginefacade.py @@ -1379,6 +1379,19 @@ class PatchFactoryTest(test_base.BaseTestCase): self.assertTrue(engine_args['sqlite_fk']) self.assertEqual("FOOBAR", engine_args["mysql_sql_mode"]) self.assertEqual(38, engine_args["max_overflow"]) + self.assertNotIn("mysql_wsrep_sync_wait", engine_args) + + def test_new_manager_from_options(self): + """test enginefacade's defaults given a default structure from opts""" + + factory = enginefacade._TransactionFactory() + cfg.CONF.register_opts(options.database_opts, 'database') + factory.configure(**dict(cfg.CONF.database.items())) + engine_args = factory._engine_args_for_conf(None) + + self.assertEqual(None, engine_args["mysql_wsrep_sync_wait"]) + self.assertEqual(True, engine_args["sqlite_synchronous"]) + self.assertEqual("TRADITIONAL", engine_args["mysql_sql_mode"]) class SynchronousReaderWSlaveMockFacadeTest(MockFacadeTest): diff --git a/oslo_db/tests/sqlalchemy/test_options.py b/oslo_db/tests/sqlalchemy/test_options.py index 54c4ada..c045e4d 100644 --- a/oslo_db/tests/sqlalchemy/test_options.py +++ b/oslo_db/tests/sqlalchemy/test_options.py @@ -110,3 +110,4 @@ pool_timeout=7 self.assertTrue(len(conf.database.items()) > 1) self.assertEqual('sqlite:///:memory:', conf.database.connection) + self.assertEqual(None, self.conf.database.mysql_wsrep_sync_wait) |