diff options
| author | John Eckersberg <jeckersb@redhat.com> | 2021-08-04 14:57:30 -0400 |
|---|---|---|
| committer | John Eckersberg <jeckersb@redhat.com> | 2021-08-10 17:01:04 -0400 |
| commit | f9de265f392dca5386491120593d57b124342c5f (patch) | |
| tree | 27de4a59f7e9698385adc5f62419611679c7e458 /oslo_messaging/_drivers/impl_rabbit.py | |
| parent | 01f5b3787494f0402c22c9e1fe78d293154dac6a (diff) | |
| download | oslo-messaging-f9de265f392dca5386491120593d57b124342c5f.tar.gz | |
amqp1: Do not reuse _socket_connection on reconnect12.9.1
Each _SocketConnection object is unique per-peer. For example, the
properties attribute may contain keys such as 'x-ssl-peer-name'.
Reusing the existing _socket_connection during failover will cause the
TLS handshake to fail since the peer name will not match. There is
potential for other similar-yet-unexplored bad things to happen as
well.
Instead, reconnect by waking up the eventloop via the _do_reconnect
method, which reconstructs the connection properties to reflect the
new (failed-over-to) host and ultimately crates a new
_SocketConnection (or re-uses a *valid* old one) in
eventloop.Thread.connect().
Closes-Bug: #1938945
Change-Id: I0c8dc447f4dc8d0d08c312a1f3e6fa1745fb69fd
Diffstat (limited to 'oslo_messaging/_drivers/impl_rabbit.py')
0 files changed, 0 insertions, 0 deletions