diff options
| author | Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com> | 2022-07-11 10:58:32 +0200 |
|---|---|---|
| committer | Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com> | 2022-08-03 17:35:16 +0200 |
| commit | 43f2224aacb668aa51de3d1274ff8939d8aa73ae (patch) | |
| tree | 5a941a264e73c1a8b0a3b858a5b337cef875c3ae /releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml | |
| parent | 41863867489c8a84823f2b3d73cab5585f1fb4ae (diff) | |
| download | oslo-messaging-43f2224aacb668aa51de3d1274ff8939d8aa73ae.tar.gz | |
Remove logging from ProducerConnection._produce_message
In impl_kafka, _produce_message is run in a tpool.execute
context but it was also calling logging functions.
This could cause subsequent calls to logging functions to
deadlock.
This patch moves the logging calls out of the tpool.execute scope.
Change-Id: I81167eea0a6b1a43a88baa3bc383af684f4b1345
Closes-bug: #1981093
Diffstat (limited to 'releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml')
| -rw-r--r-- | releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml b/releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml new file mode 100644 index 0000000..1103247 --- /dev/null +++ b/releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml @@ -0,0 +1,8 @@ +--- +fixes: + - | + [`bug 1981093 <https://bugs.launchpad.net/oslo.messaging/+bug/1981093>`_] + Pulls calls to logging functions out of ``impl_kafka._produce_message``. + Since ``_produce_message`` is called through tpool.execute, calling logging + functions inside ``_produce_message`` could cause subsequent calls to + logging functions to deadlock. |