summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Update functional jobs for 2023.2"HEADmasterZuul2023-05-151-11/+11
|\
| * Update functional jobs for 2023.2Brian Rosmaita2023-04-171-11/+11
| | | | | | | | | | | | | | | | | | Based on the python runtimes for 2023.2 [0], we should be running functional jobs on python 3.9 and python 3.10. [0] https://governance.openstack.org/tc/reference/runtimes/2023.2.html Change-Id: Ifc7dc6588af420aa56cd862dd9f558a4506eb1a0
* | Merge "Use tox 4"Zuul2023-05-051-14/+15
|\ \ | |/
| * Use tox 4Brian Rosmaita2023-04-171-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: - eliminate whitespace in passenv values - removed skipsdist=True, which in tox 4 appears to prevent os-brick from being installed in the testenvs - made 4.4.1 the tox minversion to catch relevant bugfixes; since tox is not constrained, we'll actually be using the most recent version of tox 4 - had to adjust the functional testenv's setenv, which wasn't overriding OS_TEST_PATH like it did with tox 3 - used generative section names to define the various functional py3 testenvs we want to support locally (namely, py38, py39, py310, and py311) This patch makes tox 4 the default so that we can hopefully catch problems locally before they block the gate. Change-Id: I01c4d44efa64650cdb46fac34a770a7aa5881baf
* | Remove USE_PYTHON3 setting from .zuul.yamlEric Harney2023-03-091-1/+0
|/ | | | | | | We don't need this anymore since all of our jobs are Python 3. Change-Id: Ib7e85a72a28ff507cb1371b365b6bfa5fbf70d81
* Add Python 3.10 to setup.cfg metadataEric Harney2023-03-091-0/+1
| | | | | | We support 3.10 as of Antelope. Change-Id: Ia32f0488f4fe90527b1fbd0cb663e33e8537a458
* Update master for stable/2023.1OpenStack Release Bot2023-02-242-0/+7
| | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/2023.1. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/2023.1. Sem-Ver: feature Change-Id: I4d6270b745e171516de982102dbc6e5d9010da19
* Merge "Update minimum requirements"9.3.0Zuul2023-02-131-1/+1
|\
| * Update minimum requirementsRajat Dhasmana2023-02-131-1/+1
| | | | | | | | | | | | | | | | | | | | This patch updates keystoneauth1 minimum version. The current used version 4.3.1 was released in 22 Feb, 2021 which is ~2 years old. Updating the version to 5.0.0 released in 15 July, 2022 and upper-constraints have 5.1.1 released on 3 Jan, 2023. Change-Id: If8a958345ae62006b8e6221a60ff3217e31823ac
* | Merge "Add test coverage for shell snapshot-create w/ metadata"Zuul2023-02-131-0/+18
|\ \
| * | Add test coverage for shell snapshot-create w/ metadataEric Harney2022-11-171-0/+18
| | | | | | | | | | | | | | | | | | This path is not currently unit tested. Change-Id: If38c6352f5e1f0a50e4a0d29fbdd5263ccba3b29
* | | Merge "Add support for collect-timing option"Zuul2023-02-132-0/+23
|\ \ \ | |_|/ |/| |
| * | Add support for collect-timing optionGorka Eguileor2022-02-092-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we run "cinder help" we can see that there is a --collect-timing option: --collect-timing Collect per-API call timing information. This is a keystone session option that we are not currently acting on from a user perspective. This patch adds support for this option, and we'll be able to see the timing in a similar way as we do with OSC: $ cinder --collect-timing api-version +------+---------+---------+-------------+ | ID | Status | Version | Min_version | +------+---------+---------+-------------+ | v3.0 | CURRENT | 3.66 | 3.0 | +------+---------+---------+-------------+ +--------+------------------------------------------------+----------+ | method | url | seconds | +--------+------------------------------------------------+----------+ | GET | http://192.168.121.243/identity | 0.003591 | | POST | http://192.168.121.243/identity/v3/auth/tokens | 0.016649 | | GET | http://192.168.121.243/volume/ | 0.004012 | | GET | http://192.168.121.243/volume/ | 0.004543 | +--------+------------------------------------------------+----------+ The patch formats the "elapsed" time attribute into seconds and renames the column to "seconds" to make it more user friendly similar to OSC. If we didn't it would look like 0:00:00.003744 Closes-Bug: #1960337 Change-Id: Ia6b31794bf60a351007cc4476a76b9bcb76bf378
* | | Merge "remove simplejson requirement"Zuul2023-02-102-6/+1
|\ \ \
| * | | remove simplejson requirementEric Harney2023-01-262-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The json lib has been included in CPython for ages, so the ImportError case never happens. Change-Id: I669bc397323a0e83d4a9768b124a7d99bafaf38a
* | | | Merge "Move print operations to shell_utils"Zuul2023-01-268-229/+231
|\ \ \ \ | |/ / / |/| | |
| * | | Move print operations to shell_utilsEric Harney2022-11-158-229/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move more code to shell_utils that is only used for shell operations. The benefit of this is that the cinderclient library becomes lighter-weight, because users of the lib no longer have to import prettytable and extra code. Change-Id: I7bf6bd91ee5746d1ad4bd4504f3a056d03ae86a9
* | | | Continue using tox 3Brian Rosmaita2023-01-182-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the classic cinderclient tox.ini that has worked so well in the past with tox 3; only change is to add the tox<4 requires statement. Also adjust .zuul.yaml to express our preference for tox<4 in the case that zuul has to install tox. Change-Id: Ib1f55f9431033ad043507c6f751ee9bfe57d5cbb
* | | | Python3.11: fix crashes in ShellTestCyril Roelandt2022-12-211-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Python3.11, global flags must be placed right at the start of a regular expression. The following regex: r'.*?(?m)^Lists all volumes.', must become: r'(?m).*?^Lists all volumes.', However, since we are using re.MULTILINE, we actually do not need to use a global flag. This commit fixes the following tests in Python3.11: - cinderclient.tests.unit.test_shell.ShellTest.test_help_arg_no_subcommand - cinderclient.tests.unit.test_shell.ShellTest.test_help - cinderclient.tests.unit.test_shell.ShellTest.test_help_on_subcommand - cinderclient.tests.unit.test_shell.ShellTest.test_help_on_subcommand_mv Closes-Bug: #1983047 Change-Id: If20abef109ddd7107c83b5886beb666a6550a640
* | | | Merge "Python3.11: Fix argparse-related test failures"Zuul2022-12-121-4/+13
|\ \ \ \
| * | | | Python3.11: Fix argparse-related test failuresCyril Roelandt2022-07-281-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Python3.11, the following code crashes: $ cat test.py import argparse parser = argparse.ArgumentParser(description='Short sample app') subparsers = parser.add_subparsers() subparsers.add_parser('foo') subparsers.add_parser('foo') $ python3.11 test.py Traceback (most recent call last): File "/tmp/arg.py", line 6, in <module> subparsers.add_parser('foo') File "/usr/lib/python3.11/argparse.py", line 1197, in add_parser raise ArgumentError(self, _('conflicting subparser: %s') % name) argparse.ArgumentError: argument {foo}: conflicting subparser: foo It is now forbidden to use add_parser() multiple times with the same arguments, which is exactly what we do in the following tests: - cinderclient.tests.unit.test_shell.TestLoadVersionedActions.test_load_versioned_actions - cinderclient.tests.unit.test_shell.TestLoadVersionedActions.test_load_actions_with_versioned_args In order to fix the tests failures, we make sure to reset the parser and subparsers before calling add_parser(). While not strictly necessary, we split those tests into two functions, for readability purposes. Closes-Bug: #1983054 Change-Id: I2d4cb81a394f3c10e5f01945d894746a904fb5df
* | | | | Merge "Remove python-dev from bindep"Zuul2022-11-181-2/+0
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Remove python-dev from bindepHervé Beraud2022-11-071-2/+0
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is no longer supported by jammy and lead us to the following errors with the announce-release job. ``` No package matching 'python-dev' is available ``` Change-Id: I12a31b044d5f88a26984d13adff08dd9c778fe0c
* | | | Handle downgraded client for snapshot-create9.2.0Brian Rosmaita2022-11-084-0/+100
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a CLI user specifies --os-volume api-version 3.66, the shell will execute the appropriate shell code, but if the server only supports < 3.66, the client is automatically downgraded and correctly uses the pre-3.66 SnapshotManager.create() method. In that case, the 'force' parameter, which is technically not allowed in mv 3.66 (but which silently accepts a True value for backward compatibility), will have a value of None, which the pre-3.66 code happily passes to cinder as '"force": null' in the request body, and which then fails the Block Storage API request-schema check. Handle this situation by detecting a None 'force' value and setting it to its pre-3.66 default value of False. Change-Id: I3ad8283c2a9aaac58c8d2b50fa7ac86b617e5dd3 Closes-bug: #1995883
* | | Add Python3 antelope unit testsOpenStack Release Bot2022-09-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for antelope. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: If67262fe0f9269e5cb25ebb365e78ebc6cbb3b70
* | | Update bindep for ubuntu jammyBrian Rosmaita2022-09-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Python 3.10 unit tests are failing on jammy because the 'python-dev' package is not available on that platform. See py310 failures on https://review.opendev.org/c/openstack/python-cinderclient/+/856719/1 Change-Id: I01501b9dac831c71ac62a2cc624dc0c4933c9c15
* | | Update master for stable/zedOpenStack Release Bot2022-09-092-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/zed. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/zed. Sem-Ver: feature Change-Id: I593949dae5dd2faf94a639ced8feca80323329f5
* | | Bump API max version to 3.709.1.0Alan Bishop2022-08-091-1/+1
|/ / | | | | | | | | | | | | | | | | | | Bump MAX_VERSION to 3.70 to support the following: - 3.69 - Allow null value for shared_targets - 3.70 - Support encrypted volume transfers Implements: bp/transfer-encrypted-volume Depends-On: I459f06504e90025c9c0b539981d3d56a2a9394c7 Change-Id: I11072d6d8a185037c7f4cdd52c45933b0cccaf05
* | Fix extension loading from python pathzack chen2022-06-291-0/+2
| | | | | | | | | | | | | | | | | | Commit 3502a5591a654ae57741c6738994ffa9d8457696 broke extension loading from pythonpath. Incompatible on python3.6.8, python3.8, python3.9. Put it back. Closes-Bug: #1980184 Change-Id: I5b67c93e3c789252d9bd35ee69dddbe1b556dec4
* | Update python testing as per zed cycle testing runtime9.0.0Ghanshyam Mann2022-05-194-12/+16
| | | | | | | | | | | | | | | | | | | | | | In Zed cycle, we have dropped the python 3.6/3.7[1] testing and its support. Moving the py36 job to py38 based but to run on ubuntu focal as c8s does not seems to have py38. Also updating the python classifier also to reflect the same. [1] https://governance.openstack.org/tc/reference/runtimes/zed.html Change-Id: Ic26a360d2bb09fa6622d1acaa5021c5afbc70240
* | Update master for stable/yogaOpenStack Release Bot2022-02-252-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/yoga. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/yoga. Sem-Ver: feature Change-Id: I96aa28bd09724d3f14935e1dbf13f7e791261ccb
* | Prepare for Yoga cinderclient release8.3.0Brian Rosmaita2022-02-241-0/+5
| | | | | | | | | | | | Add a release note prelude for the Yoga release. Change-Id: Id601999762596713c94e7805a7d76dbcf31edf24
* | Merge "Add volume reimage command"Zuul2022-02-248-1/+84
|\ \
| * | Add volume reimage commandwhoami-rajat2022-02-248-1/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A new reimage API will be introduced on cinder API side with change in depends on. This patch provides the CLI support for the same by adding a reimage command. Implements: blueprint add-volume-re-image-api Change-Id: I37c254d4caf2f416e456ff6a78b5a4df4e08a176
* | | Move tempest requirement to functional envEric Harney2022-02-172-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | We don't need to track this in test-reqs for unit tests, etc. since it's only used for functional tests. Change-Id: I2e9a55d0f4530e9f3fd0f6c1c48cf5ee19c841da
* | | Merge "Add Python 3 only classifier"Zuul2022-02-111-0/+1
|\ \ \ | |_|/ |/| |
| * | Add Python 3 only classifierTakashi Kajinami2022-02-081-0/+1
| |/ | | | | | | | | | | | | | | | | | | Python 2 support was removed during Ussuri cycle. This change adds the classifier to clearly state that only Python 3 is supported. This allows us to keep the setup.cfg file in cinder and the one in cinderclient more consistent. Change-Id: I5ad342f2b60348a0ba79c95415fdf1ae39714558
* | Updating python testing as per Yoga testing runtimetushargite962021-12-153-11/+8
|/ | | | | | | | | | | | | | | | Yoga testing runtime[1] has been updated to add py39 testing as voting and as we are testing py3.6 and py3.9 we do not need to test py3.7|8 explicitly. Unit tests update are handled by the job template change in openstack-zuul-job - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286 this commit makes other required changes in zuul.yaml and update the classifier in setup.cfg file. [1] https://governance.openstack.org/tc/reference/runtimes/yoga.html Change-Id: Ib5b93ca7863fcc0b6d00fb4d52a5f299d1903056
* Merge "Improve help text of volume create command"Zuul2021-11-192-2/+11
|\
| * Improve help text of volume create commandwhoami-rajat2021-11-082-2/+11
| | | | | | | | | | | | | | | | | | This patch adds information about whichever default type is set for API will be used during volume creation if we don't provide a volume type in volume create command. This patch also improves the help text of `cinder type-default` command. Change-Id: I0c437b2c4f02c12d17c04719cbeff8521647ae15
* | Merge "Correct "Increase default quotas for zuul jobs""8.2.0Zuul2021-11-091-5/+3
|\ \ | |/ |/|
| * Correct "Increase default quotas for zuul jobs"Brian Rosmaita2021-09-231-5/+3
| | | | | | | | | | | | | | | | | | | | | | It turns out that you can't use the devstack post_config phase for this because it happens too late. The quota settings must be made to cinder.conf before cinder-manage db_sync is called where they're used to set the max limit for the tables used by the db quotas driver. Depends-on: https://review.opendev.org/c/openstack/devstack/+/803521 Change-Id: I3bb7d9f9bede063573b24fb5a33a364c53d52434
* | Merge "Remove the unused tool scripts"Zuul2021-10-153-252/+0
|\ \ | |/ |/|
| * Remove the unused tool scriptsdengzhaosen2021-08-263-252/+0
| | | | | | | | | | | | | | We support Python 3.6 as a minimum now, making these checks no-ops. These file is unused in current project and remove them. Change-Id: Ie5cbd9653375deeb523190d9c499f0c89c035d2e
* | Merge "Add W503 to flake8 ignores"Zuul2021-09-151-1/+1
|\ \
| * | Add W503 to flake8 ignoresBrian Rosmaita2021-09-021-1/+1
| | | | | | | | | | | | | | | | | | | | | Cinder ignores both W503 and W504, and it's really annoying that cinderclient is not consistent with cinder about this. Change-Id: Iab7ff2bfcb61fd5d8a7ee25e245cebe7a50c46b1
* | | Add Python3 yoga unit testsOpenStack Release Bot2021-09-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for yoga. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Ie02a19f3bd51825ee3a4b122ef265eb2b3752a8a
* | | Update master for stable/xenaOpenStack Release Bot2021-09-032-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/xena. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/xena. Sem-Ver: feature Change-Id: I1a2ed0695125b5d0733299f3efd263fe61868ee7
* | | Prepare for Xena cinderclient releasexena-em8.1.0Brian Rosmaita2021-09-021-0/+21
| | | | | | | | | | | | | | | | | | Includes prelude plus a note for change I524490aa988f. Change-Id: I233faad57c9708cae9544c965fd0d94abdf6d684
* | | Support Block Storage API mv 3.66Brian Rosmaita2021-09-026-57/+254
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Block Storage API mv 3.66 enables snapshots of in-use volumes without requiring a 'force' flag. For backward compatibility, the API silently accepts force=true, even though the 'force' flag is considered invalid for that call. That behavior is replicated in the client, where --force with a true value is silently accepted. The --force option is not advertised in the shell and an option value that doesn't evaluate to true raises an UnsupportedAttribute error. Similar behavior from the v3 Snapshot class, except it raises a ValueError under similar circumstances. Change-Id: I7408d0e3a5ed7f4cbcaf65cf3434ad60aaed511d