pass on @abc.abstractmethods

Although a bare docstring is entirely valid grammar, those new to Python find
that pattern baffling, *especially* when other similar methods contain pass
statements. So, for consistency, add a pass statement to otherwise bare
@abc.abstractmethods.

Note that the implementation of an @abc.abstractmethod (in the abstract
base class) can still be called by concrete children, so suddenly
raising a NotImplementedError() instead might be "surprising" to
implementors. A no-op such as "pass" or "return None" is preferable.

Change-Id: I79969ad1a3429516ea785c649a165ead54944225

3 files changed, 3 insertions, 0 deletions

diff --git a/keystoneclient/auth/identity/base.py b/keystoneclient/auth/identity/base.py
index 02c4fe6..bf7fc72 100644
--- a/keystoneclient/auth/identity/base.py
+++ b/keystoneclient/auth/identity/base.py
@@ -184,6 +184,7 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
         :returns: Token access information.
         :rtype: :py:class:`keystoneclient.access.AccessInfo`
         """
+        pass
 
     def get_token(self, session, **kwargs):
         """Return a valid auth token.
diff --git a/keystoneclient/auth/identity/v2.py b/keystoneclient/auth/identity/v2.py
index fd8b422..3b98eff 100644
--- a/keystoneclient/auth/identity/v2.py
+++ b/keystoneclient/auth/identity/v2.py
@@ -103,6 +103,7 @@ class Auth(base.BaseIdentityPlugin):
         :return: A dict of authentication data for the auth type.
         :rtype: dict
         """
+        pass
 
 
 _NOT_PASSED = object()
diff --git a/keystoneclient/auth/identity/v3/base.py b/keystoneclient/auth/identity/v3/base.py
index b8234a3..a38cd8c 100644
--- a/keystoneclient/auth/identity/v3/base.py
+++ b/keystoneclient/auth/identity/v3/base.py
@@ -240,6 +240,7 @@ class AuthMethod(object):
                  data for the auth type.
         :rtype: tuple(string, dict)
         """
+        pass
 
 
 @six.add_metaclass(abc.ABCMeta)