diff options
author | Arthur Miranda <artmr@lsd.ufcg.edu.br> | 2016-10-21 12:18:23 -0300 |
---|---|---|
committer | Arthur Miranda <artmr@lsd.ufcg.edu.br> | 2016-10-21 14:00:46 -0300 |
commit | 316058d314d8f63e913d11b073498ca6283b728b (patch) | |
tree | ef9152468913450bb4834968aaec07f0bcf6cdb9 /keystoneclient/base.py | |
parent | 0f7b2436155ad3f37284ffc42ae482c93331a59a (diff) | |
download | python-keystoneclient-316058d314d8f63e913d11b073498ca6283b728b.tar.gz |
Increase readability of 'find()' method and small improvements
Assigments replaced with argument assigment: endpoints.py, service_catalog.py
Note added: 'original_ip' value is never used: session.py
Refactor 'find()' method to increase readability: base.py
Change-Id: I469331b123fdf03e9e7c5d93e1c95da57d30fbbe
Diffstat (limited to 'keystoneclient/base.py')
-rw-r--r-- | keystoneclient/base.py | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/keystoneclient/base.py b/keystoneclient/base.py index 8bc4c82..f18c4a7 100644 --- a/keystoneclient/base.py +++ b/keystoneclient/base.py @@ -421,22 +421,22 @@ class CrudManager(Manager): url = self.build_url(dict_args_in_out=kwargs) query = self._build_query(kwargs) - rl = self._list( - '%(url)s%(query)s' % { - 'url': url, - 'query': query, - }, + url_query = '%(url)s%(query)s' % { + 'url': url, + 'query': query + } + elements = self._list( + url_query, self.collection_key) - num = len(rl) - if num == 0: + if not elements: msg = _("No %(name)s matching %(kwargs)s.") % { 'name': self.resource_class.__name__, 'kwargs': kwargs} raise ksa_exceptions.NotFound(404, msg) - elif num > 1: + elif len(elements) > 1: raise ksc_exceptions.NoUniqueMatch else: - return rl[0] + return elements[0] class Resource(object): |