diff options
| author | Dolph Mathews <dolph.mathews@gmail.com> | 2015-10-21 15:32:33 +0000 |
|---|---|---|
| committer | Dolph Mathews <dolph.mathews@gmail.com> | 2015-10-21 15:32:33 +0000 |
| commit | 574fad7abb328276396d7d4c2743982bb903078c (patch) | |
| tree | 20cd118762aadf3459ea2e245af0329ef0bd39ff /keystoneclient/service_catalog.py | |
| parent | 6588ad5fb5a3162aa2204ca38fb5a89a1f940985 (diff) | |
| download | python-keystoneclient-574fad7abb328276396d7d4c2743982bb903078c.tar.gz | |
pass on @abc.abstractmethods
Although a bare docstring is entirely valid grammar, those new to Python find
that pattern baffling, *especially* when other similar methods contain pass
statements. So, for consistency, add a pass statement to otherwise bare
@abc.abstractmethods.
Note that the implementation of an @abc.abstractmethod (in the abstract
base class) can still be called by concrete children, so suddenly
raising a NotImplementedError() instead might be "surprising" to
implementors. A no-op such as "pass" or "return None" is preferable.
Change-Id: I79969ad1a3429516ea785c649a165ead54944225
Diffstat (limited to 'keystoneclient/service_catalog.py')
| -rw-r--r-- | keystoneclient/service_catalog.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/keystoneclient/service_catalog.py b/keystoneclient/service_catalog.py index bb64689..d0a2719 100644 --- a/keystoneclient/service_catalog.py +++ b/keystoneclient/service_catalog.py @@ -110,6 +110,7 @@ class ServiceCatalog(object): :returns: True if the provided endpoint matches the required endpoint_type otherwise False. """ + pass @abc.abstractmethod def _normalize_endpoint_type(self, endpoint_type): @@ -122,6 +123,7 @@ class ServiceCatalog(object): :returns: the endpoint string in the format appropriate for this service catalog. """ + pass def get_endpoints(self, service_type=None, endpoint_type=None, region_name=None, service_name=None): |