diff options
| author | Vishakha Agarwal <agarwalvishakha18@gmail.com> | 2018-08-22 15:35:29 +0530 |
|---|---|---|
| committer | Vishakha Agarwal <agarwalvishakha18@gmail.com> | 2018-09-28 07:16:17 +0530 |
| commit | b7db5668c1223908987060a767078f010c83df6f (patch) | |
| tree | f7cd10f2e7e31cf4a0287d25f6e3341f4f5c7cba /keystoneclient | |
| parent | 793520804034f84bc1edaf2bc6f5e8c0638d69f5 (diff) | |
| download | python-keystoneclient-b7db5668c1223908987060a767078f010c83df6f.tar.gz | |
Deprecate region enabled parameter
We don't check for "enabled" in the region
anywhere thus deprecating it from the create()
and update calls of the v3/region.py. We dont
use it in schema [1] as well as [2].
[1] https://github.com/openstack/keystone/blob/master/keystone/catalog/schema.py#L34
[2] https://github.com/openstack/keystone/blob/master/keystone/catalog/backends/sql.py#L33-L49
Change-Id: I0257d5d42916e3b4d008e592d54eeeebec591633
Partial-Bug: #1615076
Diffstat (limited to 'keystoneclient')
| -rw-r--r-- | keystoneclient/tests/unit/v3/utils.py | 4 | ||||
| -rw-r--r-- | keystoneclient/v3/regions.py | 11 |
2 files changed, 15 insertions, 0 deletions
diff --git a/keystoneclient/tests/unit/v3/utils.py b/keystoneclient/tests/unit/v3/utils.py index d9cb5a4..5781a92 100644 --- a/keystoneclient/tests/unit/v3/utils.py +++ b/keystoneclient/tests/unit/v3/utils.py @@ -221,6 +221,8 @@ class CrudTests(object): self.assertRequestBodyIs(json=self.encode(entity)) def test_create(self, ref=None, req_ref=None): + deprecations = self.useFixture(client_fixtures.Deprecations()) + deprecations.expect_deprecations() ref = ref or self.new_ref() manager_ref = ref.copy() manager_ref.pop('id') @@ -343,6 +345,8 @@ class CrudTests(object): self.assertQueryStringIs('') def test_update(self, ref=None, req_ref=None): + deprecations = self.useFixture(client_fixtures.Deprecations()) + deprecations.expect_deprecations() ref = ref or self.new_ref() self.stub_entity('PATCH', id=ref['id'], entity=ref) diff --git a/keystoneclient/v3/regions.py b/keystoneclient/v3/regions.py index 7783b3f..0538a66 100644 --- a/keystoneclient/v3/regions.py +++ b/keystoneclient/v3/regions.py @@ -10,6 +10,7 @@ # License for the specific language governing permissions and limitations # under the License. +from debtcollector import removals from keystoneclient import base @@ -34,6 +35,11 @@ class RegionManager(base.CrudManager): collection_key = 'regions' key = 'region' + @removals.removed_kwarg( + 'enabled', + message='The enabled parameter is deprecated.', + version='3.18.0', + removal_version='4.0.0') def create(self, id=None, description=None, enabled=True, parent_region=None, **kwargs): """Create a region. @@ -81,6 +87,11 @@ class RegionManager(base.CrudManager): return super(RegionManager, self).list( **kwargs) + @removals.removed_kwarg( + 'enabled', + message='The enabled parameter is deprecated.', + version='3.18.0', + removal_version='4.0.0') def update(self, region, description=None, enabled=None, parent_region=None, **kwargs): """Update a region. |