diff options
| author | Andrey Kurilin <andr.kurilin@gmail.com> | 2017-12-15 18:24:53 +0200 |
|---|---|---|
| committer | Stephen Finucane <stephenfin@redhat.com> | 2018-02-09 15:26:08 +0000 |
| commit | ca27736810a41080761e604e09c6763aaed07ed7 (patch) | |
| tree | 8597094a2cba0c00b842eaa4cac7ebe6027de9a7 /releasenotes | |
| parent | beb90ec793dff9e55e67d4ebe80d3f87ec2f0dce (diff) | |
| download | python-novaclient-ca27736810a41080761e604e09c6763aaed07ed7.tar.gz | |
Remove 2 redundant methods
I suppose that methods get_resource_manager_extra_kwargs and
add_resource_manager_extra_kwargs_hook were designed in those days when
Nova API had extensions.
Nowdays, Nova API has strict schema validation of requests, so no
additional arguments are allowed and these methods look redundant.
The fact that get_resource_manager_extra_kwargs lists of the objects
added by add_resource_manager_extra_kwargs_hook whereas
add_resource_manager_extra_kwargs_hook is not called anywhere
doesn't add chances for leaving these methods in our code.
Compatibility: both methods are designed for CLI and the CLI behaviour
will not change after removing them, so we can do a cleanup without
following standard deprecation cycle.
Change-Id: Id61457c3db8a17e2294dc579b2519873927fec48
Diffstat (limited to 'releasenotes')
| -rw-r--r-- | releasenotes/notes/get-rid-off-redundant-methods-47e679c13e88f28a.yaml | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/releasenotes/notes/get-rid-off-redundant-methods-47e679c13e88f28a.yaml b/releasenotes/notes/get-rid-off-redundant-methods-47e679c13e88f28a.yaml new file mode 100644 index 00000000..954ae395 --- /dev/null +++ b/releasenotes/notes/get-rid-off-redundant-methods-47e679c13e88f28a.yaml @@ -0,0 +1,10 @@ +--- +deprecations: + - | + ``novaclient.utils.add_resource_manager_extra_kwargs_hook`` and + ``novaclient.utils.get_resource_manager_extra_kwargs`` were designed for + supporting extensions in nova/novaclient. Nowadays, this "extensions" + feature is abandoned and both ``add_resource_manager_extra_kwargs_hook``, + ``add_resource_manager_extra_kwargs_hook`` are not used in novaclient's + code. These methods are not documented, so we are removing them without + standard deprecation cycle. |