summaryrefslogtreecommitdiff
path: root/tests/unit/test_swiftclient.py
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2018-11-09 23:18:16 +0000
committerGerrit Code Review <review@openstack.org>2018-11-09 23:18:16 +0000
commit8778c91c71e83a40cfeedc4875ae3b66c7effb85 (patch)
treea604146934548364d77defa5bc12510e83285f51 /tests/unit/test_swiftclient.py
parent2d8836333b9b70cf794a60af4166fed71c375445 (diff)
parent411ef48e5bca1ed66a2e4dd7ecd8695e2bf6c94e (diff)
downloadpython-swiftclient-8778c91c71e83a40cfeedc4875ae3b66c7effb85.tar.gz
Merge "Stop leaking quite so many connections"
Diffstat (limited to 'tests/unit/test_swiftclient.py')
-rw-r--r--tests/unit/test_swiftclient.py8
1 files changed, 7 insertions, 1 deletions
diff --git a/tests/unit/test_swiftclient.py b/tests/unit/test_swiftclient.py
index f114774..62875a5 100644
--- a/tests/unit/test_swiftclient.py
+++ b/tests/unit/test_swiftclient.py
@@ -2532,6 +2532,9 @@ class TestConnection(MockHttpTest):
def read(self, *args, **kwargs):
return ''
+ def close(self):
+ pass
+
def local_http_connection(url, proxy=None, cacert=None,
insecure=False, cert=None, cert_key=None,
ssl_compression=True, timeout=None):
@@ -2901,6 +2904,9 @@ class TestCloseConnection(MockHttpTest):
self.assertIsNone(conn.http_conn)
conn.close()
self.assertIsNone(conn.http_conn)
+ # Can re-close
+ conn.close()
+ self.assertIsNone(conn.http_conn)
def test_close_ok(self):
url = 'http://www.test.com'
@@ -2911,7 +2917,7 @@ class TestCloseConnection(MockHttpTest):
self.assertEqual(len(conn.http_conn), 2)
http_conn_obj = conn.http_conn[1]
self.assertIsInstance(http_conn_obj, c.HTTPConnection)
- self.assertFalse(hasattr(http_conn_obj, 'close'))
+ self.assertTrue(hasattr(http_conn_obj, 'close'))
conn.close()