Added check to prevent adding argument without help string

Added addition check in add_argument() to ensure it has help
message is always present per Amrith's suggestion in this review:
https://review.openstack.org/#/c/261425/

Change-Id: Ic6486570d4beb138fdcd0c4e700ccc8d734d3e5e
Closes-Bug: #1530195

1 files changed, 6 insertions, 0 deletions

diff --git a/troveclient/shell.py b/troveclient/shell.py
index 1de4db8..cc7a00b 100644
--- a/troveclient/shell.py
+++ b/troveclient/shell.py
@@ -66,6 +66,12 @@ class TroveClientArgumentParser(argparse.ArgumentParser):
     def __init__(self, *args, **kwargs):
         super(TroveClientArgumentParser, self).__init__(*args, **kwargs)
 
+    def add_argument(self, *args, **kwargs):
+        if kwargs.get('help') is None:
+            raise Exception(_("An argument '%s' was specified without help.")
+                            % args[0])
+        super(TroveClientArgumentParser, self).add_argument(*args, **kwargs)
+
     def error(self, message):
         """error(message: string)