| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The abstract base classes previously defined in 'collections' were moved
to 'collections.abc' in 3.3. The aliases will be removed in 3.10.
Preempt this change now with a simple find-replace:
$ ag -l 'collections.($TYPES)' | \
xargs sed -i 's/\(collections\)\.\($TYPES\)/\1.abc.\2/g'
Where $TYPES is the list of moved ABCs from [1].
[1] https://docs.python.org/3/library/collections.abc.html
Credit for this commit message to Stephen Finucane <stephenfin@redhat.com>
Change-Id: I782f2449832398cf2cfb886f561635de3d8ac18d
|
|
|
|
|
|
|
|
|
| |
Story: 2008341
Task: 41242
This reverts commit 27cf71299ec51976fed8b18dbf5c0e4f9f4fd6f5.
Change-Id: I036a0423263b1a0332415c6403647ae82c9e34c4
|
|
|
|
|
|
| |
Remove all usages of six.
Change-Id: I6ea8d1cdc3060d5c2a4311c7454b66ba75109b0c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.
We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.
Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]
[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328
Change-Id: I73b532283079d346b75a925e2aee707c4de8fa9e
|
|
|
|
| |
Change-Id: I5a35911b5658fdf6bc08844b31cc1325b749526a
|
|
|
|
|
|
|
|
| |
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: Ib83e626f51e6e01898bb7931c1660a1a548500f3
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found.
Change-Id: I5da442bb2f1e634e6b3fe37a6ea3820cea1db96f
|
|
|
|
|
|
|
| |
1. update hacking version to latest
2. fix pep8 failed
Change-Id: I49a6d46466b06bd56bed1f15632c9c80ef539b38
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While executing functional tests in trove project, with baseptyhon
python3 in change [1], there appears few incompatibilities
in troveclient.
All of them are directly related to differences in PY3 version.
This change removes these issues and will allow to execute functional
tests seamlessly.
Change details:
* troveclient/compat/base.py - dict.iteritems was removed in PY3
because dict.items now does the thing dict.iteritems did in PY2
* troveclient/compat/client.py - json.loads expects string, and
PY3 doesnt convert bytes to string. We have to use explicity call
decode() which will decode given bytes to string
* troveclient/apiclient/base.py - to avoid infinite recursion
exception raised when pickling class attributes
[1] I9ee34642c700d1e6ba9c2f3891b7fa1f7f7e1e1d
Change-Id: I8989fd4798e80eae27408017e1543819a68b4ab1
Signed-off-by: Marcin Piwowarczyk <m.piwowarczy@samsung.com>
|
|
|
|
|
|
|
|
|
|
| |
Enable Keystone v3 auth support in the compat client.
This is needed for the Trove integration and scenario tests which
use the compat client. The Keystone v2 APIs have been removed in
the Queens release and this stop-gap fix of putting Keystone v3
support in the compat client is needed to fix the Trove gate.
Change-Id: I60ea2188443d8905c03c24607703e69c6490420b
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.
Also, upgraded hacking requirement, to enable H904 check.
[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
Co-Authored-By: jiansong <jian.song@easystack.cn>
Change-Id: I3f020b6bcb1b9bf6d18a3b4f738c13cccd1bbff8
Closes-Bug: #1596829
|
|
|
|
|
|
|
|
|
|
|
| |
Use xx = [] for the parameter for function, this parameter will
only be initialized at the first call, this is should be avoided.
Better choice is to set the initial value to None, then the initialization
time use xx= xx or []
more information:http://effbot.org/zone/default-values.htm
Change-Id: Icbade7dd4c7d231ae65fd4f8de673b484bab721c
|
|
|
|
|
|
|
|
|
|
|
| |
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNotNone(...) is preferred
over assertNotEqual(None, ...) and assertIsNot(None, ...)
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
Change-Id: Ie2631ce6d5f1756fe520850be0e0d304f41ba760
|
|
|
|
|
|
|
|
|
|
| |
Oslo provides a function, to_slug() in strutils that is substantially
similar to slugify() provided in utils by python-troveclient. Remove
slugify() and use to_slug() instead.
Change-Id: I97bc7cfc2c0e7d14e7617037bff431cdc1eee50f
Closes-Bug: #1266127
Author: Christian Berendt <berendt@b1-systems.de>
|
|
|
|
|
|
|
|
|
|
| |
The dict.keys()[0] will raise a TypeError in PY3,
as dict.keys() doesn't return a list any more in PY3
but a view of list.
Change-Id: Id9c7d3725c01bd0a193d8fc6705443efe9c25c34
Partially implements: blueprint trove-python3
Closes-Bug: #1583419
|
|
|
|
|
|
|
|
|
|
| |
Removing the Rackspace Auth references that are not
supported by an openstack deployment.
Co-Authored-By: Craig Vyvial <cp16net@gmail.com>
Change-Id: I7e630a77eaeb31de0962b31bc2f86becf2975dd8
Closes-Bug: #1401804
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support in the python API and Trove CLI
for module maintenance commands. These commands include:
- module-list
- module-show
- module-create
- module-update
- module-delete
Partially Implements: blueprint module-management
Change-Id: I54d37025275dee4731ad49ebbd21612c4464e4c4
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add api entry points for root-disable to the Trove client.
Added unit tests.
Change-Id: I27831eb361c2b219a9623f152b9def73a2865d67
Partially implements: blueprint root-disable
DocImpact: added new root-disable CLI command
|
|/
|
|
|
|
|
|
|
| |
The oslo.utils reflection module/code handles more variations
of where a class name may come from (on python 2 and python 3)
so its usage allows getting more accurate class names so we might
as well use it.
Change-Id: I7b130d6acb183a06a4efe648ee2c3fbd2905cdd5
|
|
|
|
|
|
|
| |
The name of the function is wrongly
defined and is corrected
Change-Id: I125ebb67544f40dbad6f838765744e0e077d6f01
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the mgmt APIs for
1. Create datastore-version.
2. List datastore-versions.
3. Get details of a datastore-version.
4. Update the attributes of an existing datastore-version.
5. Delete a datastore-version.
Added the code to management.py and the unit-tests,
this code would help for writing integration tests to trove
for the newly added management-apis.
Change-Id: I915baa4c5c8bbe3f0483bcaeaa5ce95044d35bf7
Implements: blueprint datastore-registration-api
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated the hacking version as per global-requirements.
Fixed some of new appearing hacking rules, as listed follows:
- E128 continuation line under-indented for visual indent
- E265 block comment should start with '# '
- E713 test for membership should be 'not in'
- H238 old style class declaration, use new style (inherit from `object`)
Rules which are not yet fixed have been incorporated to ignorelist
- H405 Multi line docstrings should start with a one line summary
followed by an empty line
- H501 Do not use locals() or self.__dict__ for formatting strings
Change-Id: I885c6fa8ad0e6a98f7a8479f3441ed08ed2cbaa6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Oslo libraries have moved all of their code out of the 'oslo'
namespace package into per-library packages. The namespace package was
retained during kilo for backwards compatibility, but will be removed by
the liberty-2 milestone. This change removes the use of the namespace
package, replacing it with the new package names.
The patches in the libraries will be put on hold until application
patches have landed, or L2, whichever comes first. At that point, new
versions of the libraries without namespace packages will be released as
a major version update.
Please merge this patch, or an equivalent, before L2 to avoid problems
with those library releases.
Blueprint: remove-namespace-packages
https://blueprints.launchpad.net/oslo-incubator/+spec/remove-namespace-packages
Change-Id: I2a8caa859830b3416bfe54e4261dd3415ac5a76a
|
|
|
|
|
|
|
|
| |
The python-troveclient module still had references to strutils, and
gettextutils which are now obsolete.
Change-Id: Ia54a565c00966b0a1cb5f18c6e17e1237b2bfee6
Partial-Bug: #1380789
|
|
|
|
|
|
|
| |
add the CRUD calls of configuration parameters mgmt calls
partially implements blueprint configuration-parameters-in-db
Change-Id: Iaaea946bdbcab91ca02e5e2cbf956a3980a461ab
|
|
|
|
|
|
|
|
|
|
|
|
| |
adds clusters support to the troveclient.
Co-Authored-By: Ranjitha Vemula <rvemula@ebaysf.com>
Co-Authored-By: Michael Yu <michayu@ebaysf.com>
Co-Authored-By: Mat Lowery <mlowery@ebaysf.com>
Partially implements: blueprint clustering
Change-Id: I6ed2c4c79a17fcf8f14c587cab6a8ec3acaf319f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows datastore versions to be hidden from all users except those
explicitly allowed by their tenant. Implemented via a visibility
attribute for datastore versions (defaulting to 'public'), and a
datastore version member table for controlling access to non-public
datastore versions by tenant.
This commit provides the client functionality for integration tests
related to the datastore-visibility feature.
Implements: blueprint datastore-visibility
Docimpact: change to datastore version payload
Change-Id: Ic8024a631530ba295688d7e49e895f50cb2f32ef
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Implements: blueprint trove-metadata
Change-Id: I4e498844afd2d2730fad2176dccaf1d61d8798c1
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* E265 block comment should start with '# '
* E128 continuation line under-indented for visual indent
* E713 test for membership should be 'not in'
Tested with pep8 version 1.5.6 (2014-04-14).
Change-Id: If2853c79bea91ebef5cd97dff66788b46b174a9a
|
|\ \ \
| |_|/
|/| | |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Closes bug: 1318258
Compat cli used old configuration_ref parameter
Change-Id: Ia6942186666d1022d4ad67880df90a36785721ce
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reasons:
- F821 is disabled.
- H306 is disabled.
- H402 is disabled.
- H404 is disabled.
Changes:
- Updates tox.ini to enable F821, H306, H402 and H404 rules.
- Updates code for F821, H306, H402 and H404 violation.
Change-Id: I772270bb833ac774e080fc63e330d6b333f23de2
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Module py3kcompat was removed from oslo-incubator, we can use
six directly.
* Sync commit of removing py3kcompat from oslo
* use six replace usage of py3kcompat
Change-Id: I15b9ffb10e2d5765a1ed07dd5fd4e2bf7b21ec49
Closes-Bug: #1280033
|
| |
| |
| |
| |
| |
| |
| | |
"configuration_ref" needs to be "configuration".
Closes-Bug: #1306696
Change-Id: I080de3d4f39e3f0dc34e173e7565b26077b17092
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We will no longer support XML for the trove API; it behooves us to
remove XML related code, and clean up the trove client.
Partially implements bp: destroy-xml-api
Change-Id: I58f95e81f3e4bc4bad277ff2a48abfced2b48199
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make help strings more consistent:
* Fix spelling and capitalization
* Add "." at end of each string
* Fix spaces.
* Improve wording
Change-Id: I22e84ebecb87f1c803cfb8369db3798fe56903ff
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.
Change-Id: Ifbb144e26b62790d8b8ba9b5c3eea7d04844ee19
Closes-Bug:#1280522
|
|/
|
|
|
|
|
|
|
|
|
| |
No need to set tabstop tons of times, this can be set in your vimrc
file instead.
More disucssion:
http://openstack.10931.n7.nabble.com/Remove-vim-modelines-td21780.html
Change-Id: I45766d91f0c0b3622bbdc7dc5517497c87ebee8c
Closes-Bug: #1229324
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason:
Adding configuration group support for the python-troveclient
Changes:
adding configuration api calls
adding the compat client for tests and xml
added the shell cmds for the configurations in the client
made the path to datastore/version/parameters
added unit tests
partially implements blueprint configuration-management
Change-Id: Ifc0b4077c93a805898b4cd157e33172f64e85b55
|
|
|
|
|
|
|
| |
Fixed misspelling of common words found by the 'misspellings' tool.
Change-Id: I8e03379f92b62fd4856bbc74b7e4641226a403d3
Closes-Bug: #1257531
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There are a few checks that already pass:
- F401 - unused imports of modules
- F403 - ‘from module import *’ used; unable to detect undefined names
And there are two (H401 and H403) that can be made
passing easily. Enable gating on all of them.
Change-Id: I9d3c49ecea1b2171d194ab6cc751316c252081e8
|
|/
|
|
|
| |
Change-Id: Icf2b35d152e59f5045717f2a682f89fec23e707e
Implements: blueprint add-volume-total-attribute
|
|\ |
|