diff options
| author | Ade Lee <alee@redhat.com> | 2020-09-11 16:28:11 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2020-12-15 09:52:55 -0500 |
| commit | 5320ecbaf2c0e77842ab1ee3eb8106948dc06704 (patch) | |
| tree | 3d5fb4362e559fe811f426eae3640b20515ea0ae /bandit.yaml | |
| parent | 36107b4a692d7cf63698dd831388193fb1eae51e (diff) | |
| download | swift-5320ecbaf2c0e77842ab1ee3eb8106948dc06704.tar.gz | |
replace md5 with swift utils version
md5 is not an approved algorithm in FIPS mode, and trying to
instantiate a hashlib.md5() will fail when the system is running in
FIPS mode.
md5 is allowed when in a non-security context. There is a plan to
add a keyword parameter (usedforsecurity) to hashlib.md5() to annotate
whether or not the instance is being used in a security context.
In the case where it is not, the instantiation of md5 will be allowed.
See https://bugs.python.org/issue9216 for more details.
Some downstream python versions already support this parameter. To
support these versions, a new encapsulation of md5() is added to
swift/common/utils.py. This encapsulation is identical to the one being
added to oslo.utils, but is recreated here to avoid adding a dependency.
This patch is to replace the instances of hashlib.md5() with this new
encapsulation, adding an annotation indicating whether the usage is
a security context or not.
While this patch seems large, it is really just the same change over and
again. Reviewers need to pay particular attention as to whether the
keyword parameter (usedforsecurity) is set correctly. Right now, all
of them appear to be not used in a security context.
Now that all the instances have been converted, we can update the bandit
run to look for these instances and ensure that new invocations do not
creep in.
With this latest patch, the functional and unit tests all pass
on a FIPS enabled system.
Co-Authored-By: Pete Zaitcev
Change-Id: Ibb4917da4c083e1e094156d748708b87387f2d87
Diffstat (limited to 'bandit.yaml')
| -rw-r--r-- | bandit.yaml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bandit.yaml b/bandit.yaml index e21301446..ed1c2b61e 100644 --- a/bandit.yaml +++ b/bandit.yaml @@ -80,7 +80,7 @@ # B703 : django_mark_safe # (optional) list included test IDs here, eg '[B101, B406]': -tests: [B102, B103, B302, B306, B308, B309, B310, B401, B501, B502, B506, B601, B602, B609] +tests: [B102, B103, B302, B303, B304, B305, B306, B308, B309, B310, B401, B501, B502, B506, B601, B602, B609] # (optional) list skipped test IDs here, eg '[B101, B406]': skips: |