diff options
| author | qinchunhua <qin.chunhua@zte.com.cn> | 2016-10-10 04:43:03 -0400 |
|---|---|---|
| committer | qinchunhua <qin.chunhua@zte.com.cn> | 2016-10-10 08:50:21 +0000 |
| commit | e68032929cd241baab782a5bbaa45fe46df70b05 (patch) | |
| tree | 23c96ec3095ffafec2c6a6f72a1b562965c790bd /taskflow | |
| parent | 50fba9c978b2a3545516f8ea01248b83240b23d0 (diff) | |
| download | taskflow-e68032929cd241baab782a5bbaa45fe46df70b05.tar.gz | |
Using assertIsNone() instead of assertIs(None, ..)
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None).
Change-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d
Diffstat (limited to 'taskflow')
| -rw-r--r-- | taskflow/tests/unit/action_engine/test_compile.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/taskflow/tests/unit/action_engine/test_compile.py b/taskflow/tests/unit/action_engine/test_compile.py index 757bde7..48c51d6 100644 --- a/taskflow/tests/unit/action_engine/test_compile.py +++ b/taskflow/tests/unit/action_engine/test_compile.py @@ -599,7 +599,7 @@ class PatternCompileTest(test.TestCase): self.assertIs(c2, g.node['b']['retry']) self.assertIs(c2, g.node['c']['retry']) self.assertIs(c1, g.node['c2']['retry']) - self.assertIs(None, g.node['c1'].get('retry')) + self.assertIsNone(g.node['c1'].get('retry')) def test_retry_subflows_hierarchy(self): c1 = retry.AlwaysRevert("c1") @@ -624,4 +624,4 @@ class PatternCompileTest(test.TestCase): self.assertIs(c1, g.node['d']['retry']) self.assertIs(c1, g.node['b']['retry']) self.assertIs(c1, g.node['c']['retry']) - self.assertIs(None, g.node['c1'].get('retry')) + self.assertIsNone(g.node['c1'].get('retry')) |