diff options
| author | Zhao Lei <zhaolei@cn.fujitsu.com> | 2015-09-23 18:49:26 +0800 |
|---|---|---|
| committer | Zhao Lei <zhaolei@cn.fujitsu.com> | 2015-09-23 18:49:26 +0800 |
| commit | c7c9647a0b0bbcf6115b885895207af3343d4835 (patch) | |
| tree | 1f8a59c3603817d8f4499bedafd28d5d4e5c8a55 /tools | |
| parent | 6a42f662e2a474734e89a3a1dfa8a14519a81e75 (diff) | |
| download | taskflow-c7c9647a0b0bbcf6115b885895207af3343d4835.tar.gz | |
Remove quotes from subshell call in bash script
Always no quotes for $() statement.
We don't need quotes to hold blanks in result:
# i=$(echo 1 2 3)
# echo $i
1 2 3
#
These quotes can make something wrong in some case:
# i=$(echo '!')
#
# i="$(echo '!')"
-bash: !: event not found
#
No real problem for current code, only to use a better code style.
Change-Id: I0f43bb936f956c99603dc15aaad9db851ecf0acd
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/update_states.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/update_states.sh b/tools/update_states.sh index 60ca3d4..61b54e8 100755 --- a/tools/update_states.sh +++ b/tools/update_states.sh @@ -12,7 +12,7 @@ if [ ! -d "$PWD/.diagram-tools" ]; then git clone "https://github.com/vidarh/diagram-tools.git" "$PWD/.diagram-tools" fi -script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" +script_dir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd ) img_dir="$script_dir/../doc/source/img" echo "---- Updating task state diagram ----" |