diff options
| author | gecong1973 <ge.cong@zte.com.cn> | 2016-09-30 16:13:59 +0800 |
|---|---|---|
| committer | gecong1973 <ge.cong@zte.com.cn> | 2016-09-30 16:13:59 +0800 |
| commit | 9f92ca853f8aa2f72921e54682c918941a8f0919 (patch) | |
| tree | 4e9a16618df275ff6e2e71b848b61f9573395a1c | |
| parent | 8d48fb0cd90337d39f085e5fc54ea8ba64b44fb0 (diff) | |
| download | trove-integration-9f92ca853f8aa2f72921e54682c918941a8f0919.tar.gz | |
Change assertTrue(isinstance()) by optimal assert
Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided
by testtools
Change-Id: Ib303f68d83db760dae045f0416f257c4622fa777
| -rw-r--r-- | tests/integration/tests/volumes/driver.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/integration/tests/volumes/driver.py b/tests/integration/tests/volumes/driver.py index 6950046..221b2a4 100644 --- a/tests/integration/tests/volumes/driver.py +++ b/tests/integration/tests/volumes/driver.py @@ -110,7 +110,7 @@ class VolumeTest(unittest.TestCase): self.storyFail = storyFail def assert_volume_as_expected(self, volume): - self.assertTrue(isinstance(volume["id"], Number)) + self.assertIsInstance(volume["id"], Number) self.assertEqual(self.story.volume_name, volume["display_name"]) self.assertEqual(self.story.volume_desc, volume["display_description"]) self.assertEqual(1, volume["size"]) |