summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorZhao Chao <zhaochao1984@gmail.com>2018-02-24 21:59:58 +0800
committerZhao Chao <zhaochao1984@gmail.com>2018-02-28 09:14:36 +0800
commit579f5afc6441e2279d3d660b90268c760238202a (patch)
treed7ae47d05c79bf348c8e979e5c63709ec7d4daaf /tools
parentb59b6ae9680d69e96439b925850d4bf96e63adf1 (diff)
downloadtrove-579f5afc6441e2279d3d660b90268c760238202a.tar.gz
Use RootHistory to check if root is ever enabled
When disabling root, there is no need to call guestagent to check whether the root user is ever enabled. Root hisotry table should be used for this purpose. As datastore specific root controller of MySQL/Cassandra/PostgreSQL were created only for the '_find_root_user' which were calling guestagent to find root user, these controllers are removed and 'DefaultRootController' is used instead. RedisRootController is also updated as it didn't do this check previously. Unittests directory structure is also slightly changed. It's more clear to use similar directory hierarchies for testing and source code, e.g. trove/extensions/common/service.py trove/tests/unitests/extensions/common/test_service.py Change-Id: I9faac61d9650347b51f23e8fcaf5a92aed5fbf93 Signed-off-by: Zhao Chao <zhaochao1984@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/trove-pylint.config12
1 files changed, 0 insertions, 12 deletions
diff --git a/tools/trove-pylint.config b/tools/trove-pylint.config
index 970a7ce6..cacdadef 100644
--- a/tools/trove-pylint.config
+++ b/tools/trove-pylint.config
@@ -844,18 +844,6 @@
"DesignateDriver.delete_entry"
],
[
- "trove/extensions/common/service.py",
- "E1101",
- "Instance of 'DefaultRootController' has no '_find_root_user' member",
- "DefaultRootController.root_delete"
- ],
- [
- "trove/extensions/common/service.py",
- "no-member",
- "Instance of 'DefaultRootController' has no '_find_root_user' member",
- "DefaultRootController.root_delete"
- ],
- [
"trove/extensions/mgmt/instances/service.py",
"E1101",
"Instance of 'BuiltInstance' has no 'get_diagnostics' member",