summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorDoug Hellmann <doug@doughellmann.com>2018-06-13 15:45:36 -0400
committerMarcin Piwowarczyk <m.piwowarczy@samsung.com>2018-09-17 16:14:54 +0200
commit7e4e25f12feba32202e082d2f8b84a23cb9ae3af (patch)
treef4eec7533154b89b67dd9566e620d7da445728c7 /tools
parent6c6d43eb1a74cfb985308caae8d26d72b9581522 (diff)
downloadtrove-7e4e25f12feba32202e082d2f8b84a23cb9ae3af.tar.gz
update pylint to 1.9.2
The older version of pylint being used does not work correctly under python 3. In order to be able to update the pylint job to run under python 3, we need to update the tool. This patch updates to the latest version at this time. It also updates and pins astroid, which was previously capped. Using a pin instead of a cap should let us avoid issues with new releases while being specific about which version to actually use. Disable not-callable because that appears to be a new rule that is confused by the use of properties to access things that are set to callables. Co-Authored-By: Fan Zhang <zh.f@outlook.com> Co-Authored-By: Marcin Piwowarczyk <m.piwowarczy@samsung.com> Change-Id: I65705804b222dcd30a653fe10be3d823fa6143ff Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/trove-pylint.README5
-rw-r--r--tools/trove-pylint.config2
2 files changed, 2 insertions, 5 deletions
diff --git a/tools/trove-pylint.README b/tools/trove-pylint.README
index b7811b10..afbf629e 100644
--- a/tools/trove-pylint.README
+++ b/tools/trove-pylint.README
@@ -161,10 +161,7 @@ and astroid. In testing, I've found that if the version of either of
these changes, you could either have a failure of the tool (exceptions
thrown, ...) or a different set of errors reported.
-Currently, test-requirements.txt sets these versions in this way.
-
-astroid<1.4.0 # LGPLv2.1 # breaks pylint 1.4.4
-pylint==1.4.5 # GPLv2
+Refer to test-requirements.txt to see the versions currently being used.
If you run the tool on your machine and find that there are no errors,
but find that either the CI generates errors, or that the tool run
diff --git a/tools/trove-pylint.config b/tools/trove-pylint.config
index cacdadef..1682191f 100644
--- a/tools/trove-pylint.config
+++ b/tools/trove-pylint.config
@@ -7,7 +7,7 @@
"Undefined variable '_LW'"
],
"folder": "trove",
- "ignored_codes": [],
+ "ignored_codes": ["not-callable"],
"ignored_file_code_messages": [
[
"trove/backup/models.py",