diff options
author | Zhao Chao <zhaochao1984@gmail.com> | 2018-02-24 14:56:32 +0800 |
---|---|---|
committer | Zhao Chao <zhaochao1984@gmail.com> | 2018-03-01 10:52:26 +0800 |
commit | 8ce9d735d25d209a747b8f29c614236b74f95591 (patch) | |
tree | c35c299a0cb180052ceeb48bff34d6bc0c981e6d /tox.ini | |
parent | d6bd37f3f337b1756730c55164834a18c86e7018 (diff) | |
download | trove-8ce9d735d25d209a747b8f29c614236b74f95591.tar.gz |
Fix guestagent.test_operating_system for Python3
* Tests for _write_file_as_root failed because tempfile.NamedTemporaryFile
use binary mode by default, changing to text mode fixes.
* Migrate to olso_serialization.base64 for Base64Codec. Also change the
return value from bytearray to bytes for Base64Codec.deserialize.
Base64Codec supports reverse encoding(i.e. binary data will be written
to the dest file), in this situation, the dest file should be opened
with binary mode(and when reading from the file, binary mode should
also be used).
* stream_codecs.StringConverter converts iterable objects with map
function. The behavior of map function is different under Python 2.x
and 3.x. However csv.writerows(before Python 3.5) and unpack_singleton in
trove.common.utils both need a list object. Converting the return
value of map function to a list explicitly before passing to these
functions fixes.
guestagent.test_operating_system is the last blacklist regex pattern for
py3 unittests. With the above problems fixed, blacklist-py3.txt is not
needed any more, and tox.ini is also updateted.
Migrating from ostestr to stestr is also done while updating tox.ini.
Here is the ML post for more information about os-testr and stestr:
http://lists.openstack.org/pipermail/openstack-dev/2017-September/122135.html
Partially implements: blueprint trove-python3
Change-Id: I31f1f97901d6ebff8a91c1b70a343e724ab806eb
Signed-off-by: Zhao Chao <zhaochao1984@gmail.com>
Diffstat (limited to 'tox.ini')
-rw-r--r-- | tox.ini | 13 |
1 files changed, 7 insertions, 6 deletions
@@ -32,20 +32,21 @@ commands = flake8 doc8 {posargs} +[stestr-base] +commands = stestr run --serial '{posargs}' + stestr slowest + [testenv:py27] commands = {[testenv]commands} - ostestr {posargs} --slowest --serial - -[py3base] -commands = ostestr --slowest --blacklist-file=blacklist-py3.txt --serial --regex '.*' + {[stestr-base]commands} [testenv:py34] commands = {[testenv]commands} - {[py3base]commands} + {[stestr-base]commands} [testenv:py35] commands = {[testenv]commands} - {[py3base]commands} + {[stestr-base]commands} [testenv:apiexamples] commands = {envpython} generate_examples.py |