summaryrefslogtreecommitdiff
path: root/trove/hacking
diff options
context:
space:
mode:
authorValencia Serrao <vserrao@us.ibm.com>2017-11-22 15:49:27 +0530
committerValencia Serrao <vserrao@us.ibm.com>2017-12-06 18:24:06 +0530
commite2afdadb68a61ce111c5992b8912dff77bb7e658 (patch)
treee89c9498d0bf9c8f9b849ab5b9207cee791d2abd /trove/hacking
parentccb6752f6973a7d1c8bb08675fde421710942998 (diff)
downloadtrove-e2afdadb68a61ce111c5992b8912dff77bb7e658.tar.gz
Replace assertRaisesRegexp with assertRaisesRegex
This replaces the deprecated (in python 3.2) unittest.TestCase method assertRaisesRegexp() with assertRaisesRegex() Added hacking rule 'assert_raises_regexp' Change-Id: Ie427bfd5af8474119a9e20cc025cd28abfa42cc2
Diffstat (limited to 'trove/hacking')
-rw-r--r--trove/hacking/checks.py15
1 files changed, 15 insertions, 0 deletions
diff --git a/trove/hacking/checks.py b/trove/hacking/checks.py
index 965f0c3d..0ca2f883 100644
--- a/trove/hacking/checks.py
+++ b/trove/hacking/checks.py
@@ -115,8 +115,23 @@ def check_no_basestring(logical_line):
yield(0, msg)
+asse_raises_regexp = re.compile(r"assertRaisesRegexp\(")
+
+
+def assert_raises_regexp(logical_line):
+ """Check for usage of deprecated assertRaisesRegexp
+
+ N335
+ """
+ res = asse_raises_regexp.search(logical_line)
+ if res:
+ yield (0, "N335: assertRaisesRegex must be used instead "
+ "of assertRaisesRegexp")
+
+
def factory(register):
register(validate_log_translations)
register(no_translate_debug_logs)
register(check_raised_localized_exceptions)
register(check_no_basestring)
+ register(assert_raises_regexp)