summaryrefslogtreecommitdiff
path: root/trove/instance
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2022-05-08 00:39:06 +0000
committerGerrit Code Review <review@openstack.org>2022-05-08 00:39:06 +0000
commit3d0782707bfd94f0a310b09c6794a7bd9b2bf48b (patch)
tree087b6207602faca286699daca25b7381387569ed /trove/instance
parent4741b57c09852d8ca413f8ff5ba73f763636db1f (diff)
parent0f666fb95f1909932fe635d8717e7ff66d7f7b44 (diff)
downloadtrove-3d0782707bfd94f0a310b09c6794a7bd9b2bf48b.tar.gz
Merge "instance model: fix extraction of ip addresses from instance record"
Diffstat (limited to 'trove/instance')
-rw-r--r--trove/instance/models.py18
1 files changed, 9 insertions, 9 deletions
diff --git a/trove/instance/models.py b/trove/instance/models.py
index fe424bc8..e09ea77a 100644
--- a/trove/instance/models.py
+++ b/trove/instance/models.py
@@ -262,18 +262,18 @@ class SimpleInstance(object):
def get_visible_ip_addresses(self):
"""Returns IPs that will be visible to the user."""
- if self.addresses is None:
+ if not self.addresses:
return None
IPs = []
-
- for addr_info in self.addresses:
- if CONF.ip_regex and CONF.black_list_regex:
- if not ip_visible(addr_info['address'], CONF.ip_regex,
- CONF.black_list_regex):
- continue
-
- IPs.append(addr_info)
+ for address_list in self.addresses.values():
+ for addr_info in address_list:
+ if CONF.ip_regex and CONF.black_list_regex:
+ if not ip_visible(addr_info['addr'], CONF.ip_regex,
+ CONF.black_list_regex):
+ continue
+
+ IPs.append(addr_info['addr'])
return IPs