summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Shrewsbury <shrewsbury.dave@gmail.com>2018-01-04 11:50:12 -0500
committerDavid Shrewsbury <shrewsbury.dave@gmail.com>2018-01-04 11:50:12 -0500
commit2af7139e3fafc9f6d023400465e9d30eb2fde4a2 (patch)
tree331eb563396d437b51f5c165344aa6e1a26200ab
parent79a66ddab89278f90f9172d8a20ceb87eca770a2 (diff)
downloadzuul-2af7139e3fafc9f6d023400465e9d30eb2fde4a2.tar.gz
Don't remove builds that don't exist
We saw test_reconfigure_window_fixed test fail in the change to switch to Ansible 2.4. This may have been a timing bug where we try to remove a build that we've already removed. Change-Id: Ic55eeb35589b6469b0dcce8267f49eda852a49f7
-rw-r--r--zuul/model.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/zuul/model.py b/zuul/model.py
index cc2fea7e2..16a701ddc 100644
--- a/zuul/model.py
+++ b/zuul/model.py
@@ -1386,6 +1386,8 @@ class BuildSet(object):
build.build_set = self
def removeBuild(self, build):
+ if build.job.name not in self.builds:
+ return
self.tries[build.job.name] += 1
del self.builds[build.job.name]