diff options
| author | Zuul <zuul@review.opendev.org> | 2022-09-08 21:05:02 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2022-09-08 21:05:02 +0000 |
| commit | 47227b743f0daeac5a870ab10a29ace8ecfedaf3 (patch) | |
| tree | f45f78ac639c8dd2fb9d3ee39940eb10aff5a781 | |
| parent | 2bc60aaf8b4049815d3e11a19abba530939a2672 (diff) | |
| parent | 78050adb51b34ebcae22a9cf5dbf7fcefb71badd (diff) | |
| download | zuul-47227b743f0daeac5a870ab10a29ace8ecfedaf3.tar.gz | |
Merge "zuul_stream : Use !127.0.0.1 for loopback"
| -rw-r--r-- | playbooks/zuul-stream/2.7-container.yaml | 2 | ||||
| -rw-r--r-- | playbooks/zuul-stream/create-inventory.yaml | 2 | ||||
| -rw-r--r-- | playbooks/zuul-stream/functional.yaml | 1 | ||||
| -rw-r--r-- | zuul/ansible/base/callback/zuul_stream.py | 14 |
4 files changed, 9 insertions, 10 deletions
diff --git a/playbooks/zuul-stream/2.7-container.yaml b/playbooks/zuul-stream/2.7-container.yaml index dfab08dfe..76998a01d 100644 --- a/playbooks/zuul-stream/2.7-container.yaml +++ b/playbooks/zuul-stream/2.7-container.yaml @@ -18,4 +18,4 @@ - name: Accept host keys shell: | ssh-keyscan -p 2022 localhost >> ~/.ssh/known_hosts - ssh-keyscan -p 2022 127.0.0.1 >> ~/.ssh/known_hosts + ssh-keyscan -p 2022 127.0.0.2 >> ~/.ssh/known_hosts diff --git a/playbooks/zuul-stream/create-inventory.yaml b/playbooks/zuul-stream/create-inventory.yaml index 8ade2ab92..c2be02749 100644 --- a/playbooks/zuul-stream/create-inventory.yaml +++ b/playbooks/zuul-stream/create-inventory.yaml @@ -23,7 +23,7 @@ hosts: node3: ansible_connection: ssh - ansible_host: 127.0.0.1 + ansible_host: 127.0.0.2 ansible_port: 2022 ansible_user: root ansible_python_interpreter: /usr/local/bin/python2.7 diff --git a/playbooks/zuul-stream/functional.yaml b/playbooks/zuul-stream/functional.yaml index 537f9b9d5..63e13e3f5 100644 --- a/playbooks/zuul-stream/functional.yaml +++ b/playbooks/zuul-stream/functional.yaml @@ -19,7 +19,6 @@ ZUUL_JOB_LOG_CONFIG: "{{ ansible_user_dir}}/logging.json" ZUUL_JOBDIR: "{{ ansible_user_dir}}" PYTHONPATH: "{{ python_path }}" - ZUUL_CONSOLE_STREAM_LOCALHOST: 1 register: _success_output - name: Save raw output to file diff --git a/zuul/ansible/base/callback/zuul_stream.py b/zuul/ansible/base/callback/zuul_stream.py index fccfdc85d..b5c14691b 100644 --- a/zuul/ansible/base/callback/zuul_stream.py +++ b/zuul/ansible/base/callback/zuul_stream.py @@ -48,10 +48,12 @@ from zuul.ansible import paths from zuul.ansible import logconfig -LOG_STREAM_PORT = int(os.environ.get("ZUUL_CONSOLE_PORT", 19885)) LOG_STREAM_VERSION = 0 -# -LOG_STREAM_LOCALHOST = int(os.environ.get("ZUUL_CONSOLE_STREAM_LOCALHOST", 0)) + +# This is intended to be only used for testing where we change the +# port so we can run another instance that doesn't conflict with one +# setup by the test environment +LOG_STREAM_PORT = int(os.environ.get("ZUUL_CONSOLE_PORT", 19885)) def zuul_filter_result(result): @@ -322,15 +324,13 @@ class CallbackModule(default.CallbackModule): hosts = self._get_task_hosts(task) for host, inventory_hostname in hosts: port = LOG_STREAM_PORT - if (host in ('localhost', '127.0.0.1') and - not LOG_STREAM_LOCALHOST): + if (host in ('localhost', '127.0.0.1')): # Don't try to stream from localhost continue ip = play_vars[host].get( 'ansible_host', play_vars[host].get( 'ansible_inventory_host')) - if (ip in ('localhost', '127.0.0.1') and - not LOG_STREAM_LOCALHOST): + if (ip in ('localhost', '127.0.0.1')): # Don't try to stream from localhost continue if play_vars[host].get('ansible_connection') in ('winrm',): |